OpenStack Dashboard (Horizon)

Need to add Development environment files to ignore list

Bug #1256043 reported by Sushil Kumar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance Client
Won't Fix
Undecided
Sushil Kumar
OpenStack Dashboard (Horizon)
Won't Fix
Undecided
Sushil Kumar
OpenStack Object Storage (swift)
Won't Fix
Undecided
Sushil Kumar
python-cinderclient
Fix Released
Undecided
Sushil Kumar
python-cinderclient 1.3.1 "1.3.1"
python-keystoneclient
Fix Released
Wishlist
Sushil Kumar
python-keystoneclient 0.4.2
python-novaclient
Fix Released
Wishlist
Sushil Kumar
python-novaclient 2.18.0
python-swiftclient
Won't Fix
Undecided
Sushil Kumar

Bug Description

Following files generated by Eclipse development environment should be in ignore list to avoid their inclusion during a git push.

.project
.pydevproject

See original description
Sushil Kumar (sushil-kumar2)
Changed in horizon:
assignee: nobody → Sushil Kumar (sushil-kumar2)
Changed in ceilometer:
assignee: nobody → Sushil Kumar (sushil-kumar2)
Changed in neutron:
assignee: nobody → Sushil Kumar (sushil-kumar2)
Changed in swift:
assignee: nobody → Sushil Kumar (sushil-kumar2)
Changed in tempest:
assignee: nobody → Sushil Kumar (sushil-kumar2)
Changed in python-ceilometerclient:
assignee: nobody → Sushil Kumar (sushil-kumar2)
Changed in python-cinderclient:
assignee: nobody → Sushil Kumar (sushil-kumar2)
Changed in python-glanceclient:
assignee: nobody → Sushil Kumar (sushil-kumar2)
Changed in python-keystoneclient:
assignee: nobody → Sushil Kumar (sushil-kumar2)
Sushil Kumar (sushil-kumar2)
Changed in python-neutronclient:
assignee: nobody → Sushil Kumar (sushil-kumar2)
Changed in python-novaclient:
assignee: nobody → Sushil Kumar (sushil-kumar2)
description: updated
Changed in python-heatclient:
assignee: nobody → Sushil Kumar (sushil-kumar2)
Changed in python-swiftclient:
assignee: nobody → Sushil Kumar (sushil-kumar2)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/59061

Changed in ceilometer:
status: New → In Progress
Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/59063

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/59065

Changed in tempest:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tempest (master)

Fix proposed to branch: master
Review: https://review.openstack.org/59067

Changed in swift:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to swift (master)

Fix proposed to branch: master
Review: https://review.openstack.org/59069

Changed in python-ceilometerclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-ceilometerclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/59070

Changed in python-cinderclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-cinderclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/59071

Changed in python-novaclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/59072

Changed in python-glanceclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-glanceclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/59073

Changed in python-keystoneclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-keystoneclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/59074

Changed in python-neutronclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-neutronclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/59075

Changed in python-swiftclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-swiftclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/59076

Changed in python-heatclient:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-heatclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/59077

Revision history for this message
yong sheng gong (gongysh) wrote :

I think it is helpful for the developers on eclipse. In fact I think we should allow these files into repo. but it will make things complicated since eclipse developers will have different way to organize their projects which will affect .project and .pydevproject files. many files have text like # vim: tabstop=4 shiftwidth=4 softtabstop=4 for vim fans, why cannot we help eclipse users? So add these into .gitignore will help a little.

Revision history for this message
Steve Baker (steve-stevebaker) wrote :

I *am* an eclipse user and global git excludesfile works perfectly without having to change the .gitignore file of every project I work with

no longer affects: python-heatclient
Revision history for this message
Sushil Kumar (sushil-kumar2) wrote :

Hi Steve

I fully understand that there are multiple ways to avoid this problem.

However, one would be needed to do it on their own.
An entry in .gitignore would help in no developer action needed for this stuff, just trying to make life easier.

Thanks

Revision history for this message
Sushil Kumar (sushil-kumar2) wrote :

https://review.openstack.org/#/c/59077/

Changed in python-heatclient:
assignee: nobody → Sushil Kumar (sushil-kumar2)
Steve Baker (steve-stevebaker)
Changed in python-heatclient:
status: New → Won't Fix
Revision history for this message
Matthias Runge (mrunge) wrote :

I disagree in this as a bug at all. How many different editor configs should we move in here? Sinces git works distributed, you're free to ignore your own .project files.

Changed in horizon:
status: In Progress → Won't Fix
Chmouel Boudjnah (chmouel)
Changed in python-swiftclient:
status: In Progress → Won't Fix
Changed in swift:
status: In Progress → Won't Fix
Revision history for this message
Joe Gordon (jogo) wrote :

I agree with Mathias and Steve, this isn't a bug

Sushil Kumar (sushil-kumar2)
no longer affects: python-cinderclient
OpenStack Infra (hudson-openstack)
Changed in python-cinderclient:
assignee: nobody → Sushil Kumar (sushil-kumar2)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-keystoneclient (master)

Reviewed: https://review.openstack.org/59074
Committed: http://github.com/openstack/python-keystoneclient/commit/5214eababf2a9eaf8c2d58f7a8b45fd40fa60c65
Submitter: Jenkins
Branch: master

commit 5214eababf2a9eaf8c2d58f7a8b45fd40fa60c65
Author: Sushil Kumar <email address hidden>
Date: Thu Nov 28 16:59:35 2013 +0000

    Updates .gitignore

    Adding ignore for Eclipse IDE environment files
    These files .project and .pydevproject should be
    ignored while pushing to repositories.

    Change-Id: If249ec02eb770ab66d2216939a0747dfa51e701a
    Closes-Bug: #1256043

Changed in python-keystoneclient:
status: In Progress → Fix Committed
Dolph Mathews (dolph)
Changed in python-keystoneclient:
importance: Undecided → Low
importance: Low → Wishlist
Abhishek Chanda (abhishek-i)
Changed in python-novaclient:
importance: Undecided → Wishlist
Revision history for this message
Sushil Kumar (sushil-kumar2) wrote :

If community is more concerned to not have the IDE specific ignores in .gitignore then, if everyone confirms can I take the opportunity to remove the IDE specific entries in gitignore of the project

Sean Dague (sdague)
no longer affects: tempest
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-cinderclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/62173

OpenStack Infra (hudson-openstack)
Changed in python-heatclient:
status: Won't Fix → In Progress
OpenStack Infra (hudson-openstack)
Changed in horizon:
status: Won't Fix → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-keystoneclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/62178

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-neutronclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/62180

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-novaclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/62181

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-cinderclient (master)

Reviewed: https://review.openstack.org/59071
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=2e1d92bd6d911be31ccfa1cd920590ecbd0f4d6f
Submitter: Jenkins
Branch: master

commit 2e1d92bd6d911be31ccfa1cd920590ecbd0f4d6f
Author: Sushil Kumar <email address hidden>
Date: Thu Nov 28 16:56:53 2013 +0000

    Updates .gitignore for environment files

    Adding ignore for Eclipse IDE environment files
    These files .project and .pydevproject should be
    ignored while pushing to repositories.

    Change-Id: I44dbdaae71c3ed37c11122f1795d36c401dd431a
    Closes-Bug: #1256043

Changed in python-cinderclient:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/62173
Committed: https://git.openstack.org/cgit/openstack/python-cinderclient/commit/?id=420a8fdceaaa09c99b622b36348973ade395062f
Submitter: Jenkins
Branch: master

commit 420a8fdceaaa09c99b622b36348973ade395062f
Author: Sushil Kumar <email address hidden>
Date: Sat Dec 14 16:31:36 2013 +0000

    Updates .gitignore

    Remove files we don't generate in the sources.

    Closes-Bug: #1256043

    Closes-Bug: #1257279

    Change-Id: I18552182958448baa040c988b02affc231cbf62b

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-heatclient (master)

Reviewed: https://review.openstack.org/62174
Committed: https://git.openstack.org/cgit/openstack/python-heatclient/commit/?id=c9ee833e50088f69c64afc0e8ec9deee5569278e
Submitter: Jenkins
Branch: master

commit c9ee833e50088f69c64afc0e8ec9deee5569278e
Author: Sushil Kumar <email address hidden>
Date: Sat Dec 14 16:38:35 2013 +0000

    Updates .gitignore

    Remove files we don't generate in the sources.

    Change-Id: If544e0048a43ea0533ae068d3802e5bc1b62f826
    Closes-Bug: #1256043

Changed in python-heatclient:
status: In Progress → Fix Committed
Dolph Mathews (dolph)
Changed in python-keystoneclient:
milestone: none → 0.4.2
Thierry Carrez (ttx)
Changed in python-keystoneclient:
status: Fix Committed → Fix Released
Steve Baker (steve-stevebaker)
Changed in python-heatclient:
importance: Undecided → Low
milestone: none → v0.2.7
Steve Baker (steve-stevebaker)
no longer affects: python-heatclient
Joe Gordon (jogo)
Changed in python-novaclient:
status: In Progress → Fix Committed
Michael Still (mikal)
Changed in python-novaclient:
milestone: none → 2.18.0
Michael Still (mikal)
Changed in python-novaclient:
status: Fix Committed → Fix Released
Revision history for this message
Bartosz Fic (bartosz-fic) wrote :

What about other IDEs? For example PyCharm. PyCharms creates directory ".idea". Should we put this also into ".gitignore" ?
In my opinion it isn't even a bug.... Everybody could ignore own .project files using global git excludesfile.

Revision history for this message
gordon chung (chungg) wrote :

we've decide in ceilometer to let users configure own gitignore for such cases... closing ceilo items.

no longer affects: python-ceilometerclient
no longer affects: ceilometer
Doug Hellmann (doug-hellmann)
Changed in python-cinderclient:
status: Fix Committed → Fix Released
Revision history for this message
Cedric Brandily (cbrandily) wrote :

This bug is > 365 days without activity. We are unsetting assignee and milestone and setting status to Incomplete in order to allow its expiry in 60 days.

If the bug is still valid, then update the bug status.

Changed in neutron:
assignee: Sushil Kumar (sushil-kumar2) → nobody
status: In Progress → Incomplete
Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

In Neutron we made the conscious decision to avoid littering .gitignore with specific dev environment. There's no point in beating a dead horse

Changed in python-neutronclient:
status: In Progress → Won't Fix
Changed in neutron:
status: Incomplete → Won't Fix
no longer affects: neutron
no longer affects: python-neutronclient
Revision history for this message
David Lyle (david-lyle) wrote :

Horizon has decided in the past not to merge IDE specific files and let the developer manage their own .gitignore.

Changed in horizon:
status: In Progress → Won't Fix
Ian Cordasco (icordasc)
Changed in python-glanceclient:
status: In Progress → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.