OpenStack Dashboard (Horizon)

mox fix with better placed import

Bug #1298473 reported by Doug Fish
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Triaged
Low
Unassigned

Bug Description

The current fix to make mox not needed in a non dev environment includes a lazy-loading pattern in horizon/test/jasmine/jasmine.py. This is undesirable because we'd like to keep the imports at the top of the file.

Refactor to avoid this pattern. Look at change set 6 from https://review.openstack.org/#/c/79378/ as a potential way to do this. Note that selenium.py in horizon/test/tests should be renamed to selenium_helpers.py because inside a selenium.py file you can't import a module named selenium. PYTHONPATH will load the file first instead of the one in dist-package.

Doug Fish (drfish)
Changed in horizon:
assignee: nobody → Doug Fish (drfish)
Victoria Martinez de la Cruz (vkmc)
Changed in horizon:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/86444

Changed in horizon:
assignee: Doug Fish (drfish) → Maxime Vidori (maxime-vidori)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/133175

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Maxime Vidori (<email address hidden>) on branch: master
Review: https://review.openstack.org/86444
Reason: rebase done here https://review.openstack.org/#/c/133175/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/135619

OpenStack Infra (hudson-openstack)
Changed in horizon:
assignee: Maxime Vidori (maxime-vidori) → mattfarina (mattfarina)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/133175
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Rob Cresswell (robcresswell-deactivatedaccount)
Changed in horizon:
assignee: mattfarina (mattfarina) → nobody
status: In Progress → Triaged
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.