Horizon doesn't support hiding Routers Panel in Sidebar.

Bug #1350639 reported by Kentaro Sasaki
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Akihiro Motoki

Bug Description

We should support hiding Routers Panel in Sidebar.
When we don't provide L3 feature to users, usability will improve if the router panel is hidden.

---local_settings.py---
OPENSTACK_NEUTRON_NETWORK = {
    'enable_lb': False,
    'enable_firewall': False,
    'enable_quotas': True,
    'enable_vpn': False,
+ 'enable_routers': False,
    # The profile_support option is used to detect if an external router can be
    # configured via the dashboard. When using specific plugins the
    # profile_support can be turned on if needed.
    'profile_support': None,
    #'profile_support': 'cisco',
}
---

Tags: neutron
Changed in horizon:
assignee: nobody → Kentaro SASAKI (mathomd)
tags: added: neutron
Revision history for this message
Julie Pichon (jpichon) wrote :

Is there an API call we could use to dynamically determine if L3/routers is supported, rather than add another setting?

This will also affects the Network Topology graph I think.

Revision history for this message
Kentaro Sasaki (kentarosasaki) wrote :

> Is there an API call we could use to dynamically determine if L3/routers is supported, rather than add another setting?
> This will also affects the Network Topology graph I think.
Thank you for pointing that out.

I think there is no API to do that and I found that hiding routers panel will affect the Network Topology.

https://bugs.launchpad.net/horizon/+bug/1292022
One of the reason why I reported this bug is that disabling router causes error on Horizon which is reported in above link.

So we decided to take workaround for using neutron quota function.
Like this:
$ sudo neutron quota-update --router=0
With setting, user cannot create routers.

Revision history for this message
Shuichiro MAKIGAKI (shuichiro-makigaki) wrote :

Administrators often would like to restrict router feature access to admin by policy.json RBAC or quota. This is a possible use case. (for example, big flat network or management policy.) This means that users can't manage routers via Horizon however Neutron's L3/Routers is working.

If users can't change routers or don't have to see the information, Routers panel doesn't need to be visible. Therefore, Kentaro's idea is good to configure show/hide Routers panel basically.

However, as Julie said, Network Topology will be affected. bug 1160580 and bug 1292022 say Horizon needs L3/Router feature .

You will have to fix Network Topology panel as well to work without routers panel. You may have to disable all link to router panel's URL (/project/routers*) over Horizon. It may be hard...but valuable!

Revision history for this message
Julie Pichon (jpichon) wrote :

Thank you for pointing to the other bugs. This may be more easily tracked using a blueprint (Horizon still uses a blueprint and there won't be any issue with approving that one), so that we can link all the related bugs.

Changed in horizon:
status: New → Confirmed
importance: Undecided → Medium
Changed in horizon:
assignee: Kentaro SASAKI (mathomd) → nobody
Revision history for this message
Akihiro Motoki (amotoki) wrote :

Neutron L3 feature affects both router and floating IP features, so the situation is a bit complicated. There are two cases.
(1) Neutron does not provide L3 features (due to a backend plugin configuration)
(2) Neutron provides L3 features but a deployer wants to disable Horizon Router panel.

For case (1), we can know whether L3 feature is provided through Neutron extension list API. Note that the configuration depends on backend neutron plugins and deployers cannot control it without modifying the code. bug 1292022 reports this case.

For case (2), Horizon need a configuration for this. The comment from Shuichiro is talking about this case.

BTW, do you want to disable floating IP feature too?

Akihiro Motoki (amotoki)
Changed in horizon:
assignee: nobody → Akihiro Motoki (amotoki)
Revision history for this message
Akihiro Motoki (amotoki) wrote :
Revision history for this message
Kentaro Sasaki (kentarosasaki) wrote :

> BTW, do you want to disable floating IP feature too?
In my case, it is good to disable floating IP feature.

Thanks.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/113336

Changed in horizon:
status: Confirmed → In Progress
Changed in horizon:
assignee: Akihiro Motoki (amotoki) → David Lyle (david-lyle)
Changed in horizon:
assignee: David Lyle (david-lyle) → Akihiro Motoki (amotoki)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/113336
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=11001691308b633abf6cac378ae926677ad0d903
Submitter: Jenkins
Branch: master

commit 11001691308b633abf6cac378ae926677ad0d903
Author: Akihiro Motoki <email address hidden>
Date: Sat Aug 9 09:45:56 2014 +0900

    Add a config option to disable Router panel

    Neutron setup allows operators not to enable Router feautre
    (by not using Router service plugin in neutron.conf) and
    some Neutron plugin does not support Router feature.
    According to bug 1350639 there is also a case where operators
    want to disable Router panel from their policy.
    It seems nice we have a option to control Router panel.

    This commit add a new option 'enable_router' to OPENSTACK_NEUTRON_NETWORK.
    The default is True since router feature is enabled in most deployments
    and it is the current default behavior of Horizon.
    If this option is False, Router panel will disappear.

    blueprint hide-router-panel-by-config
    Partial-Bug: #1292022
    Closes-Bug: #1350639
    Change-Id: If90517bd35c5b18173c54c14a1ba229f97ba4797

Changed in horizon:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in horizon:
milestone: none → juno-3
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.