missing Save/Cancel icons in many dialogues

Bug #1519592 reported by Martin Pavlásek
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
In Progress
Low
Sunkara Ramya Sree

Bug Description

I've noticed there are many dialogues that are actually missing icons by 'Cancel' and 'Save' buttons on the bottom. At this moment it's fine for example in Admin - System - Flavors - Update Flavor metadata.

Missing icons (probably some others are missing here):
Admin - System - Flavors - Edit Flavors
Admin - System - Volumes - QoS Spec, Edit Spec Value
Admin - System - Instances - Edit instance
Admin - System - Metadata Definitions, Instance per host - Update associacions
Admin - Identity - Domains - Edit domain
Admin - Projects - Edit project

Revision history for this message
Floren (florenllanos) wrote :

Hi Martin,

I have not been able to verify your examples (for exemple, see screenshot). Could you update your OpenStack / devstack installation and check it another once?

Revision history for this message
Floren (florenllanos) wrote :
Revision history for this message
Floren (florenllanos) wrote :

I can't reproduce

Changed in horizon:
status: New → Invalid
Revision history for this message
Martin Pavlásek (mpavlase) wrote :

Hi Floren,

the bug is about icons in buttons. Please open in one tab:
Admin - System - Flavors - Update Flavor metadat
and this dialogue side by side:
Admin - Projects - Edit project

Revision history for this message
Floren (florenllanos) wrote :

Excuse me Martin!!! I was wrong. I did not understand correctly this error. It's a valid bug!!!!

Thanks for the aclaration!!

Changed in horizon:
status: Invalid → Confirmed
Revision history for this message
Martin Pavlásek (mpavlase) wrote :

@robcresswell

Hi, I don't think that duplication flag of this bug is set correctly - the bug #1481622 is about missing 'Cancel' button, but this one is about missing _icons_ in buttons of several dialogues. It's a different situation, I think.

Changed in horizon:
assignee: nobody → tachien (whitetiger50512)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/290520

Changed in horizon:
assignee: tachien (whitetiger50512) → allenwhale (allencat850502)
status: Confirmed → In Progress
Changed in horizon:
importance: Undecided → Low
milestone: none → ongoing
Changed in horizon:
milestone: ongoing → next
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/290520
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message
Sunkara Ramya Sree (ramyasunkara) wrote :

Can I take this bug

Changed in horizon:
assignee: allenwhale (allencat850502) → Sunkara Ramya Sree (ramyasunkara)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/373359

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Ivan Kolodyazhny (<email address hidden>) on branch: master
Review: https://review.openstack.org/373359
Reason: This review is > 4 months without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.