Horizon should be restricted to display overlapping network as interface to router

Bug #1746533 reported by Puneet Arora
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
In Progress
Ahmed Zaid

Bug Description

Horizon should be restricted to display overlapping networks which can be added as interface to same router.

1) Create network-1 and subnet-1 with cidr
2) Create network-2 and subnet-2 with cidr (Note*: Overlapping networks)
3) Create router-1.
4) From horizon please go to Project --> Network --> Routers --> router1.
5) Add router1 interface to subnet-1.
6) Add router1 interface to subnet-2 now exception appears.

While performing step 6, if router is already added to subnet-1 then subnet-2 shouldn't get displayed because both are overlapping networks.
There is no sense of displaying subnet-2 to get attach to router it will lead to result in exception.

Is Horizon could be improved to filter if there is a a overlapping network and it could exclude that?

Revision history for this message
Akihiro Motoki (amotoki) wrote :

This is not a neutron bug. The affected project is changed to horizon.

affects: neutron → horizon
Akihiro Motoki (amotoki)
tags: added: neutron
Revision history for this message
Akihiro Motoki (amotoki) wrote :

If we add a logic to check a case reported here, we need to replicate the neutron logic. The neutron logic is found here: https://github.com/openstack/neutron/blob/f5e7cff7026488acf779909479a82c927a871a20/neutron/db/l3_db.py#L628-L644

Changed in horizon:
status: New → Confirmed
importance: Undecided → Low
tags: added: low-hanging-fruit
Ahmed Zaid (ahmedzaid10)
Changed in horizon:
assignee: nobody → Ahmed Zaid (ahmedzaid10)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/540765

Changed in horizon:
status: Confirmed → In Progress
Akihiro Motoki (amotoki)
Changed in horizon:
milestone: none → rocky-1
Ivan Kolodyazhny (e0ne)
Changed in horizon:
milestone: rocky-1 → rocky-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Ivan Kolodyazhny (<email address hidden>) on branch: master
Review: https://review.openstack.org/540765
Reason: This review is > 4 months without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.