Navigation on ngdetails is not reproduced properly when specified navigation is not exist

Bug #1761036 reported by Shu Muto
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Ivan Kolodyazhny

Bug Description

This issue is caused by that fixed the bug , when the navigation does not have specified panel originally.

e.g. when the non-admin user who does not have menu for "Admin" dashboard specifies "?nav=/admin/images/" at the end of URL, like http://host.domain/ngdetails/OS::Glance::Image/ce46ef50-850a-46ed-8707-bd5b21e4f9b7?nav=%2Fadmin%2Fimages%2F .
It means to reproduce navigation for the ngdetails view as on "Admin" dashboard.

Revision history for this message
Shu Muto (shu-mutou) wrote :

When we fix , and it provides route for 404 page, it may good to route to 404 page if proper panel is not found.

Ivan Kolodyazhny (e0ne)
Changed in horizon:
status: New → Confirmed
importance: Undecided → Medium
milestone: none → rocky-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master

Changed in horizon:
assignee: nobody → Shu Muto (shu-mutou)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Ivan Kolodyazhny (<email address hidden>) on branch: master
Reason: This review is > 4 months without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Changed in horizon:
assignee: Shu Muto (shu-mutou) → Ivan Kolodyazhny (e0ne)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Submitter: Zuul
Branch: master

commit 8c03ce0bcc56631752da0cfb6d3fdf261b238a20
Author: Shu Muto <email address hidden>
Date: Wed Jul 4 16:29:36 2018 +0900

    Move to 404 page if specified navigation not found

    When refresh or link directly to ngdetails without correct navigation
    to be set, ngdetails view can not reproduce navigations, i.e. sidebar
    and breadcrumb.
    e.g. when the ordinary user try to open the URL specified as admin side.

    In this situation, ngdetails view should show 404 page.
    So this patch move to 404 page if the navigation does not exist.

    Change-Id: I7aeeddf838923d110703bfd7a04699b056c2abd5
    Closes-Bug: #1761036

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon

This issue was fixed in the openstack/horizon development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.