[SRU] Add audio rt713 and rt718 support on ThinkPad TM2

Bug #2089891 reported by AaronMa
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HWE Next
In Progress
High
AaronMa
firmware-sof (Ubuntu)
Fix Released
Undecided
Unassigned
Noble
Fix Released
Undecided
Unassigned
Oracular
Fix Released
Undecided
Unassigned
linux (Ubuntu)
Invalid
High
Unassigned
Noble
Invalid
Undecided
Unassigned
Oracular
In Progress
High
Unassigned
linux-oem-6.11 (Ubuntu)
Invalid
High
Unassigned
Noble
Fix Released
High
Unassigned
Oracular
Invalid
Undecided
Unassigned

Bug Description

[Impact]
There is no sound cards on Intel LNL platform of ThinkPad TM2.

[Fix]
Add soc-acpi table entry on LNL for ThinkPad TME laptop
with rt713 and rt718.

This kernel patch depends on new sof firmware:
db771bf v2.11.x: add new 2.11.2 topology2 production binaries
665e39d Add SOF v2.11.1 signed Intel binaries for MTL/LNL/ARL

The sof-firmware will be SRU in bug 2086250

[Test]
Tested on hardware, audio input and output can work
with the patch and new sof-firmware.

$ cat /proc/asound/cards
 0 [sofsoundwire ]: sof-soundwire - sof-soundwire
                      LENOVO-21NTZCF5CN-ThinkPadX1CarbonGen13
$ speaker-test -c 2
$ arecord -f cd cd.wav

[Where problems could occur]
It may break audio on Intel LNL platform.

The commit is from 6.12 kernel;
LNL is only supported on 6.11+ kernel;
So SRU for oem-6.11 and oracular only.

Related branches

AaronMa (mapengyu)
tags: added: jira-sutton-244 oem-priority
Changed in linux (Ubuntu Noble):
status: New → Invalid
Changed in linux (Ubuntu Oracular):
status: New → In Progress
Changed in linux-oem-6.11 (Ubuntu Noble):
status: New → In Progress
Changed in linux-oem-6.11 (Ubuntu Oracular):
status: New → Invalid
Changed in hwe-next:
status: New → In Progress
assignee: nobody → AaronMa (mapengyu)
importance: Undecided → High
Changed in linux (Ubuntu):
importance: Undecided → High
Changed in linux (Ubuntu Oracular):
importance: Undecided → High
Changed in linux-oem-6.11 (Ubuntu):
status: New → In Progress
importance: Undecided → High
Changed in linux-oem-6.11 (Ubuntu Noble):
importance: Undecided → High
AaronMa (mapengyu)
description: updated
Agathe Porte (gagath)
Changed in linux (Ubuntu):
status: New → Invalid
description: updated
Revision history for this message
AaronMa (mapengyu) wrote :

05f6b0f (tag: v2024.09.2) v2.11.x: add new 2.11.3 topology2 production binaries

sof-bin-2024.09.2 is released with the fix of SUTTON-244 and
https://github.com/thesofproject/sof/issues/9681

LEE KUAN-YING (kyyc0426)
Changed in linux-oem-6.11 (Ubuntu Noble):
status: In Progress → Fix Committed
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the linux-oem-6.11/6.11.0-1010.10 kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-noble-linux-oem-6.11' to 'verification-done-noble-linux-oem-6.11'. If the problem still exists, change the tag 'verification-needed-noble-linux-oem-6.11' to 'verification-failed-noble-linux-oem-6.11'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: kernel-spammed-noble-linux-oem-6.11-v2 verification-needed-noble-linux-oem-6.11
Revision history for this message
AaronMa (mapengyu) wrote :

Tested on 6.11.0-1010-oem

$ uname -a
Linux Thames2-2 6.11.0-1010-oem #10-Ubuntu SMP PREEMPT_DYNAMIC Mon Dec 9 08:36:13 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

$ speaker-test -c 2

$ arecord -f cd a.wav

The speaker output is good.
The mic recording is good too.

Revision history for this message
AaronMa (mapengyu) wrote :

Dec 11 11:08:09 Thames2-2 kernel: sof-audio-pci-intel-lnl 0000:00:1f.3: DMICs detected in NHLT tables: 2
Dec 11 11:08:09 Thames2-2 kernel: sof-audio-pci-intel-lnl 0000:00:1f.3: hda codecs found, mask 4
Dec 11 11:08:09 Thames2-2 kernel: sof-audio-pci-intel-lnl 0000:00:1f.3: Firmware paths/files for ipc type 1:
Dec 11 11:08:09 Thames2-2 kernel: sof-audio-pci-intel-lnl 0000:00:1f.3: Firmware file: intel/sof-ipc4/lnl/sof-lnl.ri
Dec 11 11:08:09 Thames2-2 kernel: sof-audio-pci-intel-lnl 0000:00:1f.3: Firmware lib path: intel/sof-ipc4-lib/lnl
Dec 11 11:08:09 Thames2-2 kernel: sof-audio-pci-intel-lnl 0000:00:1f.3: Topology file: intel/sof-ipc4-tplg/sof-lnl-rt713-l0-rt1318-l1-2ch.tplg

tags: added: verification-done-noble-linux-oem-6.11
removed: verification-needed-noble-linux-oem-6.11
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (6.8 KiB)

This bug was fixed in the package linux-oem-6.11 - 6.11.0-1010.10

---------------
linux-oem-6.11 (6.11.0-1010.10) noble; urgency=medium

  * noble/linux-oem-6.11: 6.11.0-1010.10 -proposed tracker (LP: #2090462)

  * DSC through MST for Intel and AMD platforms (LP: #2090898)
    - drm/i915/dp_mst: Handle error during DSC BW overhead/slice calculation
    - drm/i915/dp_mst: Don't require DSC hblank quirk for a non-DSC compatible
      mode
    - drm/i915/dp: Flush modeset commits during connector detection
    - drm/i915/ptl/dp_mst: Fix slave transcoder enabling wrt. DDI function
    - drm/i915/adlp+/dp_mst: Align slave transcoder enabling with spec wrt. DDI
      function
    - drm/dp_mst: Factor out function to queue a topology probe work
    - drm/dp_mst: Add a helper to queue a topology probe
    - drm/dp_mst: Simplify the condition when to enumerate path resources
    - drm/i915/ddi: For an active output call the DP encoder sync_state() only for
      DP
    - drm/i915/dp: Initialize the link parameters during HW readout
    - drm/i915/dp: Send only a single modeset-retry uevent for a commit
    - drm/i915/dp: Add a separate function to reduce the link parameters
    - drm/i915/dp: Add helpers to set link training mode, BW parameters
    - drm/i915/dp_mst: Reduce the link parameters in BW order after LT failures
    - drm/i915/dp_mst: Configure MST after the link parameters are reset
    - drm/i915/dp_mst: Queue modeset-retry after a failed payload BW allocation
    - drm/i915/dp_mst: Reprobe the MST topology after a link parameter change
    - drm/i915/dp_mst: Ensure link parameters are up-to-date for a disabled link
    - drm/i915/dp_mst: Enable LT fallback between UHBR/non-UHBR link rates
    - drm/amd/display: Fix Synaptics Cascaded Panamera DSC Determination
    - drm/amd/display: Add DSC Debug Log
    - drm/amdgpu/display: Fix a mistake in revert commit
    - drm/amd/display: Add HDMI DSC native YCbCr422 support
    - drm/amd/display: free bo used for dmub bounding box
    - drm/amd/display: Check null pointers before using them
    - drm/amd/display: Add null check for 'afb' in amdgpu_dm_update_cursor (v2)
    - drm/amd/display: Check stream_status before it is used
    - drm/amd/display: Check stream before comparing them
    - drm/amd/display: Check phantom_stream before it is used
    - drm/amd/display: Check null-initialized variables
    - drm/amd/display: Initialize denominators' default to 1
    - drm/amd/display: Check null pointers before using dc->clk_mgr
    - drm/amd/display: Check link_res->hpo_dp_link_enc before using it
    - drm/amd/display: Check link_res->hpo_dp_link_enc before using it
    - drm/amd/display: Pass non-null to dcn20_validate_apply_pipe_split_flags
    - drm/amd/display: Check null pointers before used
    - drm/amd/display: Check null pointers before multiple uses
    - drm/amd/display: Add null check for head_pipe in
      dcn201_acquire_free_pipe_for_layer
    - drm/amd/display: Add null check for head_pipe in
      dcn32_acquire_idle_pipe_for_head_pipe_in_layer
    - drm/amd/display: Add NULL check for clk_mgr and clk_mgr->funcs in
      dcn30_init_hw
    - drm/amd/display: Add NULL check for cl...

Read more...

Changed in linux-oem-6.11 (Ubuntu Noble):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package firmware-sof - 2024.06-1ubuntu3

---------------
firmware-sof (2024.06-1ubuntu3) plucky; urgency=medium

  * Add missing sof firmware for Dell GhostRider platform. (LP: #2086250)
    - Add missing links for SOF v2.11.1 signed Intel binaries
    - Add new 2.11.2 topology2 production binaries
  * Add missing tplg file for Dell Tarako RPL platform. (LP: #2089885)
    - Update v2.2.12 topology files for Intel RPL platform
  * Add audio rt713 and rt718 support on ThinkPad TM2. (LP: #2089891)
    - Add new 2.11.3 topology2 production binaries

 -- Chris Chiu <email address hidden> Fri, 06 Dec 2024 20:40:55 +0800

Changed in firmware-sof (Ubuntu):
status: New → Fix Released
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello AaronMa, or anyone else affected,

Accepted firmware-sof into oracular-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/firmware-sof/2024.06-1ubuntu1.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-oracular to verification-done-oracular. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-oracular. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in firmware-sof (Ubuntu Oracular):
status: New → Fix Committed
tags: added: verification-needed verification-needed-oracular
Changed in firmware-sof (Ubuntu Noble):
status: New → Fix Committed
tags: added: verification-needed-noble
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

Hello AaronMa, or anyone else affected,

Accepted firmware-sof into noble-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/firmware-sof/2023.12.1-1ubuntu1.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-noble to verification-done-noble. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-noble. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

AaronMa (mapengyu)
tags: added: verification-done verification-done-noble verification-done-oracular
removed: verification-needed verification-needed-noble verification-needed-oracular
Timo Aaltonen (tjaalton)
Changed in linux-oem-6.11 (Ubuntu):
status: In Progress → Invalid
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Update Released

The verification of the Stable Release Update for firmware-sof has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package firmware-sof - 2023.12.1-1ubuntu1.3

---------------
firmware-sof (2023.12.1-1ubuntu1.3) noble; urgency=medium

  * Add missing sof firmware for Dell GhostRider platform. (LP: #2086250)
    - Add missing links for SOF v2.11.1 signed Intel binaries
    - Add new 2.11.2 topology2 production binaries
  * Add missing tplg file for Dell Tarako RPL platform. (LP: #2089885)
    - Update v2.2.12 topology files for Intel RPL platform
  * Add audio rt713 and rt718 support on ThinkPad TM2. (LP: #2089891)
    - Add new 2.11.3 topology2 production binaries

 -- Chris Chiu <email address hidden> Tue, 03 Dec 2024 16:32:47 +0800

Changed in firmware-sof (Ubuntu Noble):
status: Fix Committed → Fix Released
Revision history for this message
Chris Halse Rogers (raof) wrote :

Could you please document the testing (particularly: the versions tested) done to verify this update? As the acceptance comment says:

"If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-oracular to verification-done-oracular"

Revision history for this message
Timo Aaltonen (tjaalton) wrote :

thanks Chris, I did actually release this for oracular too, but LP oopsed when copying...

the other bugs were properly verified, and I missed that this one was not :/

Revision history for this message
AaronMa (mapengyu) wrote :

Tested on 6.11.0-1011-oem.

firmware-sof:
2023.12.1-1ubuntu1.3

$ speaker-test -c 2

$ arecord -f cd a.wav

The speaker output is good.
The mic recording is good too.

Revision history for this message
AaronMa (mapengyu) wrote :

Installed firmware-sof-signed 2024.06-1ubuntu1.2.

Tested as above, the speaker and mic works too.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package firmware-sof - 2024.06-1ubuntu1.2

---------------
firmware-sof (2024.06-1ubuntu1.2) oracular; urgency=medium

  * Add missing sof firmware for Dell GhostRider platform. (LP: #2086250)
    - Add missing links for SOF v2.11.1 signed Intel binaries
    - Add new 2.11.2 topology2 production binaries
  * Add missing tplg file for Dell Tarako RPL platform. (LP: #2089885)
    - Update v2.2.12 topology files for Intel RPL platform
  * Add audio rt713 and rt718 support on ThinkPad TM2. (LP: #2089891)
    - Add new 2.11.3 topology2 production binaries

 -- Chris Chiu <email address hidden> Fri, 06 Dec 2024 20:34:21 +0800

Changed in firmware-sof (Ubuntu Oracular):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.