OneTime alarms are not automatically dismissed or delete after they are triggered
Bug #1362341 reported by
Nekhelesh Ramananthan
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical System Image |
Fix Released
|
High
|
Unassigned | ||
| Indicator Date and Time |
Fix Released
|
High
|
Charles Kerr | ||
| Ubuntu Clock App |
Fix Released
|
High
|
Nekhelesh Ramananthan | ||
| indicator-datetime (Ubuntu) |
Fix Released
|
High
|
Charles Kerr | ||
| indicator-datetime (Ubuntu RTM) |
Fix Released
|
Undecided
|
Unassigned | ||
| ubuntu-clock-app (Ubuntu) |
Fix Released
|
Undecided
|
Nekhelesh Ramananthan | ||
Bug Description
Steps to reproduce:
1. Create a one time alarm to ring in a few minutes
2. Let the alarm ring
3. Dismiss the alarm
What happens:
The OneTime alarm is still shown as enabled and as a result shows the wrong status in the clock app. The alarm is no longer shown in the indicator-datetime.
What should happen:
The OneTime alarm is either disabled or deleted from the alarm model.
The clock app cannot disable the alarm since most likely the clock app is not even open at the time the alarm is triggered. Since the alarm is no longer shown in the indicator-datetime, my intuition tells me that indicator-datetime and EDS did its job. Its now up to the SDK Alarms API to update the alarm model correctly.
Related branches
lp://qastaging/~charlesk/indicator-datetime/lp-1362341-disable-one-time-ubuntu-alarms-after-notification
- Ted Gould (community): Approve
-
Diff: 196 lines (+105/-5)6 files modifiedinclude/datetime/engine-eds.h (+3/-2)
include/datetime/engine-mock.h (+5/-2)
include/datetime/engine.h (+1/-0)
src/engine-eds.cpp (+82/-0)
src/main.cpp (+4/-1)
tests/manual (+10/-0)
- Ted Gould (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 196 lines (+105/-5)6 files modifiedinclude/datetime/engine-eds.h (+3/-2)
include/datetime/engine-mock.h (+5/-2)
include/datetime/engine.h (+1/-0)
src/engine-eds.cpp (+82/-0)
src/main.cpp (+4/-1)
tests/manual (+10/-0)
lp://qastaging/~nik90/ubuntu-clock-app/3-fix-alarm-refresh-ui
- Riccardo Padovani: Approve
- Alan Pope 🍺🐧🐱 🦄 (community): Approve
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
-
Diff: 130 lines (+65/-0)5 files modifiedapp/clock/ClockPage.qml (+3/-0)
app/clock/MainClock.qml (+5/-0)
app/ubuntu-clock-app.qml (+8/-0)
debian/changelog (+1/-0)
tests/manual/2014.com.ubuntu.clock:clock-tests/jobs/alarms.pxu (+48/-0)
| tags: | added: rtm14 |
| description: | updated |
Revision history for this message
| Zsombor Egri (zsombi) wrote | #1 |
| Changed in ubuntu-ui-toolkit: | |
| status: | New → Invalid |
| no longer affects: | ubuntu-ui-toolkit |
| Changed in indicator-datetime: | |
| status: | New → Confirmed |
| Changed in indicator-datetime: | |
| assignee: | nobody → Charles Kerr (charlesk) |
| tags: | added: touch-2014-09-25 |
| Changed in indicator-datetime: | |
| importance: | Undecided → High |
| tags: |
added: touch-2014-10-09 removed: touch-2014-09-25 |
| tags: |
added: touch-2014-10-16 removed: touch-2014-10-09 |
| Changed in indicator-datetime: | |
| status: | Confirmed → In Progress |
| Changed in indicator-datetime (Ubuntu): | |
| assignee: | nobody → Charles Kerr (charlesk) |
| importance: | Undecided → High |
| status: | New → In Progress |
Revision history for this message
| Pat McGowan (pat-mcgowan) wrote | #2 |
| Changed in canonical-devices-system-image: | |
| importance: | Undecided → High |
| milestone: | none → ww51-2014 |
| status: | New → Confirmed |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #3 |
| Changed in indicator-datetime (Ubuntu): | |
| status: | In Progress → Fix Released |
Revision history for this message
| Charles Kerr (charlesk) wrote | #4 |
| Changed in ubuntu-clock-app (Ubuntu): | |
| assignee: | nobody → Nekhelesh Ramananthan (nik90) |
| Changed in ubuntu-clock-app: | |
| assignee: | nobody → Nekhelesh Ramananthan (nik90) |
| importance: | Undecided → High |
| status: | New → Confirmed |
| milestone: | none → ota-1 |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #5 |
| Changed in indicator-datetime (Ubuntu RTM): | |
| status: | New → Fix Released |
| Changed in canonical-devices-system-image: | |
| milestone: | ww51-2014 → ww03-2015 |
| Changed in indicator-datetime: | |
| status: | In Progress → Fix Released |
| Changed in canonical-devices-system-image: | |
| status: | Confirmed → Fix Released |
| Changed in ubuntu-clock-app: | |
| status: | Confirmed → In Progress |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #6 |
| Changed in ubuntu-clock-app: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntu-clock-app: | |
| status: | Fix Committed → Fix Released |
| Changed in ubuntu-clock-app (Ubuntu): | |
| status: | New → Fix Released |
To post a comment you must log in.
Alarm enabled state is built up based on Audible and Visual reminders. The Enabled state is never saved. On the other hand, alarm service is not running if the Clock app doesn't run, so it cannot do anything with the alarm.
And finally, a dismissed alarm should be only disabled, not removed.