Indicator Date and Time

valgrind invalid read

Bug #729175 reported by Sebastien Bacher on 2011-03-04

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Indicator Date and Time	Fix Released	High	Karl Lattimer	Indicator Date and Time 0.1.98
Unity Foundations	Fix Released	High	Karl Lattimer	Unity Foundations unity-3.6.6 "2011-03-17"
indicator-datetime (Ubuntu)	Fix Released	High	Karl Lattimer
Natty	Fix Released	High	Karl Lattimer

Bug Description

Binary package hint: indicator-datetime

Using 0.1.96 in natty:

"==28765== Invalid read of size 4
==28765== at 0x804BCA4: update_appointment_menu_items (datetime-service.c:809)
==28765== by 0x804BDFA: start_ecal_timer (datetime-service.c:296)
==28765== by 0x804C256: check_for_calendar (datetime-service.c:360)
==28765== by 0x4865450: g_idle_dispatch (gmain.c:4537)
==28765== by 0x4869C07: g_main_context_dispatch (gmain.c:2440)
==28765== by 0x486A3CF: g_main_context_iterate.clone.5 (gmain.c:3091)
==28765== by 0x486AA92: g_main_loop_run (gmain.c:3299)
==28765== by 0x804DBB5: main (datetime-service.c:1211)
==28765== Address 0x580f504 is 4 bytes inside a block of size 12 free'd
==28765== at 0x40259E0: free (vg_replace_malloc.c:366)
==28765== by 0x4870DE5: g_free (gmem.c:263)
==28765== by 0x48893D0: g_slice_free_chain_with_offset (gslice.c:983)
==28765== by 0x4864ACC: g_list_free (glist.c:182)
==28765== by 0x804BCA3: update_appointment_menu_items (datetime-service.c:812)
==28765== by 0x804BDFA: start_ecal_timer (datetime-service.c:296)
==28765== by 0x804C256: check_for_calendar (datetime-service.c:360)
==28765== by 0x4865450: g_idle_dispatch (gmain.c:4537)
==28765== by 0x4869C07: g_main_context_dispatch (gmain.c:2440)
==28765== by 0x486A3CF: g_main_context_iterate.clone.5 (gmain.c:3091)
==28765== by 0x486AA92: g_main_loop_run (gmain.c:3299)
==28765== by 0x804DBB5: main (datetime-service.c:1211)"

Related branches

lp://qastaging/~karl-qdh/indicator-datetime/calendarmenuitemsignals

Merged into lp://qastaging/indicator-datetime/0.3 at revision 66

Ted Gould (community): Approve on 2011-03-16

lp://qastaging/~indicator-applet-developers/indicator-datetime/ubuntu

Merged into lp://qastaging/~ubuntu-desktop/indicator-datetime/ubuntu at revision 127

Ken VanDine: Pending requested 2011-10-13

lp://qastaging/ubuntu/natty/indicator-datetime

Revision history for this message

Sebastien Bacher (seb128) wrote on 2011-03-04:

The warnings are displayed when just running the indicator without opening the menu or interacting with it

Changed in indicator-datetime (Ubuntu):
assignee:	nobody → Karl Lattimer (karl-qdh)
importance:	Undecided → High
status:	New → Triaged

Revision history for this message

Sebastien Bacher (seb128) wrote on 2011-03-04:

There is quite some warnings about

"==28765== Conditional jump or move depends on uninitialised value(s)
==28765== at 0x804BB08: update_appointment_menu_items (datetime-service.c:765)
==28765== by 0x486B52B: g_timeout_dispatch (gmain.c:3878)
==28765== by 0x4869C07: g_main_context_dispatch (gmain.c:2440)
==28765== by 0x486A3CF: g_main_context_iterate.clone.5 (gmain.c:3091)
==28765== by 0x486AA92: g_main_loop_run (gmain.c:3299)
==28765== by 0x804DBB5: main (datetime-service.c:1211)"

in different lines of update_appointment_menu_items() as well

Changed in indicator-datetime:
status:	New → Confirmed

David Barth (dbarth) on 2011-03-07

Changed in indicator-datetime:
assignee:	nobody → Karl Lattimer (karl-qdh)
importance:	Undecided → High
Changed in ayatana-ubuntu:
assignee:	nobody → Karl Lattimer (karl-qdh)
importance:	Undecided → High
milestone:	none → ubuntu-11.04-beta
status:	New → Confirmed

Revision history for this message

Sebastien Bacher (seb128) wrote on 2011-03-07:

the crash on bug #729444 seems to match that valgrind log

David Barth (dbarth) on 2011-03-09

affects:	ayatana-ubuntu → unity-foundations
Changed in unity-foundations:
milestone:	ubuntu-11.04-beta → none
milestone:	none → ubuntu-11.04-beta-1

David Barth (dbarth) on 2011-03-14

Changed in unity-foundations:
milestone:	unity-3.8.0-beta → unity-3.6.6

Revision history for this message

Karl Lattimer (karl-qdh) wrote on 2011-03-16:

The related branch should fix this.

I would appreciate a second tester, my valgrinding shows it's gone now.

Ted Gould (ted) on 2011-03-16

Changed in indicator-datetime:
milestone:	none → 0.1.98
status:	Confirmed → Fix Released
Changed in unity-foundations:
status:	Confirmed → Fix Released

Revision history for this message

Launchpad Janitor (janitor) wrote on 2011-03-16:

This bug was fixed in the package indicator-datetime - 0.1.98-0ubuntu1

---------------
indicator-datetime (0.1.98-0ubuntu1) natty; urgency=low

  * New upstream release.
    ∘ Make appointments match calendar month
    ∘ Fix time format of appointments
    ∘ Get date change signals from calendar and adjust based on them.
    ∘ Crash fixes (LP: #733833, LP: #729444)
    ∘ Valgrind invalid read (LP: #729175)
    ∘ Translation fixes to date label (LP: #729632)
    * Fix handling of reoccruing events
    * Handle settings in the indicator
    * Allow for hiding the calendar and the clock
-- Ted Gould <email address hidden> Wed, 16 Mar 2011 16:17:38 -0500

Changed in indicator-datetime (Ubuntu Natty):
status:	Triaged → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.