[TOPBLOCKER] switch-items in indicators sometimes get out of sync with system-settings

Bug #1336715 reported by Antti Kaijanmäki
40
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Indicator Display
Invalid
Critical
Charles Kerr
Indicator Location
Invalid
Critical
Charles Kerr
Network Menu
Invalid
Critical
Antti Kaijanmäki
The Sound Menu
Invalid
Critical
Ted Gould
ubuntu-system-settings (Ubuntu)
Fix Released
Critical
Nick Dedekind
ubuntu-system-settings (Ubuntu RTM)
Fix Released
Critical
Ken VanDine
unity8 (Ubuntu)
Fix Released
Critical
Nick Dedekind
unity8 (Ubuntu RTM)
Fix Released
Critical
Michał Sawicz

Bug Description

I noticed when testing flightmode with indicator-network that the switch items sometimes get out of sync from what GActions states on dbus are and stop updating their states when action states on dbus change.

This seems to happen randomly and I have no procedure to reproduce reliably.

Related branches

Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

Picture of the problem:

GAction states on dbus were like this:

         string "airplane.enabled"
         struct {
            boolean true
            signature ""
            array [
               variant boolean true
            ]
         }
      )

         string "wifi.enable"
         struct {
            boolean true
            signature ""
            array [
               variant boolean false
            ]
         }
      )

And the indicator is showing exactly the opposite.

Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

might also be related to indicator-network.

Changed in indicator-network:
status: New → Confirmed
Changed in unity8:
status: New → Confirmed
Changed in indicator-network:
assignee: nobody → Antti Kaijanmäki (kaijanmaki)
Changed in unity8:
assignee: nobody → Antti Kaijanmäki (kaijanmaki)
Changed in indicator-network:
importance: Undecided → Critical
Changed in unity8:
importance: Undecided → Critical
Revision history for this message
Charles Kerr (charlesk) wrote :

Added indicator-location to this ticket because I'm seeing similar results with the sync between u-s-s's GPS toggle and indicator-location's GPS toggle.

Changed in unity8:
assignee: Antti Kaijanmäki (kaijanmaki) → nobody
Changed in indicator-location:
importance: Undecided → Critical
Revision history for this message
Michał Sawicz (saviq) wrote :

Have we seen this recently? On unity8 side we fixed the clock-out-of-sync which could have been related.

Changed in unity8:
status: Confirmed → Incomplete
Michał Sawicz (saviq)
Changed in unity8 (Ubuntu):
importance: Undecided → Critical
status: New → Incomplete
Changed in unity8 (Ubuntu):
status: Incomplete → New
kevin gunn (kgunn72)
summary: - switch-items in indicators sometimes get out of sync
+ switch-items in indicators sometimes get out of sync with system-
+ settings
Michał Sawicz (saviq)
no longer affects: unity8
Revision history for this message
Launchpad Janitor (janitor) wrote : Re: switch-items in indicators sometimes get out of sync with system-settings

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in unity8 (Ubuntu):
status: New → Confirmed
Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

There was a verified case of this happening today on an rtm image.

Changed in unity8 (Ubuntu):
assignee: nobody → Michał Sawicz (saviq)
tags: added: rtm
tags: added: rtm14
removed: rtm
Michał Sawicz (saviq)
Changed in unity8 (Ubuntu):
assignee: Michał Sawicz (saviq) → Nick Dedekind (nick-dedekind)
Thomas Strehl (strehl-t)
tags: added: touch-2014-09-25
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

This is caused by bindings in the indicator menu system being broken by user input.
Affects switch menus, access points & checkable menus.

Changed in unity8 (Ubuntu):
status: Confirmed → In Progress
kevin gunn (kgunn72)
Changed in indicator-location:
status: New → Opinion
Changed in indicator-network:
status: Confirmed → Opinion
Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

This still needs investigation on the indicator-service side to verify the root cause and how to mitigate it.

Changed in indicator-location:
status: Opinion → Triaged
Changed in indicator-network:
status: Opinion → Triaged
Changed in indicator-location:
assignee: nobody → Charles Kerr (charlesk)
status: Triaged → Incomplete
Changed in indicator-network:
status: Triaged → Incomplete
kevin gunn (kgunn72)
tags: added: touch-2014-10-09
removed: touch-2014-09-25
Revision history for this message
Ted Gould (ted) wrote :

Going to leave Nick assigned this bug as it seems he has a fix. Didn't know that when I asked Lars to help out with it, but if that fix works we're probably all good there.

Changed in unity8 (Ubuntu):
assignee: Nick Dedekind (nick-dedekind) → Lars Uebernickel (larsu)
assignee: Lars Uebernickel (larsu) → Nick Dedekind (nick-dedekind)
Revision history for this message
kevin gunn (kgunn72) wrote :

just a brief update, it's been determined that there are actually 2 separate issues
the first problem needs the checkable-bindings branch, which is attached, so we should be landing that soon
the second issue is on the unity8 side and is actively being worked, so we are planning on keeping this bug open until we get a solution.

Thomas Strehl (strehl-t)
Changed in indicator-location:
status: Incomplete → Invalid
Changed in indicator-network:
status: Incomplete → Invalid
Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

kevin: if the final solution changes the semantics how the switch-items behave regarding to GActions, then please reopen this bug for i-network and i-location so that we can update the code.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity8 - 8.00+14.10.20141009.4-0ubuntu1

---------------
unity8 (8.00+14.10.20141009.4-0ubuntu1) utopic; urgency=low

  [ Michał Sawicz ]
  * Rename datetime indicator in test

  [ Albert Astals ]
  * Close overview temp scope on show dash (LP: #1373819)
  * Enable QT_STRICT_ITERATORS
  * Make Base not clickable, since we don't use it in anywhere clickable
    (we only use it for Category delegates in the LVWPH) (LP: #1300709)
  * Hide preview if it was visible when going to a scope (LP: #1374548)
  * Remove contentScale variable

  [ Andrea Cimitan ]
  * Fix card implicitHeight when summary is declared, but its text is
    empty. Also fixes vertical journal height and clipping (LP:
    #1362160)
  * Redesign for pinned apps. Remove thindivider on top of ubuntu dash
    button (not needed anymore) (LP: #1377100)

  [ Ying-Chun Liu ]
  * Fix run_on_device.sh to let it run again.

  [ Nick Dedekind ]
  * Fixed indicator menu bindings to server toggle value broken by user
    interaction. (LP: #1336715)
  * Force rendering so we don't get stuck in "waitForRendering" loop in
    tests.

  [ Daniel d'Andrada ]
  * PhoneStage: focus the new topmost app after the current one closes
    itself (LP: #1375267)

  [ Michael Terry ]
  * Fix some security issues with the tablet greeter, which allowed the
    lockscreen to be bypassed. (LP: #1367715) (LP: #1367715)

  [ Michael Zanetti ]
  * scale down errorText label if necessary (LP: #1378848)
 -- Ubuntu daily release <email address hidden> Thu, 09 Oct 2014 14:05:54 +0000

Changed in unity8 (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Charles Kerr (charlesk) wrote :

Adding indicator-sound and indicator-transfer to the list of indicators that display this behavior:

indicator-sound's "Silent Mode" toggle

indicator-display's "Rotation Lock" toggle

Changed in indicator-display:
status: New → Invalid
Changed in indicator-sound:
status: New → Invalid
Changed in indicator-display:
assignee: nobody → Charles Kerr (charlesk)
importance: Undecided → Critical
Changed in indicator-sound:
importance: Undecided → Critical
assignee: nobody → Ted Gould (ted)
kevin gunn (kgunn72)
tags: added: touch-2014-10-23
removed: touch-2014-10-09
Revision history for this message
Charles Kerr (charlesk) wrote :

This bug still exists. For example, I'm always able to trigger it with the steps listed in <https://code.launchpad.net/~nick-dedekind/unity8/lp1336715-checkable-bindings/+merge/234503/comments/582588>

Tested on mako + RTM r102

Changed in unity8 (Ubuntu):
status: Fix Released → Confirmed
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

Looks like it's system settings out of sync now.

dbus-send --session --dest=com.canonical.indicator.location --print-reply /com/canonical/indicator/location org.gtk.Actions.DescribeAll

shows the indicator as being in the correct state.

Revision history for this message
Selene ToyKeeper (toykeeper) wrote :

This is what happens when enabling silent mode via the sound indicator. Ubuntu-system-settings then gets out of sync with itself, claiming silent mode is simultaneously both active and not.

Changed in ubuntu-system-settings (Ubuntu):
assignee: nobody → Nick Dedekind (nick-dedekind)
kevin gunn (kgunn72)
tags: added: touch-2014-10-30
removed: touch-2014-10-23
kevin gunn (kgunn72)
Changed in unity8 (Ubuntu RTM):
importance: Undecided → Critical
status: New → In Progress
assignee: nobody → Nick Dedekind (nick-dedekind)
summary: - switch-items in indicators sometimes get out of sync with system-
- settings
+ [TOPBLOCKER] switch-items in indicators sometimes get out of sync with
+ system-settings
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

Believe the problem is fixed in indicators now.
The same binding bugs exist in the system settings now. I've added some generic components for switches/checkboxes to ubuntu-settings-components and a branch for ubuntu-system-settings to use them.

Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

Test Case:
1) In USS languages page; set "Spell checking" to true then false.
2) phablet$ dconf write /com/canonical/keyboard/maliit/spell-checking true

Expected outcome: UI should update "Spell checking" value to true
Actual outcome: UI still displays false until page is closed and re-opened.

Changed in ubuntu-system-settings (Ubuntu):
status: New → In Progress
Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

marking to keep in tracking sheet

Changed in ubuntu-system-settings (Ubuntu RTM):
status: New → In Progress
importance: Undecided → Critical
assignee: nobody → Nick Dedekind (nick-dedekind)
Changed in ubuntu-system-settings (Ubuntu):
importance: Undecided → High
Changed in unity8 (Ubuntu):
importance: Critical → High
Olli Ries (ories)
tags: added: touch-2014-11-06
removed: touch-2014-10-30
Michał Sawicz (saviq)
Changed in unity8 (Ubuntu):
status: Confirmed → In Progress
Changed in unity8 (Ubuntu RTM):
assignee: Nick Dedekind (nick-dedekind) → Michał Sawicz (saviq)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity8 - 8.01+15.04.20141104-0ubuntu1

---------------
unity8 (8.01+15.04.20141104-0ubuntu1) vivid; urgency=low

  [ Sebastien Bacher ]
  * Drop workaround, it's not needed and create issues for desktop-next
    (LP: #1387671)

  [ Albert Astals ]
  * Do not append integer to char *
  * Remove unused end() function
  * Update build.sh
  * Fix i18n

  [ Michael Zanetti ]
  * rework launcher quicklist visuals to fit new design (LP: #1368660)
  * Fix DBusVariant conversion for launcher emblems (LP: #1387261)
  * Fix desktop file encoding in launcher (LP: #1387083)
  * Add a hinting animation to indicate changes in the backend (LP:
    #1376707)

  [ Alberto Aguirre ]
  * Add audioRole to QtMultimedia mock
  * Add a plugin to take screenshots on vol up + vol down

  [ CI bot ]
  * Fix relative time formatter when using non-UTC timezone. (LP:
    #1378821)

  [ Leo Arias ]
  * Removed the tests for the alternate paths of the autopilot helpers.

  [ Nick Dedekind ]
  * Fix relative time formatter when using non-UTC timezone. (LP:
    #1378821)
  * Reset current item selection on deleted. (LP: #1378462)
  * Added timer to re-assert server value after indicator menu item
    activation. (LP: #1336715)

  [ Mirco Müller ]
  * Added dedicated swipe-to-act button for snap-decisions, which avoids
    accidental taps/button-presses. (LP: #1358343)

  [ Chris Gagnon ]
  * add missing unity-scope-click dependancy to unity8-autopilot package
    (LP: #1336276)

  [ Michael Terry ]
  * Don't lock phone if user tries to switch back to an active call.
    (LP: #1388156)

  [ Daniel d'Andrada ]
  * DirectionalDragArea: Update TODO comment in light of new events
  * TouchDispatcher: synthesize MouseButtonDblClick events

  [ Leonardo Arias Fonseca ]
  * Removed the tests for the alternate paths of the autopilot helpers.
 -- Ubuntu daily release <email address hidden> Tue, 04 Nov 2014 12:56:08 +0000

Changed in unity8 (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
kevin gunn (kgunn72) wrote :

adding ubuntu-ux

because the user's input toggle for airplane mode is both a reflection of user intent & the state of the backend....and the backend is unfortunately variable & lengthy to change (anywhere from 1 to ~10+ seconds sometimes) we need to have an intermediate/transition state....e.g. toggle to airplane mode on....replace toggle with spinner-balls or gray out blanks like [ - | - ]...until backend either succeeds or fails(timesout)

Olli Ries (ories)
Changed in ubuntu-system-settings (Ubuntu):
importance: High → Critical
Changed in unity8 (Ubuntu):
importance: High → Critical
Revision history for this message
Paty Davila (dizzypaty) wrote :

Between the user’s action of toggling the airplane switcher on and/or off and the backend updating the state, the indicator icon displayed on the statusbar should be the following: network-idle.svg
(https://drive.google.com/drive/#folders/0BzbnWoHmYF3aZTA4WHNPYW1jeUE/0BzbnWoHmYF3aS2pVejVicktrdm8/0BzbnWoHmYF3ablBITVByRnpzdEk).

Revision history for this message
kevin gunn (kgunn72) wrote :

we're gonna close this bug out since we've addressed the sync issue, however opening a new bug for getting a better ux/visual response related to comment #21, bug 1390136 will be used to continue the design topic

no longer affects: ubuntu-ux
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity8 - 8.01.1+14.10.20141105.2~rtm-0ubuntu1

---------------
unity8 (8.01.1+14.10.20141105.2~rtm-0ubuntu1) 14.09; urgency=medium

  [ Albert Astals ]
  * Fix i18n (LP: #1389165)

  [ Michael Zanetti ]
  * Fix DBusVariant conversion for launcher emblems (LP: #1387261)
  * Fix desktop file encoding in launcher (LP: #1387083)

  [ Alberto Aguirre ]
  * Add audioRole to QtMultimedia mock
  * Add a plugin to take screenshots on vol up + vol down

  [ Nick Dedekind ]
  * Reset current item selection on deleted. (LP: #1378462)
  * Added timer to re-assert server value after indicator menu item
    activation. (LP: #1336715)

  [ Mirco Müller ]
  * Added dedicated swipe-to-act button for snap-decisions, which avoids
    accidental taps/button-presses. (LP: #1358343)

  [ Michael Terry ]
  * Don't lock phone if user tries to switch back to an active call.
    (LP: #1388156)

  [ Daniel d'Andrada ]
  * TouchDispatcher: synthesize MouseButtonDblClick events (LP:
    #1388359)

  [ Michał Sawicz ]
  * Bump the version above the version synced from vivid, otherwise
    train will generate a lower-than-archive version number.
  * fix positive/negative answer order on the new swipe notification

  [ Ubuntu daily release ]
  * New rebuild forced

unity8 (8.01+15.04.20141030-0ubuntu1) vivid; urgency=medium

  [ Michael Terry ]
  * Provide 'passphrase' as a field of Components.Lockscreen
  * Fix a race between Qml loading and DBus registration that caused
    problems when jenkins tried to unlock the phone.
  * Set domain explicitly for the Dialogs component because the welcome
    wizard wants to import it. (LP: #1381731)
  * When greeter or lockscreen has focus, show active call panel. (LP:
    #1378872)

  [ Ted Gould ]
  * Set the default OOM score for the dash (LP: #1379786)

  [ Michał Sawicz ]
  * Revert lp:~unity-team/unity8/flickables-speed-workaround to avoid
    risk in RTM.
  * Updated behaviour for zoomable image, workaround for sourcesize (LP:
    #1333187)

  [ Michael Frey ]
  * Added a check for Proximity to determine if we show the lock screen.
    (LP: #1378012)

  [ Ying-Chun Liu ]
  * Add non-interactive code into GenericScopeView. (LP: #1384441)

  [ Mirco Müller ]
  * Also use modal nature of snap-decision notifications when
    greeter/lockscreen is shown. This fixes LP: #1378827. (LP: #1378827)

  [ Michael Zanetti ]
  * Make the launcher update on dconf changes (LP: #1376707)
  * exit spread on background tap (LP: #1368261)
  * Use an index instead of a scope id in DashCommunicator (LP:
    #1376044)

  [ Andrea Cimitan ]
  * Updated behaviour for zoomable image, workaround for sourcesize (LP:
    #1333187)

  [ Daniel d'Andrada ]
  * Make TouchGate synthesize QMouseEvents for mouse-based target items
  * Don't specify a distanceThreshold as it conflicts with
    hintDisplacment
 -- Ubuntu daily release <email address hidden> Wed, 05 Nov 2014 14:39:41 +0000

Changed in unity8 (Ubuntu RTM):
status: In Progress → Fix Released
kevin gunn (kgunn72)
Changed in ubuntu-system-settings (Ubuntu):
status: In Progress → Fix Released
Changed in ubuntu-system-settings (Ubuntu RTM):
status: In Progress → Fix Released
status: Fix Released → In Progress
Changed in ubuntu-system-settings (Ubuntu):
status: Fix Released → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-system-settings - 0.3+15.04.20141105.1-0ubuntu1

---------------
ubuntu-system-settings (0.3+15.04.20141105.1-0ubuntu1) vivid; urgency=low

  [ Ubuntu daily release ]
  * New rebuild forced

  [ Kevin Gunn ]
  * fix white space issues

  [ Nick Dedekind ]
  * Fixed switches & check-boxes going out of sync with backends. (LP:
    #1336715)
 -- Ubuntu daily release <email address hidden> Wed, 05 Nov 2014 20:32:26 +0000

Changed in ubuntu-system-settings (Ubuntu):
status: In Progress → Fix Released
Michał Sawicz (saviq)
Changed in ubuntu-system-settings (Ubuntu RTM):
assignee: Nick Dedekind (nick-dedekind) → Michał Sawicz (saviq)
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

Just had this issue with the silent mode switch: http://people.canonical.com/~rsalveti/silent.png

Michał Sawicz (saviq)
Changed in ubuntu-system-settings (Ubuntu RTM):
assignee: Michał Sawicz (saviq) → Ken VanDine (ken-vandine)
Revision history for this message
Victor Tuson Palau (vtuson) wrote :
tags: added: lt-blocker lt-category-visible
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-system-settings - 0.3+15.04.20141112.1~rtm-0ubuntu1

---------------
ubuntu-system-settings (0.3+15.04.20141112.1~rtm-0ubuntu1) 14.09; urgency=low

  [ Ken VanDine ]
  * Backport fix for Switch/Check binding (LP: #1336715) (LP: #1336715)

  [ Sebastien Bacher ]
  * Tweaks to try to make the section headers and titles closer to the
    design. Use a custom component, with tweaked margins and disabled
    tap effects, for that.
 -- Ubuntu daily release <email address hidden> Wed, 12 Nov 2014 16:28:25 +0000

Changed in ubuntu-system-settings (Ubuntu RTM):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.