Indicators should only be visible if they contain data
Bug #1377275 reported by
Ted Gould
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bluetooth Menu |
Invalid
|
High
|
Unassigned | ||
Indicator Location |
Fix Released
|
High
|
Charles Kerr | ||
Messaging Menu |
Confirmed
|
High
|
Unassigned | ||
Transfer Indicator |
Fix Released
|
High
|
Charles Kerr | ||
indicator-location (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
indicator-transfer (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Design Change
To accommodate the new design for revealing the indicators they should only be marked as visible if they contain a useful state for interaction. They'll still be available to the user, so they must also when marked as invisible still contain their menu items.
Related branches
lp://qastaging/~charlesk/indicator-location/rtm-usability-fix
- Ted Gould (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 313 lines (+163/-21)7 files modifiedsrc/dbus-shared.h (+26/-0)
src/phone.cc (+16/-8)
src/phone.h (+3/-2)
src/service.cc (+4/-6)
tests/gtest-dbus-indicator-fixture.h (+1/-1)
tests/manual (+18/-0)
tests/phone-test.cc (+95/-4)
lp://qastaging/~charlesk/indicator-transfer/rtm-usability-fix
- PS Jenkins bot (community): Approve (continuous-integration)
- Ted Gould (community): Approve
-
Diff: 229 lines (+154/-7)3 files modifiedsrc/view-gmenu.cpp (+15/-3)
tests/manual (+12/-3)
tests/test-view-gmenu.cpp (+127/-1)
tags: | added: rtm14 |
Changed in indicator-bluetooth: | |
status: | New → Confirmed |
Changed in indicator-location: | |
status: | New → Confirmed |
Changed in indicator-messages: | |
status: | New → Confirmed |
Changed in indicator-transfer: | |
status: | New → Confirmed |
Changed in indicator-bluetooth: | |
importance: | Undecided → High |
Changed in indicator-location: | |
importance: | Undecided → High |
Changed in indicator-messages: | |
importance: | Undecided → High |
Changed in indicator-transfer: | |
importance: | Undecided → High |
Changed in indicator-location: | |
assignee: | nobody → Charles Kerr (charlesk) |
status: | Confirmed → In Progress |
Changed in indicator-transfer: | |
status: | Confirmed → In Progress |
assignee: | nobody → Charles Kerr (charlesk) |
Changed in indicator-bluetooth: | |
assignee: | nobody → Charles Kerr (charlesk) |
Changed in indicator-location: | |
status: | In Progress → Fix Released |
Changed in indicator-transfer: | |
status: | In Progress → Fix Released |
To post a comment you must log in.
On the phone, the bluetooth indicator's already following the policy of "visible only when bluetooth is enabled", which follows the "Indicators: RTM Usability Fixes" doc.