Inkscape

Drop internal copy of cxxtest

Bug #1094771 reported by Alex Valavanis
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Low
Unassigned
Inkscape Devlibs
Won't Fix
Low
Unassigned

Bug Description

lp:inkscape, r12000

At the moment we ship an internal copy of cxxtest 3.10.1 in trunk. A quick check, shows that cxxtest is available in Ubuntu Quantal/Raring [1] and in Fedora [2].

For the sake of maintainability, we should consider getting rid of our internal copy of cxxcheck when its adoption is more widespread in distros.

[1] https://launchpad.net/ubuntu/+source/cxxtest
[2] http://koji.fedoraproject.org/koji/packageinfo?packageID=8973

See original description
Tags: build
Alex Valavanis (valavanisalex)
description: updated
Changed in inkscape:
importance: Undecided → Low
tags: added: build
Changed in inkscape:
status: New → Triaged
Revision history for this message
Alex Valavanis (valavanisalex) wrote :

Adding a patch (against r12000) to drop use of internal cxxtest.

With the Ubuntu cxxtest package installed, I am able to run "make check". The test suite is generated successfully, although a number of new non-fatal compiler warnings are thrown.

Revision history for this message
jazzynico (jazzynico) wrote :

On Windows, removing the files from the trunk means adding them (compiled) in the devlibs.

Revision history for this message
Alex Valavanis (valavanisalex) wrote :

@nico - Well yes, but we could say that about all external libraries! Is there a reason why this would be a special case?

Revision history for this message
jazzynico (jazzynico) wrote :

@Alex - It is not a special case, but I needed a reminder that there are things to do in the devlibs (and in the build.xml file) before dropping the internal copy.

Changed in inkscape-devlibs:
status: New → Triaged
importance: Undecided → Low
assignee: nobody → JazzyNico (jazzynico)
Revision history for this message
Alex Valavanis (valavanisalex) wrote :

OK, sorry about the misunderstanding! How shall we proceed? Do you want to apply the patch to trunk at the same time as bundling the binary in devlibs?

Revision history for this message
su_v (suv-lp) wrote :

AFAICT no portfile for cxxtest available for OS X builds using dependencies installed via MacPorts:
<http://www.macports.org/ports.php?by=name&substr=cxxtest>

jazzynico (jazzynico)
Changed in inkscape-devlibs:
assignee: jazzynico (jazzynico) → nobody
Revision history for this message
jazzynico (jazzynico) wrote :

Work in progress to replace cxxtest with googletest. Probably "won't fix" soon.

Revision history for this message
Alex Valavanis (valavanisalex) wrote :

CMake build uses Googletest only. Dropped cxxtest in lp:inkscape r15096 so no need to update devlibs

Changed in inkscape-devlibs:
status: Triaged → Won't Fix
Changed in inkscape:
status: Triaged → Fix Committed
Bryce Harrington (bryce)
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.