2014-01-15 01:15:25 |
David Mathog |
bug |
|
|
added bug |
2014-01-15 01:15:25 |
David Mathog |
attachment added |
|
changes_2014_01_14a_small.patch https://bugs.launchpad.net/bugs/1269206/+attachment/3948901/+files/changes_2014_01_14a_small.patch |
|
2014-01-15 01:15:57 |
David Mathog |
attachment added |
|
Test file, with decorations https://bugs.launchpad.net/inkscape/+bug/1269206/+attachment/3948902/+files/text_decorations.svg |
|
2014-01-15 01:16:21 |
David Mathog |
attachment added |
|
Screen shot of test file https://bugs.launchpad.net/inkscape/+bug/1269206/+attachment/3948903/+files/text_decorations.png |
|
2014-01-15 01:19:11 |
David Mathog |
attachment added |
|
Screen shot of dialog https://bugs.launchpad.net/inkscape/+bug/1269206/+attachment/3948904/+files/text_and_font.png |
|
2014-01-16 01:24:20 |
su_v |
attachment added |
|
1269206-crash-text-decoration-with-user-icons-file-osx-quartz-64bit.txt https://bugs.launchpad.net/inkscape/+bug/1269206/+attachment/3949866/+files/1269206-crash-text-decoration-with-user-icons-file-osx-quartz-64bit.txt |
|
2014-01-16 19:10:10 |
David Mathog |
attachment added |
|
changes_2014_01_16b.patch https://bugs.launchpad.net/inkscape/+bug/1269206/+attachment/3950243/+files/changes_2014_01_16b.patch |
|
2014-01-16 21:28:17 |
su_v |
tags |
|
css styles text |
|
2014-01-16 21:28:23 |
su_v |
inkscape: importance |
Undecided |
Wishlist |
|
2014-01-16 21:28:30 |
su_v |
inkscape: status |
New |
In Progress |
|
2014-01-16 21:32:37 |
su_v |
description |
The attached patch implements a first pass of modifications to the text and font dialog that let it control text decorations.
Shift-control-t opens that dialog, select the "decorate" tab.
This patch also includes the changes in the patch in bug 1243401, which restored text decoration rendering.
This patch is applied in the typical manner, but it modifies share/icons/icons.svg, and those changes will not be evident until
that file is copied to wherever you keep your system's version of that file. On my linux box it was: /usr/local/share/inkscape/icons/icons.svg.
SVG 1.1 only supports CSS 2 text decorations (line type). Future SVG will probably support CSS3 (line style and color too).
There is a switch in the tab to select CSS 2 or CSS 3 compatibility. SInce this is a primitive first pass, the color and style lines do not gray out when CSS 2 is selected. Additionally the color support is rudimentary at this point for CSS 3, it only lets you choose whether the color comes from the text's fill or if it is "custom", but custom at this point is just a fixed color. To be useful that needs to open up into a color picker. Additionally the decorations buttons do not yet pick up their state from the selected text.
A test file and a screen shot of it will be posted next.
There is one outright bug in this somewhere. Every once and a while the "text-decoration" field is placed outside the style, like this:
style="...."
text-decoration="underline"
whereas it should be
style="...; text-decoration:underline;"
If one of those outside the style fields is present the "?" inherit button will generally not work properly. |
The attached patch implements a first pass of modifications to the text and font dialog that let it control text decorations.
Shift-control-t opens that dialog, select the "decorate" tab.
This patch also includes the changes in the patch in bug 1243401, which restored text decoration rendering.
This patch is applied in the typical manner, but it modifies share/icons/icons.svg, and those changes will not be evident until
that file is copied to wherever you keep your system's version of that file. On my linux box it was: /usr/local/share/inkscape/icons/icons.svg.
SVG 1.1 only supports CSS 2 text decorations (line type). Future SVG will probably support CSS3 (line style and color too).
There is a switch in the tab to select CSS 2 or CSS 3 compatibility. SInce this is a primitive first pass, the color and style lines do not gray out when CSS 2 is selected. Additionally the color support is rudimentary at this point for CSS 3, it only lets you choose whether the color comes from the text's fill or if it is "custom", but custom at this point is just a fixed color. To be useful that needs to open up into a color picker. Additionally the decorations buttons do not yet pick up their state from the selected text.
A test file and a screen shot of it will be posted next.
There is one outright bug in this somewhere. Every once and a while the "text-decoration" field is placed outside the style, like this:
style="...."
text-decoration="underline"
whereas it should be
style="...; text-decoration:underline;"
If one of those outside the style fields is present the "?" inherit button will generally not work properly.
---
Related reports:
Bug #172133 “Implement SVG text-decoration - underline, strikethrough, etc.”
Bug #1243401 “Clickable area of a text object is much larger than the object itself” |
|
2014-01-17 23:44:33 |
David Mathog |
attachment added |
|
changes_2014_01_17c_textdecorateonly.patch https://bugs.launchpad.net/inkscape/+bug/1269206/+attachment/3951230/+files/changes_2014_01_17c_textdecorateonly.patch |
|
2014-01-17 23:47:08 |
David Mathog |
attachment added |
|
text_decorations.svg https://bugs.launchpad.net/inkscape/+bug/1269206/+attachment/3951231/+files/text_decorations.svg |
|
2014-01-29 01:15:26 |
David Mathog |
attachment added |
|
changes_2014_01_28b.patch https://bugs.launchpad.net/inkscape/+bug/1269206/+attachment/3961192/+files/changes_2014_01_28b.patch |
|
2014-01-30 01:19:58 |
David Mathog |
attachment added |
|
text_decorations_filled.svg https://bugs.launchpad.net/inkscape/+bug/1269206/+attachment/3962221/+files/text_decorations_filled.svg |
|
2014-01-31 19:38:27 |
David Mathog |
attachment added |
|
changes_2014_01_31a_textdecorateonly.patch https://bugs.launchpad.net/inkscape/+bug/1269206/+attachment/3964615/+files/changes_2014_01_31a_textdecorateonly.patch |
|
2014-01-31 19:40:22 |
David Mathog |
attachment added |
|
text_decorations_filled.svg https://bugs.launchpad.net/inkscape/+bug/1269206/+attachment/3964616/+files/text_decorations_filled.svg |
|
2014-01-31 19:49:28 |
David Mathog |
attachment added |
|
boom3.svg https://bugs.launchpad.net/inkscape/+bug/1269206/+attachment/3964617/+files/boom3.svg |
|
2014-02-09 08:26:19 |
su_v |
attachment added |
|
1269206-changes_2014_01_31a_textdecorateonly-r13012.diff https://bugs.launchpad.net/inkscape/+bug/1269206/+attachment/3974506/+files/1269206-changes_2014_01_31a_textdecorateonly-r13012.diff |
|
2014-02-10 20:38:39 |
David Mathog |
attachment added |
|
changes_2014_02_10e.patch https://bugs.launchpad.net/inkscape/+bug/1269206/+attachment/3976231/+files/changes_2014_02_10e.patch |
|
2014-02-20 23:45:53 |
David Mathog |
attachment added |
|
changes_2014_02_20c_textdecorateonly.patch https://bugs.launchpad.net/inkscape/+bug/1269206/+attachment/3989018/+files/changes_2014_02_20c_textdecorateonly.patch |
|
2014-02-21 23:22:07 |
David Mathog |
attachment added |
|
changes_2014_02_21b.patch https://bugs.launchpad.net/inkscape/+bug/1269206/+attachment/3990294/+files/changes_2014_02_21b.patch |
|
2014-02-21 23:24:02 |
David Mathog |
attachment added |
|
changes_2014_02_21b_textdecorateonly.patch https://bugs.launchpad.net/inkscape/+bug/1269206/+attachment/3990295/+files/changes_2014_02_21b_textdecorateonly.patch |
|
2014-02-21 23:24:31 |
David Mathog |
attachment removed |
changes_2014_02_21b.patch https://bugs.launchpad.net/inkscape/+bug/1269206/+attachment/3990294/+files/changes_2014_02_21b.patch |
|
|
2014-03-10 23:26:50 |
David Mathog |
attachment added |
|
changes_2014_03_10d_textdecorateonly.patch https://bugs.launchpad.net/inkscape/+bug/1269206/+attachment/4017435/+files/changes_2014_03_10d_textdecorateonly.patch |
|
2014-03-11 23:14:44 |
David Mathog |
attachment added |
|
changes_2014_03_11b_textdecorateonly.patch https://bugs.launchpad.net/inkscape/+bug/1269206/+attachment/4019016/+files/changes_2014_03_11b_textdecorateonly.patch |
|
2014-10-31 23:11:50 |
David Mathog |
attachment added |
|
changes_2014_10_30a_decorationseditor.patch https://bugs.launchpad.net/inkscape/+bug/1269206/+attachment/4250352/+files/changes_2014_10_30a_decorationseditor.patch |
|
2016-07-13 09:24:26 |
pranav |
attachment added |
|
example attachment. https://bugs.launchpad.net/inkscape/+bug/1269206/+attachment/4699973/+files/product_1.svg |
|
2019-08-29 07:38:38 |
Bernd Prager |
bug |
|
|
added subscriber Bernd Prager |