Guide dialog doesn’t close when pressing Escape

Duplicate of bug #171357 "Make escape key close modeless dialogs"?
<https://bugs.launchpad.net/inkscape/+bug/171357>

On 2015-11-03 14:44 (+0100), jazzynico wrote:
> Duplicate of bug #171357 "Make escape key close modeless dialogs"?

AFAIU "modeless" dialogs (non-modal, stay on the screen and are available for use at any time but permit other user activities) are not the same as "modal" dialogs (require the user to respond before continuing the program).

Testing current trunk (with default dockable dialogs), the 'Guideline' dialog was the only modal dialog I found which does not close with <Esc>.

Other modal dialogs which do close with <Esc>:
- File > New from Template
- all GtkFileChooser dialogs
- the GtkPrint dialog
- Layer > Add Layer
- Layer > Rename Layer
- Layer > Move Selection to Layer
- Path > Path Effects > Add Path Effect
- Path > Path Effects > Powerstroke > Modify Node position
- Path > Path Effects > Fillet/Chamfer > Modify Fillet/Chamfer
- Filters/Extensions > Settings with Live Preview toggled on
- (… and likely others I missed.)

<Esc> should work as 'Cancel' for this type of dialog.

Bug also confirmed on Ubuntu for Inkscape version 0.91-11

The issue only show when a scalar unit widget (Inkscape::UI::Widget::ScalarUnit) has the focus. If you first give the focus (by clicking or using the tab key) to the label entry, the color selector, an unit selector or a checkbox, the escape key then quit the dialog as expected.

Other dialogs that use the same widget are also affected (tested with New from template, with DVD Cover and the DVD cover bleed option focused).

A quick workaround could be to give the focus to the Label entry by default so that the issue is not exposed when opening/quitting the dialog with no modification.

If I understand correctly, starting in the X, Y or Angle widget (depending on the type of guide) was done purposely, so the workaround is probably not a good idea.

Also note that escaping when in a scalar unit widget already resets its value (when changed and when focus is still in the widget). So changing that behavior is probably not a good idea either.

JazzyNico wrote:
> The issue only show when a scalar unit widget
> (Inkscape::UI::Widget::ScalarUnit) has the focus. If you first give
> the focus (by clicking or using the tab key) to the label entry, the
> color selector, an unit selector or a checkbox, the escape key then
> quit the dialog as expected.

That's AFAICT also the underlying issue of bug #1235679.