Use color picker to add colors to palette

Patch attached that creates a color swatch when Ctrl+Clicking the dropper, this swatch should be added to the Swatch Auto palette.
Ctrl+click was used since, Alt+Click currently selects the "Inverse" color and Shift+click is used to set the color to the Stroke

Question: could this mouse shortcut (Ctrl+click) somehow be limited to be only available if the 'Auto' palette is currently displayed (either in the palette below the canvas, or in the separate 'Swatches' dialog), or the 'Fill&Stroke' dialog is visibly opened? Or maybe it could be an explicit option (toggle) in the toolbar?

Without giving special visual feedback that a new custom color swatch is created each time the user 'ctrl-clicks' in the dropper tool context (possibly accidentally), users unfamiliar with custom swatches may never notice that a) the shortcut actually works, and/or b) they might unintentionally be adding multiple swatches (which are not cleaned up, and only can be removed one by one via context menu in the 'Auto' palette). Even experienced users might trigger it unintentionally when tool-switching fails and the control-click was intended e.g. for the select tool.

(Caveat: I haven't tested the patch yet - it's just an issue that had bothered me with the 'Swatch' button in Fill&Stroke in the current stable release 0.48.x - after having seen drawings from users asking for help because the files had grown unmanageable in Inkscape performance-wise - due to the number of swatches created unintentionally and the many forked duplicates resulting from normal copy&pasting)

How about the attached having an explicit toggle on the toolbar ?

I hate the toggle on the toolbar method. This requires a precision per pick rather than I can pick 5 times and then manually choose to add the best match intentionally. Yes, I tested the patch, I just find it to be too precise in it's requirements. (Yes, I know I think the picker via F&S dialog should operate like that, but that's different than creating a reusable palette)

ScislaC wrote:
> I hate the toggle on the toolbar method. This requires a precision per
> pick rather than I can pick 5 times and then manually choose to add the
> best match intentionally.

I didn't consider this - sorry if having caused distraction by my earlier question: please consider it retracted (I'll try to do better next time and comment only if having tested a proposed patch).

@ScislaC, what do you think is the best way to access this function ?

@~suv, In the bottom palette yes, but I dont think we can easily determine if the dialogs (F/S and Swatches) are currently visible.

@John - see also this related RFE filed recently:
Bug #1049481 “Allow dropper tool to edit current custom swatch fill”

Hi - thanks for reporting this bug, I've merged it to Inkscape's new bug tracker on GitLab, and closed it here.

Please feel free to file new bugs about the issues you're seeing at
https://inkscape.org/report .

Merged to: https://gitlab.com/inkscape/inbox/-/issues/596
Closed by: https://gitlab.com/greytomorrow