make check modifies preferences
Bug #374455 reported by
Krzysztof Kosinski
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Inkscape |
New
|
Low
|
Unassigned | ||
Bug Description
When make check is executed, it modifies the user's preferences file. After make check, my prefs file contained the following snippet, clearly originating from preferences-test.h:
<group
prefentry=
id="test"
intvalue=
It would be good if make check could not alter the user's preferences, e.g. any changes were discarded after the test run finishes. Another issue is that if preferences are saved during the test run, they could also be saved on crashes, which can lead to prefs file corruption (see bug #168922)
| tags: | added: build |
Revision history for this message
| Jon A. Cruz (jon-joncruz) wrote | #1 |
Revision history for this message
| Krzysztof Kosinski (tweenk) wrote | #2 |
| Changed in inkscape: | |
| importance: | Undecided → Low |
To post a comment you must log in.
Problems in the architecture of the unit tests expanded in set of changes in the code and then exposed in a latter one.
The unit tests just need to use a mock object for preferences and have a define for a test mode for the older framework.