Close button on document background color window

> Don't know on Mac OS.

The color selector dialog used e.g. for the page background and the grid colors does not have its own close button on Mac OS X (using GTK+/Quartz, or GTK+/X11). I never had any issues with that: the dialog can be closed with <esc>, and with the close button provided by the window manager (in the top bar of window decoration, which also displays the name of the dialog).

For me personally, this is a non-issue (I never missed a 'Close' button _inside_ this specific dialog, and I always have one provided by the window manager). If you add an explicit close button to the widget, will it also be displayed inside the Fill & Stroke dialog, or e.g. the (depricated) gradient editor dialog, or in extensions dialogs using the same widget to select a color? AFAIU this color selection notebook widget is used elsewhere - thus your proposal could possibly duplicate a close button which can optionally be displayed in (almost) all dialogs (see 'Inkscape Preferences > Windows > Miscellaneous > [ ] Show close button on dialogs')?
(Note: I'm not a developer and did not take a closer look at the code you refer to (UI::Widget::RegisteredColorPicker widgets). I also was not aware that apparently the Windows port differs to such extents from the other platforms (beyond using native file dialogs) and can't recall having seen a screenshot of the mentioned dialog on Windows with the additional 'Close' button as part of the dialog (using a Gtk button)).

On Fedora, do you use docked dialogs (default) or floating dialogs (which cannot -not even optionally- be docked)? This can be set in 'Inkscape Preferences > Windows > Dialog Behavior', as can . Or could it be that your window manager does not provide the close button for such types of dialogs?

Attached: screenshot of current trunk - Gtk+/Quartz to the left, Gtk+/X11 to the right.

Replaced screenshot (now using the same Gtk+ theme for builds with either backend of Gtk+).

I'm talking about the Close button inside the "top bar of window decoration" (which is usually a X on a red background in Windows) and not a Gtk button. In Fedora I only have the window title (someting like "Background color").

I will try to put a screenshot later.

In your screenshot, I don't know if they are enabled, but at least you have those three buttons at top left.

> In your screenshot, I don't know if they are enabled, but
> at least you have those three buttons at top left.

Sorry, I'm using the Graphite variant of the Mac OS X GUI (which does not color the buttons on the window decoration):
The three buttons from left to right: 'Close', 'Minimize' to dock, 'Maximize'.
The Gtk+/X11 variant does not allow to maximize such (transient?) dialogs (disabled), whereas the Gtk+/Quartz does allow it (all three buttons are active).

Replacing the screenshot with revised images showing the symbols (on mouse-over).

First, please find attached a screenshot where you can see there is no Close button at the top right (like in every Fedora Windows which have a Close feature).

The bug occurs whether the document window (its parent) is docked or not.

Moreover, I've discovered another bug with this window but it occurs on Fedora and Window, so I will report it as new bug (but maybe it's linked).

Here the second (and maybe linked) bug : Bug #901824

Which window manager do you use on Fedora?

@JazzyNico - could you compare this to the default desktop on current Ubuntu?

Gnome

Ubuntu screenshot attached.
Note that I use a standard windows decoration.
@romain, do you use a specific theme or customization?

> Gnome

Assuming Gnome 3 then (you did not provide information about which Fedora version you have installed). Could this be a "new feature" of Gnome 3 to no longer display _any_ button in the window decoration for certain types of dialogs? (If I google for Gnome3 screenshots, I find plenty of such examples, but unfortunately I cannot compare it to how the same dialogs are displayed under Gnome2, or Unity, or other desktops.)

Sorry, I've Fedora 16 with Gnome 3.2.1. I've migrated recently from Ubuntu to Fedora (Gnome 3 on Ubuntu 11.10 was horrible, but that's not the point) and did not remember to have changed or customized anything (I don't even know yet how to change it).

Tested with Ubuntu 11.11 (Gnome 3.2.1, Unity), and I still have the close icon as expected (exactly the same screenshot I posted with 11.04).

Romain: can you still repro with 0.91 or 0.92? You can now try GTK3 with 0.92.