Inkscape

GTK3: Crash on closing Text and Font dialog using "Close" button

  1. Series experimental
  2. Bug #1090936
Bug #1090936 reported by Alex Valavanis
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
High
Liam P. White
Experimental
Fix Committed
High
Liam P. White

Bug Description

lp:inkscape r11960
Ubuntu 12.10 amd64
GTK+ 3.5.13

To reproduce:
* Text->Text and Font...
>> dialog appears
* Click the "Close" button in the dialog.
>> crash (backtrace attached)

Note that this does not seem to happen with Gtk+ 2, or when the close icon ("X") in the dialog handle is clicked.

As a side note, is there a sensible reason for having the "Close" button in this dialog? I guess it's a legacy from the days before it was dockable. Other dockable dialogs don't tend to have one.

See original description
Tags: crash gtk3 text
Revision history for this message
Alex Valavanis (valavanisalex) wrote :
Changed in inkscape:
importance: Undecided → High
Revision history for this message
jazzynico (jazzynico) wrote :

Not reproduced on Windows XP, experimental GTK3 build (gtk3-3.6.1, gtk3mm-3.4.0), trunk revision 11951 and 11960.

Alex Valavanis (valavanisalex)
description: updated
Revision history for this message
su_v (suv-lp) wrote :

On OS X 10.7.4 with Inkscape 0.48+devel r11959 (64bit):
- not reproduced with GTK+/X11 3.4.4, gtkmm3 3.4.0, gdl3 3.4.2, glib2 2.32.4
- reproduced with GTK+/Quartz 3.6.2, gtkmm3 3.6.0, gdl3 3.6.2, glib2 2.34.4

Revision history for this message
su_v (suv-lp) wrote :

Correction (typo):
- On OS X 10.7.4 with Inkscape 0.48+devel r11959 (64bit):
+ On OS X 10.7.4 with Inkscape 0.48+devel r11960 (64bit):

backtrace attached.

Changed in inkscape:
status: New → Confirmed
Revision history for this message
su_v (suv-lp) wrote :

Sorry, another typo: the quartz build uses glib2 2.34.3 (not 2.34.4)

Revision history for this message
jazzynico (jazzynico) wrote :

And not reproduced on Debian testing, Inkscape trunk revision 11960, gtk3-3.4.2-4, gtkmm3-3.4.2-1, glib-2.33.12 and gdl-3.4.2-1.

Revision history for this message
Alex Valavanis (valavanisalex) wrote :

Hmm... this is a strange one.

Any thoughts about whether we actually want the button to be there, given that it's redundant with the close icon in the handle?

Revision history for this message
su_v (suv-lp) wrote :

> As a side note, is there a sensible reason for having the "Close" button in this dialog?

Related:
Bug #170534 “add optional "close" buttons to all dialogs”
<https://bugs.launchpad.net/bugs/170534>

I don't know any history or deatils about this optional feature - maybe someone on the mailing list can provide more insight…

Revision history for this message
Liam P. White (liampwhite) wrote :

Fix committed in lp:inkscape/experimental, r13484.

The idea: don't directly tell dialogs to delete themselves, just use the virtual pad of the existing dialog behavior modifier.

Changed in inkscape:
assignee: nobody → Liam P. White (inkscapebrony)
status: Confirmed → Fix Committed
Revision history for this message
su_v (suv-lp) wrote :

commit <http://bazaar.launchpad.net/~inkscape.dev/inkscape/experimental/revision/13484> introduces regression affecting GTK2 and GTK3: dialogs' closed status is not stored on quit, and on the next launch the dialogs closed in the last session are immediately reopened.

Revision history for this message
su_v (suv-lp) wrote :

Regression confirmed fixed in lp:inkscape/experimental r13485
http://bazaar.launchpad.net/~inkscape.dev/inkscape/experimental/revision/13485

Revision history for this message
su_v (suv-lp) wrote :

The experimental branch was merged into trunk in r13641.

Closing this report as 'Fix Released' in accordance with
<http://wiki.inkscape.org/wiki/index.php/Bug_management#Bug_status>

Changed in inkscape:
status: Confirmed → Fix Released
no longer affects: inkscape/0.91.x
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.