[ADL] Thunderbolt out-of-tree patches

Bug #1943511 reported by Chao Qin
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
intel
New
Undecided
Unassigned
Lookout-canyon-series
Fix Released
Undecided
Philip Cox

Bug Description

Description
Discrete Thunderbolt support

Hardware: AlderLake

Target Release: 21.04
Target Kernel: TBD

External links:
https://github.com/intel/linux-intel-quilt/tree/mainline-tracking-v5.13-yocto-210727T062416Z

X-HWE-Bug: Bug #1952018

Revision history for this message
Chao Qin (chaoqin) wrote :

Please find the following patches in the above external link

0001-thunderbolt-Split-NVM-read-write-generic-funct.thunderbolt
0002-thunderbolt-Use-generic-tb_nvm_-read-write-_da.thunderbolt
0003-Documentation-thunderbolt-Clean-up-entries.thunderbolt
0004-thunderbolt-Add-wake-from-DisplayPort.thunderbolt
0005-thunderbolt-Align-USB4-router-wakes-configurat.thunderbolt
0006-thunderbolt-Make-tb_port_type-take-const-param.thunderbolt
0007-thunderbolt-Move-nfc_credits-field-to-struct-t.thunderbolt
0008-thunderbolt-keep-count-of-DP-IN-adapters-in-th.thunderbolt
0009-thunderbolt-Wait-for-the-lanes-to-actually-bon.thunderbolt
0010-thunderbolt-Read-router-preferred-credit-alloc.thunderbolt
0011-thunderbolt-Update-port-credits-after-bonding-.thunderbolt
0012-thunderbolt-Allocate-credits-according-to-rout.thunderbolt
0013-thunderbolt-Add-quirk-for-Intel-Goshen-Ridge-D.thunderbolt
0014-thunderbolt-Add-KUnit-tests-for-credit-allocat.thunderbolt
0015-thunderbolt-Log-the-link-as-TBT-instead-of-TBT.thunderbolt
0016-thunderbolt-Add-USB4-port-devices.thunderbolt
0017-thunderbolt-Add-support-for-ACPI-_DSM-to-power.thunderbolt
0018-thunderbolt-Add-additional-USB4-port-operation.thunderbolt
0019-thunderbolt-Add-support-for-retimer-NVM-upgrad.thunderbolt
0020-thunderbolt-Move-nvm_write_ops-to-tb.h.thunderbolt
0021-thunderbolt-Allow-router-NVM-authenticate-sepa.thunderbolt
0022-thunderbolt-Add-WRITE_ONLY-and-AUTHENTICATE_ON.thunderbolt
0023-thunderbolt-Check-for-NVM-authentication-statu.thunderbolt
0024-thunderbolt-Add-support-for-Intel-Alder-Lake.thunderbolt

Changed in intel:
assignee: nobody → Alex Hung (alexhung)
Changed in intel:
assignee: Alex Hung (alexhung) → nobody
Revision history for this message
Chao Qin (chaoqin) wrote :

0001-thunderbolt-Split-NVM-read-write-generic-funct.thunderbolt --> 9b383037770fcd6b03dd3793c89055b8490957e0
0002-thunderbolt-Use-generic-tb_nvm_-read-write-_da.thunderbolt --> 34163dfad412947c1a413324d0293f1da219231f
0003-Documentation-thunderbolt-Clean-up-entries.thunderbolt --> 68977e61ab9e3fbb8ebbb1c7e8c772762d232f7c
0004-thunderbolt-Add-wake-from-DisplayPort.thunderbolt --> 6026b703e8f61bf9c395bb286fa3b46956ce0496
0005-thunderbolt-Align-USB4-router-wakes-configurat.thunderbolt --> 3caf88871c6ad0bf7c5fca8a6f7fcada1891a891
0006-thunderbolt-Make-tb_port_type-take-const-param.thunderbolt --> 1c561e4e659d59f1f2825dec42f09338eac1c774
0007-thunderbolt-Move-nfc_credits-field-to-struct-t.thunderbolt --> 02c5e7c2db2bdfe227dd3e7f6febd732ccec5440
0008-thunderbolt-keep-count-of-DP-IN-adapters-in-th.thunderbolt
0009-thunderbolt-Wait-for-the-lanes-to-actually-bon.thunderbolt --> e7051beab8393dc614f7ea3969aa03bc490db1d6
0010-thunderbolt-Read-router-preferred-credit-alloc.thunderbolt --> 56ad3aef5cdac0695944985f7f70209aec0efd4d
0011-thunderbolt-Update-port-credits-after-bonding-.thunderbolt --> 69fea377e660dcd2f5ab3097b9bd5ed29cfac1fa
0012-thunderbolt-Allocate-credits-according-to-rout.thunderbolt --> 6ed541c53edcd5bf3cbd9fd600fd593e95ec79fb
0013-thunderbolt-Add-quirk-for-Intel-Goshen-Ridge-D.thunderbolt --> 7c37bb304fd6c085f9630d1740ed53781d4d4821
0014-thunderbolt-Add-KUnit-tests-for-credit-allocat.thunderbolt --> bfa8f78e06ed0b495a5736380de0e7f833a5efbe
0015-thunderbolt-Log-the-link-as-TBT-instead-of-TBT.thunderbolt --> 0f28879cf6836f170773a9456c856e1f08f56764
0016-thunderbolt-Add-USB4-port-devices.thunderbolt --> cae5f5151d76635f6b5c08133184c48048346e63
0017-thunderbolt-Add-support-for-ACPI-_DSM-to-power.thunderbolt --> ccc5cb8ad5d18ec0e008d1652711fa1c18e9366c
0018-thunderbolt-Add-additional-USB4-port-operation.thunderbolt --> 3406de7cc20f254010f2f17450a58541fb77ffea
0019-thunderbolt-Add-support-for-retimer-NVM-upgrad.thunderbolt --> 3fb10ea4ce86d4d06622be894099c59872e92c57
0020-thunderbolt-Move-nvm_write_ops-to-tb.h.thunderbolt --> ff3a8306456755689babc7bcc29c60e582738c7b
0021-thunderbolt-Allow-router-NVM-authenticate-sepa.thunderbolt --> 1cbf680f7687f55ae5a1405556519bc70d66a616
0022-thunderbolt-Add-WRITE_ONLY-and-AUTHENTICATE_ON.thunderbolt --> faa1c615f0bdd4f3ac5288bf2952f49dfeac916c
0023-thunderbolt-Check-for-NVM-authentication-statu.thunderbolt --> 25335b30daf66f4cc03715c2ac9cdc3258fb5531
0024-thunderbolt-Add-support-for-Intel-Alder-Lake.thunderbolt --> 135794868ad83d0327cdd78df469e118f1fe7cc4

Revision history for this message
Chao Qin (chaoqin) wrote :

Only Device ID patches are relevant to the platform. Others are common TBT code

1) ADL-S
db0746e3399e thunderbolt: Add support for Intel Maple Ridge --> already merged since v5.11

2) ADL-P
0024-thunderbolt-Add-support-for-Intel-Alder-Lake.thunderbolt --> 135794868ad83d0327cdd78df469e118f1fe7cc4

Revision history for this message
Alex Hung (alexhung) wrote :

The following patches are already included in intel-5.13-next.

0001-thunderbolt-Split-NVM-read-write-generic-funct.thunderbolt (da900c74219d3bad26776d0e44f44ddcc42656ad)

0006-thunderbolt-Make-tb_port_type-take-const-param.thunderbolt (91a1fa49c93529e410135ab72ebf78d773bf7477)

0010-thunderbolt-Read-router-preferred-credit-alloc.thunderbolt (4d75c5a604f2e891079cfa85adb664de66cbc68c)

0024-thunderbolt-Add-support-for-Intel-Alder-Lake.thunderbolt (f9b69ab26819bc0ce13f06754fe9062df924f828)

1) ADL-S
db0746e3399e thunderbolt: Add support for Intel Maple Ridge --> already merged since v5.11

Revision history for this message
Alex Hung (alexhung) wrote :

The following two patches have conflicts:

0013-thunderbolt-Add-quirk-for-Intel-Goshen-Ridge-D.thunderbolt (minor conflicts: a missing ID)

0014-thunderbolt-Add-KUnit-tests-for-credit-allocat.thunderbolt (conflicts were introduced by 28be35dde6d81 which was cherry-picked from Upstream commit a0d36fa1065901f9).

A backported patch should be combined bfa8f78e06ed0 and a0d36fa1065901f9 (28be35dde6d81). The patch was attached for reviews.

Revision history for this message
Alex Hung (alexhung) wrote :

A test kernel based on Ubuntu-intel-5.13-5.13.0-1008.8 is available @ https://people.canonical.com/~alexhung/LP1943511/

Alex Hung (alexhung)
description: updated
Revision history for this message
Anthony Wong (anthonywong) wrote :

Commits in comment #2 (except 0008-thunderbolt-keep-count-of-DP-IN-adapters-in-th.thunderbolt
) are in 5.14.

Revision history for this message
pragyansri.pathi@intel.com (pragyan) wrote :

I am confused all patches for Thunderbolt to support ADL-S is in upstream and should be in Canonical. What is unique for Thunderbolt for IoTG?

Revision history for this message
Marcelo Cerri (mhcerri) wrote :

Pragyansri, Chao,

Patch 0008 (0008-thunderbolt-keep-count-of-DP-IN-adapters-in-th.thunderbolt) indeed is not upstream yet and I couldn't find any reference to its submission.

Currently we have it applied to both our 5.13 and 5.15 iotg kernels. But based on Chao's comment #3, it seems patch 0008 an others are common code for TBT and because of that I'm wondering if this patch needs to be included to our 5.15 generic kernel as well?

Please can you provide some guidance about that?

Thank you!

Revision history for this message
Chao Qin (chaoqin) wrote :

@Marcelo

The #008 patch is rejected by upstream, and please remove it from your kernel.

Revision history for this message
Marcelo Cerri (mhcerri) wrote :

Thank you, Chao. We will drop the patch.

Ana Lasprilla (anamlt)
information type: Private → Public
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.