ironic-python-agent

Parsing of shell-like constructs should always use ironic-lib utils

Bug #2037572 reported by Jay Faulkner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ironic-python-agent
Fix Released
Low
Boushra Sondos Bettir

Bug Description

In some places in IPA code:
- https://opendev.org/openstack/ironic-python-agent/src/branch/master/ironic_python_agent/partition_utils.py#L620
- https://opendev.org/openstack/ironic-python-agent/src/branch/master/ironic_python_agent/hardware.py#L442
(not a comprehensive list, just examples)

we use shlex to parse shell-like structures

In other places:
- https://opendev.org/openstack/ironic-python-agent/src/commit/44d9c2219fd6d17a0aec063331187f147ab4ab11/ironic_python_agent/utils.py#L126
- https://opendev.org/openstack/ironic-python-agent/src/commit/1581f91826aab97a70f551da46a6557251d52a73/ironic_python_agent/partition_utils.py#L172

uses ironic_lib.utils.parse_device_tags

We should update all uses of this code in IPA to use the helper method, or completely eliminate use of the helper method. IMO, having a helper method is better as it gives us one place to fix breakages in output from utility versions.

See original description
Jay Faulkner (jason-oldos)
description: updated
Revision history for this message
Boushra Sondos Bettir (boushrabettir04) wrote :

From what I have seen, `ironic_lib` doesn't exist within the files in `ironic-python-agent`. Where could I find this helper function along with the file?

Changed in ironic-python-agent:
assignee: nobody → Boushra Sondos Bettir (boushrabettir04)
Jay Faulkner (jason-oldos)
Changed in ironic-python-agent:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.