Ironic

RFE:Allow drivers to choose the ports to be inspected

Bug #1588177 reported by Nisha Agarwal
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ironic
In Progress
Wishlist
ankit

Bug Description

The inband inspection has a mechanism to specify which ports to create.
The out-of-band inspection meachanism also should be at par with it.

The iLO drivers need the fix https://review.openstack.org/#/c/169303/ to be reverted back and make inspect_ports as an optional parameter so that
user has a choice to specify which ports to be created similar to inband inspection.

Additionally, this is needed in following scenario:

If there are two NICs cabled but one is cabled with fibre channel and another one is connected to ethernet, then second one should be chosen for deploy as the fibre channel NIC serves as the storage NIC and cannot be used for deploy. We need a mechanism for a user to specify which port he wants to inspect.

In-band inspection provide an option for user to choose/specify if they want the port to be created for all the NICs or only the active NICs.

See original description
Tags: needs-spec rfe
Bharath kumar (bharath-kumar3)
Changed in ironic:
assignee: nobody → Bharath kumar (bharath-kumar3)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/325230

Changed in ironic:
status: New → In Progress
OpenStack Infra (hudson-openstack)
Changed in ironic:
assignee: Bharath kumar (bharath-kumar3) → Nisha Agarwal (agarwalnisha1980)
OpenStack Infra (hudson-openstack)
Changed in ironic:
assignee: Nisha Agarwal (agarwalnisha1980) → Bharath kumar (bharath-kumar3)
Shivanand Tendulker (stendulker)
summary: - Allow ilo drivers to choose the ports to be inspected
+ RFE: Allow ilo drivers to choose the ports to be inspected
tags: added: rfe
OpenStack Infra (hudson-openstack)
Changed in ironic:
assignee: Bharath kumar (bharath-kumar3) → Shivanand Tendulker (stendulker)
Dmitry Tantsur (divius)
Changed in ironic:
importance: Undecided → Wishlist
Nisha Agarwal (agarwalnisha1980)
description: updated
Revision history for this message
Jim Rollenhagen (jim-rollenhagen) wrote : Re: RFE: Allow ilo drivers to choose the ports to be inspected

I'm fine with this if we make it generic, and not just for iLO

Revision history for this message
Ruby Loo (rloo) wrote :

We discussed this in the weekly Monday meeting [1]. Consensus was to make this generic. As long as the RFE here is updated and has sufficient information, no spec is required.

[1] starting at 17:22:43: http://eavesdrop.openstack.org/meetings/ironic/2016/ironic.2016-11-21-17.00.log.html

Nisha Agarwal (agarwalnisha1980)
summary: - RFE: Allow ilo drivers to choose the ports to be inspected
+ Allow ilo drivers to choose the ports to be inspected
tags: removed: rfe
Nisha Agarwal (agarwalnisha1980)
tags: added: rfe
summary: - Allow ilo drivers to choose the ports to be inspected
+ RFE:Allow ilo drivers to choose the ports to be inspected
OpenStack Infra (hudson-openstack)
Changed in ironic:
assignee: Shivanand Tendulker (stendulker) → Nisha Agarwal (agarwalnisha1980)
Nisha Agarwal (agarwalnisha1980)
summary: - RFE:Allow ilo drivers to choose the ports to be inspected
+ RFE:Allow drivers to choose the ports to be inspected
Revision history for this message
Nisha Agarwal (agarwalnisha1980) wrote :

The code is made generic as suggested. Parsing the inspect_ports option and creating a valid MAC list for creation of ironic ports has been generalized out in inspect_utils.py.(ironic/drivers/modules/inspect-utils.py).
Refer https://review.openstack.org/#/c/325230

Revision history for this message
Nisha Agarwal (agarwalnisha1980) wrote :

It was discussed with TheJulia again after she had concerns on this approach. The discussion can be found at http://eavesdrop.openstack.org/irclogs/%23openstack-ironic/%23openstack-ironic.2017-01-12.log.html and she agreed that OOB doesnt has any way to get the pxe_enabled NIC like inband can get.

OpenStack Infra (hudson-openstack)
Changed in ironic:
assignee: Nisha Agarwal (agarwalnisha1980) → Shivanand Tendulker (stendulker)
Revision history for this message
Ruby Loo (rloo) wrote :

I added the 'needs-spec' tag, since we had discussed this in our ironic meeting on 2016-11-21, and I don't see a generic solution proposed that addresses this. If you don't think it needs a spec, please update the description so that it is clear that a spec isn't needed. Otherwise, please add a spec. Thanks.

tags: added: needs-spec
OpenStack Infra (hudson-openstack)
Changed in ironic:
assignee: Shivanand Tendulker (stendulker) → ankit (ankit-dhn31)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.