Ironic

Nova Instance Guest Metadata

Bug #2063352 reported by Jay Faulkner on 2024-04-24

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Ironic	Fix Released	Medium	Jay Faulkner

Bug Description

There is currently a specless blueprint up in Nova for the other side of this: https://blueprints.launchpad.net/nova/+spec/ironic-guest-metadata

Right now, calls to Ironic from Nova are done without project credentials. This prevents us from using any information from the calling token to know what project should be used for setting node.lessee when [conductor]automatic_lessee=True. In order to enable this functionality, as well as provide basic instance metadata for operator troubleshooting cases, we will put selected portions of the nova instance metadata into node.instance_info at deploy, alongside the other metadata required to deploy.

This information will include:
- Information about the user/project who requested the instance
- Flavor name
- Any other useful metadata

This information will explicitly EXCLUDE:
- Information available elsewhere in Ironic
- Network-related metadata which may not be reliable in Ironic use cases

Once we have information on the user/project who requested the instance, we will then edit conductor code to implement setting node.lessee based on that metadata when automatic_lessee is enabled.

Tags:

Jay Faulkner (jason-oldos) on 2024-04-29

tags:

added: rfe-approved
removed: rfe

Julia Kreger (juliaashleykreger) on 2024-04-29

Changed in ironic:
importance:	Undecided → Medium

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2024-07-24: Related fix proposed to ironic (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/ironic/+/924887

Jay Faulkner (jason-oldos) on 2024-09-03

Changed in ironic:
assignee:	nobody → Jay Faulkner (jason-oldos)
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2024-09-05: Fix merged to ironic (master)

Reviewed: https://review.opendev.org/c/openstack/ironic/+/924887
Committed: https://opendev.org/openstack/ironic/commit/0eda3d65ea8b05e250e61e9957c50a226a3baf74
Submitter: "Zuul (22348)"
Branch: master

commit 0eda3d65ea8b05e250e61e9957c50a226a3baf74
Author: Jay Faulkner <email address hidden>
Date: Wed Jul 24 15:43:14 2024 -0700

Support Automatic Lessee from instance metadata

    Ironic already has support for automatically setting a lessee on
    deployment, but it is only supported for direct deployments with Ironic,
    as it uses request context which is not preserved in the Nova driver.

    Now, when combined with the related Nova change, Ironic can support this
    behavior for fully integrated installations. On deploy time, Nova will
    set several fields -- including project_id -- in instance info. If
    enabled, Ironic will then use that project_id as the automatic lessee.
    The previous behavior of using the project_id from the request context
    is still supported as a fallback.

This is being tracked in nova as blueprint ironic-guest-metadata.

Closes-Bug: #2063352
Change-Id: Id381a3d201c2f1b137279decc0e32096d4d95012