Adding a review comment for a public project shouldn't require membership

The current workflow is that as soon as the job is started, mp.nominateReviewer runs and it's visible to those looking at the MP that a review is pending from the bot account in question. When the actual CI run that tests the functionality required completes, the bot account then adds an "Approve" comment or a "Needs Fixing" comment. Depending on how long tests take to run this could be a very short or a long interval between nominating the review and adding the follow up comment. If the test run takes a long time, this is a useful indicator to reviewers that it's still in progress.

Removing this (or not failing if it fails) would mean that no longer happening.

Hi Tom, my thoughts:

Turning the mp.nominateReviewer() Unauthorized exception into a non-fatal warning looks sensible to me. J-l-p should still be able to submit a "vote" (review) to the MP, which will then appear as a community review. There will be no indicator that a CI run is in progress in this case, as you noted, but the rest should just work. I can't think of anything else that could go wrong in the jlp CI workflow because of this change, but we should definitely test in on a live MP before merging it.

One concern I have: as you know jlp has two branches at the moment: the legacy py2 branch and master, which uses Python3. Most of the deployments use the py2 branch at the moment, but I thought it as a "frozen" branch with no further development. We can certainly still land changes to it, but in this case we should make the effort of testing and committing them on master too, otherwise we'll have bad surprises in the future.

The package uses the unittest framework. I can run the tests from the master branch with:

  python3 -m unittest

IIRC running the Python 2 tests should be the same, but using the python2 interpreter and the py2 branch.