lxd client.go is way too verbose at DEBUG level and probably leaking credentials

This logging actually comes from upstream

https://github.com/lxc/lxd/blob/master/client.go#L124

LXD upstream issue created: https://github.com/lxc/lxd/issues/2532

I can't see the report. Looks like it requires internal Canonical privileges.

@Aaron

Could you please paste offending log lines from report as a scrubbed extract for external people to view and identify?

From lxd issue, Stephane's response:

The logging code we use in LXD itself doesn't have a TRACE level. The fact that you're getting those in Juju seems to indicate that you're registering a log handler in the juju code.

If you don't want LXD debug output to make it to your logs, just don't register a handler for the Debug output.

Looks like the offending part of the juju code is: https://github.com/juju/juju/blob/staging/tools/lxdclient/client.go#L67

Closing this issue as LXD's logging is consistent, it just doesn't match the log levels of Juju and the way to fix this is to change the log handler that Juju registers.

But we new debug output from lxd. We just don't want raw responses logged as debug. lxd could update its logging library to use github.com/juju/loggo which does provide a trace option. Or it could add trace it its own logging.

This is a very old report and a lot of things have changed both on Juju side and its integration with LXD as well as on the LXD side as well.

I am marking this as an Incomplete until we get confirmation that this is still an issue on newer versions of Juju. However, if there is an issue, a new report with more recent logs and code references is more desirable than re-opening this one.

This bug has not been updated in 2 years, so we're marking it Low importance. If you believe this is incorrect, please update the importance.