actions.yaml schema does not support "float"

It appears "number" is the proper type for a floating point value. My use of type: float in config.yaml worked in juju 1.25.6. Perhaps the types changed between versions. Will use "number" for this solution, but more useful expounding upon available types in the upgrade-charm check would be helpful.

Lastly, a number should be acceptable as a string, though I know it's not a strong type-cast, string should be allowed by juju run-action var=<number>.

YAML tries to interpret things that aren't in quotes as numbers and then
falls back to strings. Also, your shell would be trying to interpret "" on
the command-line. I think the syntax would be

juju run-action ... --value="'2.9'"

John
=:->

On Sep 1, 2017 07:50, "Drew Freiberger" <email address hidden> wrote:

> It appears "number" is the proper type for a floating point value. My
> use of type: float in config.yaml worked in juju 1.25.6. Perhaps the
> types changed between versions. Will use "number" for this solution,
> but more useful expounding upon available types in the upgrade-charm
> check would be helpful.
>
> Lastly, a number should be acceptable as a string, though I know it's
> not a strong type-cast, string should be allowed by juju run-action
> var=<number>.
>
> --
> You received this bug notification because you are subscribed to juju.
> Matching subscriptions: juju bugs
> https://bugs.launchpad.net/bugs/1714405
>
> Title:
> actions.yaml schema does not support "float"
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/juju/+bug/1714405/+subscriptions
>

Yes, I am pretty sure "float" in config.yaml works fine - we have a unit test exercising this.

I suspect that there may be a bug in parsing actions.yaml. To ensure that we'd see the same thing you have, could you please provide simple repro steps?

I've just faced that when trying to implement an action with a param of the 'float' type. When trying to upgrade the charm the following error message is displayed:

ERROR invalid params schema for action schema set-weight: int is not a valid type

When I change the type to 'number' I can successfully upgrade the charm. I tried changing the type manually to 'float' later on (by modifying the 'actions.yaml' file on the deployed application unit), but then when running the action I get the following error and action fails:

ERROR juju.worker.dependency engine.go:636 "uniter" manifold worker returned unexpected error: preparing operation "run action 35513ba2-6ab3-463e-8eee-c0dab5653d91": cannot create runner for action "35513ba2-6ab3-463e-8eee-c0dab5653d91": invalid params schema for action schema set-weight: float is not a valid type

Juju version is 2.5.1

This is related to https://bugs.launchpad.net/juju/+bug/1613838, for which a fix was released in juju 2.5.2

I've just tried to implement this option as 'string' and convert it to 'float' later on, but now I got the following error when running the action:

ERROR validation failed: (root).myoption : must be of type string, given 0

So it looks like 'number' is the only way to go for now.

https://bugs.launchpad.net/juju/+bug/1613838 is a bug about multi architecture builds for Juju, I'm guessing it is adifferent bug that you are referencing.

maybe you meant: https://bugs.launchpad.net/juju/+bug/1815222 ?

I have the feeling that somewhere the conversion is ending up as a default conversion (eg, whole numbers default to being deserialized as 'int'.) And we're missing a "its ok to put an int into a float" step.

But maybe that has already been fixed according to majduk?

https://bugs.launchpad.net/juju/+bug/1613839 is the bug recently addressing an issue with a float. Given that was in bundle code I'm not sure what overlap with the actions it would be here. This also seems more around the idea of upgrading a charm and changing the type of a property in an action file. Juju isn't liking the change to the type?

This bug has not been updated in 2 years, so we're marking it Low importance. If you believe this is incorrect, please update the importance.