Juniper Openstack

puppet-agent error when Heat Encryption key has all numbers

Bug #1721406 reported by wenqing liang on 2017-10-04

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Juniper Openstack	Status tracked in Trunk
R3.1	Fix Committed	Medium	Nitish Krishna Kaveri	Juniper Openstack r3.1.4.0
R3.2	Fix Committed	Medium	Nitish Krishna Kaveri	Juniper Openstack r3.2.9.0
R3.2.3.x	Fix Committed	Medium	Nitish Krishna Kaveri	Juniper Openstack r3.2.3.3
R4.0	Fix Committed	Medium	Nitish Krishna Kaveri	Juniper Openstack r4.0.3.0
R4.1	Fix Committed	Medium	Nitish Krishna Kaveri	Juniper Openstack r4.1.1.0
Trunk	Fix Committed	Medium	Nitish Krishna Kaveri	Juniper Openstack r5.0.0

Bug Description

provision is stuck at u'openstack':

Oct 4 02:44:23 server3 puppet-agent[23728]: Could not retrieve catalog from remote server: Error 400 on SERVER: size(): Requires either string, array or hash to work with at /etc/puppet/environments/combined_image_mainline/modules/heat/manifests/engine.pp:104 on node server3.englab.juniper.net
Oct 4 02:44:23 server3 puppet-agent[23728]: Not using cache on failed catalog

This error is a rare case where all the characters in heat encryption key are numbers.

Per Nitish, we are randomly generating that string from numbers and A-E for 16 chars and in this case none of those 16 were letters so puppet read it as a int instead of string.

Tags:

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-01-08: [Review update] master

Review in progress for https://review.opencontrail.org/38745
Submitter: Nitish Krishna Kaveri (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-01-08: [Review update] R4.1

Review in progress for https://review.opencontrail.org/38746
Submitter: Nitish Krishna Kaveri (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-01-08: [Review update] R4.0

Review in progress for https://review.opencontrail.org/38747
Submitter: Nitish Krishna Kaveri (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-01-09: [Review update] master

Review in progress for https://review.opencontrail.org/38745
Submitter: Nitish Krishna Kaveri (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-01-10: A change has been merged

Reviewed: https://review.opencontrail.org/38747
Committed: http://github.com/Juniper/contrail-server-manager/commit/278d31f73d8b2b4f5070e1352439cb1e6d016b81
Submitter: Zuul (<email address hidden>)
Branch: R4.0

commit 278d31f73d8b2b4f5070e1352439cb1e6d016b81
Author: nitishkrishna <email address hidden>
Date: Mon Jan 8 15:16:38 2018 -0800

Closes-Bug: #1721406 - Handle edge case where the generated heat encryption key contains only numbers

If all 16 randomly generated characters are numbers, then puppet fails as it expects the value to be a string
Patch:
Use isdigit instead of isinstance()

Change-Id: Icbfb5da24260bc3fbb44536d1890d2b9454cda0f

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-01-10:

#10

Reviewed: https://review.opencontrail.org/38745
Committed: http://github.com/Juniper/contrail-server-manager/commit/cbea0ad2134bfeec16ae705a9a80683c9d732d6d
Submitter: Zuul (<email address hidden>)
Branch: master

commit cbea0ad2134bfeec16ae705a9a80683c9d732d6d
Author: nitishkrishna <email address hidden>
Date: Mon Jan 8 15:16:38 2018 -0800

Closes-Bug: #1721406 - Handle edge case where the generated heat encryption key contains only numbers

If all 16 randomly generated characters are numbers, then puppet fails as it expects the value to be a string
Patch:
Use isdigit instead of isinstance()

Change-Id: Icbfb5da24260bc3fbb44536d1890d2b9454cda0f

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-01-10:

#11

Reviewed: https://review.opencontrail.org/38746
Committed: http://github.com/Juniper/contrail-server-manager/commit/723ee26bd76cd37da55b38d73a73c034871cde90
Submitter: Zuul (<email address hidden>)
Branch: R4.1

commit 723ee26bd76cd37da55b38d73a73c034871cde90
Author: nitishkrishna <email address hidden>
Date: Mon Jan 8 15:16:38 2018 -0800

Closes-Bug: #1721406 - Handle edge case where the generated heat encryption key contains only numbers

If all 16 randomly generated characters are numbers, then puppet fails as it expects the value to be a string
Patch:
Use isdigit instead of isinstance()

Change-Id: Icbfb5da24260bc3fbb44536d1890d2b9454cda0f

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-01-19: [Review update] R3.2

#12

Review in progress for https://review.opencontrail.org/39072
Submitter: Nitish Krishna Kaveri (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-01-19: [Review update] R3.2.3.x

#14

Review in progress for https://review.opencontrail.org/39073
Submitter: Nitish Krishna Kaveri (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-01-19: [Review update] R3.1

#16

Review in progress for https://review.opencontrail.org/39074
Submitter: Nitish Krishna Kaveri (<email address hidden>)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-01-22: A change has been merged

#18

Reviewed: https://review.opencontrail.org/39072
Committed: http://github.com/Juniper/contrail-server-manager/commit/cf8d3353d9dc17e59a3052547fc9e1774a6e146f
Submitter: Zuul (<email address hidden>)
Branch: R3.2

commit cf8d3353d9dc17e59a3052547fc9e1774a6e146f
Author: nitishkrishna <email address hidden>
Date: Mon Jan 8 15:16:38 2018 -0800

Closes-Bug: #1721406 - Handle edge case where the generated heat encryption key contains only numbers

If all 16 randomly generated characters are numbers, then puppet fails as it expects the value to be a string
Patch:
Use isdigit instead of isinstance()

Change-Id: Icbfb5da24260bc3fbb44536d1890d2b9454cda0f
(cherry picked from commit 723ee26bd76cd37da55b38d73a73c034871cde90)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-01-22:

#19

Reviewed: https://review.opencontrail.org/39073
Committed: http://github.com/Juniper/contrail-server-manager/commit/de7c945c71c0f04c39458ba9c3753a760a31e535
Submitter: Zuul (<email address hidden>)
Branch: R3.2.3.x

commit de7c945c71c0f04c39458ba9c3753a760a31e535
Author: nitishkrishna <email address hidden>
Date: Mon Jan 8 15:16:38 2018 -0800

Closes-Bug: #1721406 - Handle edge case where the generated heat encryption key contains only numbers

If all 16 randomly generated characters are numbers, then puppet fails as it expects the value to be a string
Patch:
Use isdigit instead of isinstance()

Change-Id: Icbfb5da24260bc3fbb44536d1890d2b9454cda0f
(cherry picked from commit 723ee26bd76cd37da55b38d73a73c034871cde90)

Revision history for this message

OpenContrail Admin (ci-admin-f) wrote on 2018-01-22:

#20

Reviewed: https://review.opencontrail.org/39074
Committed: http://github.com/Juniper/contrail-server-manager/commit/fdab44295305fcb2f31f2dcab05dc80f5fa9f929
Submitter: Zuul (<email address hidden>)
Branch: R3.1

commit fdab44295305fcb2f31f2dcab05dc80f5fa9f929
Author: nitishkrishna <email address hidden>
Date: Mon Jan 8 15:16:38 2018 -0800

Closes-Bug: #1721406 - Handle edge case where the generated heat encryption key contains only numbers

If all 16 randomly generated characters are numbers, then puppet fails as it expects the value to be a string
Patch:
Use isdigit instead of isinstance()

Change-Id: Icbfb5da24260bc3fbb44536d1890d2b9454cda0f
(cherry picked from commit 723ee26bd76cd37da55b38d73a73c034871cde90)

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.