kayobe overcloud deprovision includes hosts outside of the `overcloud` group in the confirmation prompt

Bug #2091621 reported by Matt Crees
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kayobe
Fix Released
Undecided
Unassigned

Bug Description

Pierre Riteau (priteau)
summary: - kayobe overlcoud deprovision includes hosts outside of the `overcloud`
+ kayobe overcloud deprovision includes hosts outside of the `overcloud`
group in the confirmation prompt
Revision history for this message
Will Szumski (willjs) wrote :

Odd behavior, since the play targets the overcloud group and the behavior is documented as:

List of hosts in the current play run, not limited by the serial. Failed/Unreachable hosts are excluded from this list.

https://docs.ansible.com/ansible/latest/reference_appendices/special_variables.html#term-ansible_play_batch

Is there a simple reproducer?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kayobe (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/kayobe/+/937676

Changed in kayobe:
status: New → In Progress
Revision history for this message
Matt Crees (mattcrees) wrote :

> Is there a simple reproducer?

Yes, you can just run `kayobe overcloud deprovision` from a standard AIO (https://docs.openstack.org/kayobe/latest/contributor/automated.html#contributor-automated) and it'll include extra hosts:

The following hosts will be deprovisioned:
localhost, seed-hypervisor, seed, controller0
If you want to proceed type: yes
 [no]: no

Not sure how I missed this before, I must've not tested without limits at all :/

Revision history for this message
Will Szumski (willjs) wrote :

play_hosts seems to behave differently in vars_prompt than in a normal task. This was surprising behaviour for me, so I made an ansible bug: https://github.com/ansible/ansible/issues/84515.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kayobe (master)

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/937676
Committed: https://opendev.org/openstack/kayobe/commit/f27755aeb2f1bd5a7bae1deabc0df37a6578dc24
Submitter: "Zuul (22348)"
Branch: master

commit f27755aeb2f1bd5a7bae1deabc0df37a6578dc24
Author: Matt Crees <email address hidden>
Date: Fri Dec 13 11:18:12 2024 +0000

    Fix overcloud deprovision hosts list in prompt

    Hosts that weren't part of the overcloud group would be included in the
    list when this is run without a limit.

    Closes-Bug: #2091621
    Change-Id: Id3d68b55e18dfe9c44805b6e2602e00eadecc76a

Changed in kayobe:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kayobe (stable/2024.2)

Fix proposed to branch: stable/2024.2
Review: https://review.opendev.org/c/openstack/kayobe/+/938548

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kayobe (stable/2024.1)

Fix proposed to branch: stable/2024.1
Review: https://review.opendev.org/c/openstack/kayobe/+/938549

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kayobe (stable/2024.2)

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/938548
Committed: https://opendev.org/openstack/kayobe/commit/dfd7ffaafe94360a7aeb5d95af188fd4c9746850
Submitter: "Zuul (22348)"
Branch: stable/2024.2

commit dfd7ffaafe94360a7aeb5d95af188fd4c9746850
Author: Matt Crees <email address hidden>
Date: Fri Dec 13 11:18:12 2024 +0000

    Fix overcloud deprovision hosts list in prompt

    Hosts that weren't part of the overcloud group would be included in the
    list when this is run without a limit.

    Closes-Bug: #2091621
    Change-Id: Id3d68b55e18dfe9c44805b6e2602e00eadecc76a
    (cherry picked from commit f27755aeb2f1bd5a7bae1deabc0df37a6578dc24)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kayobe 17.2.0

This issue was fixed in the openstack/kayobe 17.2.0 Dalmatian release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kayobe (stable/2024.1)

Reviewed: https://review.opendev.org/c/openstack/kayobe/+/938549
Committed: https://opendev.org/openstack/kayobe/commit/89097334567e4ceb7a0f64fac502d539a69e4b71
Submitter: "Zuul (22348)"
Branch: stable/2024.1

commit 89097334567e4ceb7a0f64fac502d539a69e4b71
Author: Matt Crees <email address hidden>
Date: Fri Dec 13 11:18:12 2024 +0000

    Fix overcloud deprovision hosts list in prompt

    Hosts that weren't part of the overcloud group would be included in the
    list when this is run without a limit.

    Closes-Bug: #2091621
    Change-Id: Id3d68b55e18dfe9c44805b6e2602e00eadecc76a
    (cherry picked from commit f27755aeb2f1bd5a7bae1deabc0df37a6578dc24)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.