unity-2d

[panel] Indicator list is hardcoded

Bug #718866 reported by Aurélien Gâteau
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unity-2d
Fix Released
Medium
Panagiotis Skintzos
unity-2d 3.8 "beta"

Bug Description

The indicator applet in unity-2d-panel only shows an hardcoded list of indicators. It should instead load indicators based on the installed indicators (blacklisting the appmenu one which is handled separately)

Aurélien Gâteau (agateau)
Changed in unity-2d:
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → Aurélien Gâteau (agateau)
Florian Boucault (fboucault)
Changed in unity-2d:
milestone: none → 3.8
summary: - Indicator list is hardcoded
+ [panel] Indicator list is hardcoded
Revision history for this message
Panagiotis Skintzos (ph7) wrote :

Hi, I added a patch for this.

Revision history for this message
Florian Boucault (fboucault) wrote :

Great, very useful patch Panagiotis! Aurélien will be reviewing it more in detail shortly before pushing it to trunk.

Revision history for this message
Panagiotis Skintzos (ph7) wrote :

Thanks, it applies cleanly on maverick series.
In natty series, I noticed that the the definitions of indicator dirs have already been taken out of the source code, so not all of the patch parts are really needed.

Comparing with unity (3d), I noticed that there are two names listed (in the sort order list) for network indicator: "libnetwork.so" and "libnetworkmenu.so".
Is that "libnetwork.so" the future "libnetworkmenu.so" renamed? If so perhaps it should be added in unity-2d list as well.

Revision history for this message
Aurélien Gâteau (agateau) wrote :

I just applied your patch after some minor indentation fixes. Thanks a lot Panagiotis!

As for libnetwork.so vs libnetworkmenu.so, here is Neil answer:

  <njpatel> agateau, one is for indicator-network, the other is not useful :)

so libnetwork.so is basically a typo in unity-3d code.

Changed in unity-2d:
status: Triaged → Fix Committed
Florian Boucault (fboucault)
Changed in unity-2d:
assignee: Aurélien Gâteau (agateau) → Panagiotis Skintzos (ph7)
Florian Boucault (fboucault)
Changed in unity-2d:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.