[OSSA-2012-019] token expires time incorrect for auth by one token

Hmm, I thought that was covered by CVE-2012-3426.
Adding Keystone PTL for discussion.

Confirmed for at least UUID tokens in master branch (as of 240d6b41a04f1d24f9bfe36d4da3a57512bb80de). Current master branch requires a slightly different patch than the above due to recent refactoring, but it's a similar one-liner.

Not clear on the history of this issue yet or if PKI tokens are affected.

It does not appear that PKI tokens are affected.

Attached patch for master branch that fixes the issue for UUID tokens and tests for the issue using both UUID & PKI tokens. However, the patch also includes an unrelated bugfix allowing for tokens w/o metadata that I'd specifically like ayoung to review and that we may need to track separately.

Patch attached for stable/folsom.

stable/essex does not appear to be affected.

Attached is a backport of the new tests for stable/essex. No fix is necessary.

Patch(es) look good - approved from me.

Would prefer if the security patch did not include the additional fix (allowing for tokens w/o metadata) -- Minimal is good from a security patching perspective.

ttx: that's specifically why I mentioned it! Attached is just the fix+test for UUID tokens.

Same patch as above for stable/folsom (fix+test for UUID tokens).

@keystone-core: please validate the latest patches
@anndy: do you have a full name (and optionally company) that we can credit for the discovery of this vulnerability ?

Proposed impact description:

Title: Extension of token validity through token chaining
Reporter: $CREDIT
Products: keystone
Affects: Folsom

Description:
$CREDIT reported a vulnerability in token chaining in Keystone. A token expiration date can be circumvented by creating a new token before the old one has expired. An authenticated and authorized user could potentially leverage this vulnerability to extend his access beyond the account owner expectations. Note: this vulnerability was fixed in the past (CVE-2012-3426) but was reintroduced in Folsom when code was refactored to support UUID tokens.

@Thierry: "refactored to support UUID tokens." -> "refactored to support PKI tokens"

I have not confirmed that this is true (although it's likely), but I assume this is what you meant ^

verified good and test drives the explicit patch so we don't regress this area in the future.

@Thierry: just Anndy.

Fixed impact description:

Title: Extension of token validity through token chaining
Reporter: Anndy
Products: Keystone
Affects: Folsom

Description:
Anndy reported a vulnerability in token chaining in Keystone. A token expiration date can be circumvented by creating a new token before the old one has expired. An authenticated and authorized user could potentially leverage this vulnerability to extend his access beyond the account owner expectations. Note: this vulnerability was fixed in the past (CVE-2012-3426) but was reintroduced in Folsom when code was refactored to support PKI tokens.

The description sounds good to me. +1

Pushed to downstream stakeholders

Proposed public disclosure date/time:
*Wednesday November 28th, 1500UTC*

CVE-2012-5563

Fix proposed to branch: stable/folsom
Review: https://review.openstack.org/17049

Fix proposed to branch: stable/folsom
Review: https://review.openstack.org/17050

Reviewed: https://review.openstack.org/17051
Committed: http://github.com/openstack/keystone/commit/38c7e46a640a94da4da89a39a5a1ea9c081f1eb5
Submitter: Jenkins
Branch: master

commit 38c7e46a640a94da4da89a39a5a1ea9c081f1eb5
Author: Dolph Mathews <email address hidden>
Date: Wed Nov 28 10:28:07 2012 -0500

    Ensure token expiration is maintained (bug 1079216)

    Change-Id: I95853ec36e9c4cd937cfac7e08b648e830f9efd0

Reviewed: https://review.openstack.org/17050
Committed: http://github.com/openstack/keystone/commit/f9d4766249a72d8f88d75dcf1575b28dd3496681
Submitter: Jenkins
Branch: stable/folsom

commit f9d4766249a72d8f88d75dcf1575b28dd3496681
Author: Dolph Mathews <email address hidden>
Date: Wed Nov 28 16:28:05 2012 +0100

    Ensure token expiration is maintained

    Ensure token expiration is maintained. Fixes bug 1079216.

    Change-Id: I0ce53f106ab6d95916fdc9797cb9d8bf09132a91

OSSA 2012-019

This was fixed in http://www.ubuntu.com/usn/usn-1641-1/.

Hello anndy, or anyone else affected,

Accepted keystone into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/keystone/2012.2.1-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!