keystoneauth

Add load_from_getter back to loading

Bug #1514339 reported by Jamie Lennox
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
keystoneauth
Fix Released
Wishlist
Jamie Lennox
keystoneauth 2.1.0 "2.1.0"

Bug Description

Keystoneclient plugin loading had a generic load_from_options_getter() function that allowed you to provide a custom function that new how to find options. This was useful for auth_token middleware and os-client-config because they didn't use the straight load_from_conf_options or load_from_argparse_arguments functions.

This wasn't copied into keystoneauth because the loading mechanisms were changed and there hadn't been a use for it yet. We should add it back to enable OCC and auth_token middleware.

Jamie Lennox (jamielennox)
Changed in keystoneauth:
importance: Undecided → Wishlist
OpenStack Infra (hudson-openstack)
Changed in keystoneauth:
assignee: nobody → Jamie Lennox (jamielennox)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystoneauth (master)

Reviewed: https://review.openstack.org/222029
Committed: https://git.openstack.org/cgit/openstack/keystoneauth/commit/?id=6f9cb0462523c2f63df3c3bb7445b3ba7c3a02e0
Submitter: Jenkins
Branch: master

commit 6f9cb0462523c2f63df3c3bb7445b3ba7c3a02e0
Author: Jamie Lennox <email address hidden>
Date: Thu Sep 10 14:14:47 2015 +1000

    Add load_from_options_getter to plugin loading

    Loading from getter function was introduced into keystoneclient as a way
    to enable OCC and auth_token middleware to define more unusual loading
    mechanisms.

    It was skipped in the move to keystoneauth. This adds it back.

    Closes-Bug: #1514339
    Change-Id: I1d464917e0ddec8e13f9395ad75db6ccc53cb813

Changed in keystoneauth:
status: In Progress → Fix Committed
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/keystoneauth 2.0.0

This issue was fixed in openstack/keystoneauth 2.0.0 release.

Davanum Srinivas (DIMS) (dims-v)
Changed in keystoneauth:
milestone: none → 2.1.0
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.