Tests reference stale token formats

Bug #1766954 reported by Lance Bragstad
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
keystonemiddleware
Triaged
Low
Unassigned

Bug Description

If you look through the current keystonemiddleware tests you'll see references to PKI and UUID token formats [0]. While these tests were written when those token formats were supported, it can be confusing to see references to them because it implies there is suppose somewhere for those things.

Instead of referencing implementation details of another service, we could try and generalize those properties and write the test data around those instead. This would prevent us from having to refactor naming in the future if token providers change again. Referencing generalized properties might also be more descriptive as to why ksm cares and tests those cases, instead of having them hide behind terms like "uuid", "pki", or "ferent".

[0] https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/tests/unit/client_fixtures.py#L119-L135

description: updated
Changed in keystonemiddleware:
status: New → Triaged
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.