KiCad

pcbnew: MacOS Shortcut to Close Text Properties

Bug #1838353 reported by Andrey Kuznetsov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Committed
Low
Jeff Young
KiCad 6.0.0-rc1

Bug Description

On Windows v5.1.3 nightly branch I was able to close dialogs by pressing CTRL+ENTER, on macOS in eeschema I am able to do the same, however in pcbnew, when I create a new text and a Text Property dialog opens, I type in the text and press CMD+ENTER, nothing happens. I expect the dialog to close and allow me to place the text on the board.

Can you please check to make sure that CMD+ENTER shortcut to "close" (it's probably calling some default button on the screen which happens to be the OK button) the text properties is working correctly like for other dialogs?

Thanks

Application: kicad
Version: (5.1.2-1)-1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.54.0 LibreSSL/2.6.5 zlib/1.2.11 nghttp2/1.24.1
Platform: Mac OS X (Darwin 18.6.0 x86_64), 64 bit, Little endian, wxMac
Build Info:
    wxWidgets: 3.0.4 (UTF-8,STL containers,compatible with 2.8)
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.54.0
    Compiler: Clang 9.0.0 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=ON
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Tags: pcbnew
Revision history for this message
Michael Kavanagh (michaelkavanagh) wrote :

Shift + Enter is used on macOS.

Changed in kicad:
status: New → Invalid
Revision history for this message
Andrey Kuznetsov (kandrey89) wrote :

Shortcuts should not be different between macOS and windows, nor linux, it just confuses people who use both OSes, like at work and at home, and especially new people who are not familiar with all the shortcuts.

Changed in kicad:
status: Invalid → New
Revision history for this message
Seth Hillbrand (sethh) wrote :

Please do not change the bug status.

Different platforms have different default shortcuts. We follow platform specifications where possible.

Changed in kicad:
status: New → Invalid
Revision history for this message
Jeff Young (jeyjey) wrote :

I concur with Seth's position.

Revision history for this message
Andrey Kuznetsov (kandrey89) wrote :

Why are there so many CLOSE WINDOW shortcut variations?

{Text Properties, Pad Properties, Line Segment Properties, Track & Via Properties,Circle Properties,Arc Properties,Line Segment} is Shift+Enter and Enter (unless a multi-line textbox has focus)

{Footprint Properties, Footprint Text Properties,Dimension Text Properties} is Shift+Enter and CMD+Enter and Enter (unless a table has focus)

For {Copper Zone Properties,Keepout Area Properties} is Enter only.

For {Polygon Properties} I do not know what shortcut is supposed to close it but the above combinations do NOT close it.

What is the reason behind so many different combinations and can they be reduced to just one?

Revision history for this message
Jeff Young (jeyjey) wrote :

I don't think there's any reason; just a cost of open source software development (lots of cooks in the kitchen).

Changed in kicad:
status: Invalid → Triaged
assignee: nobody → Jeff Young (jeyjey)
milestone: none → 6.0.0-rc1
Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision a33d67f6b4d8fcf01cd84c9fe720a743d6ace23b
https://git.launchpad.net/kicad/patch/?id=a33d67f6b4d8fcf01cd84c9fe720a743d6ace23b

Changed in kicad:
status: Triaged → Fix Committed
Jeff Young (jeyjey)
Changed in kicad:
importance: Undecided → Low
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.