kolla-ansible

InfluxDB configuration limits CloudKitty dataframes results to 10,000

Bug #1862358 reported by Pierre Riteau
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
Medium
Pierre Riteau
kolla-ansible 10.0.0 "ussuri"
Stein
Fix Released
Medium
Pierre Riteau
kolla-ansible 8.1.1 "stein"
Train
Fix Released
Medium
Pierre Riteau
kolla-ansible 9.1.0 "Train"
Ussuri
Fix Released
Medium
Pierre Riteau
kolla-ansible 10.0.0 "ussuri"

Bug Description

Kolla Ansible uses a custom InfluxDB configuration setting limiting the number of rows returned by queries:

    max-row-limit = 10000

This used to be the default in old InfluxDB versions, but it was changed in InfluxDB 1.2.2 to 0 (unlimited): https://docs.influxdata.com/influxdb/v1.7/about_the_project/releasenotes-changelog/#v1-2-2-2017-03-14

This setting has an impact on CloudKitty when using its v1 API. GET /v1/storage/dataframes will return only 10000 rows. This may not impact the v2 API which appears to include pagination code, but the v2 API is still experimental.

Regardless of the impact on CloudKitty, consensus on IRC is that using InfluxDB default settings is better anyway.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (master)

Fix proposed to branch: master
Review: https://review.opendev.org/706547

Changed in kolla-ansible:
assignee: nobody → Pierre Riteau (priteau)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/706547
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=fc3492bcb18e74cb76753da46fd4ad0bb098b6bd
Submitter: Zuul
Branch: master

commit fc3492bcb18e74cb76753da46fd4ad0bb098b6bd
Author: Pierre Riteau <email address hidden>
Date: Fri Feb 7 16:41:29 2020 +0100

    Use InfluxDB default [http]/max-row-limit setting

    Since version 1.2.2, InfluxDB uses 0 (unlimited) as default value for
    [http]/max-row-limit [1].

    Using the default value resolves an issue with the CloudKitty v1 API
    returning only 10000 dataframes.

    [1] https://docs.influxdata.com/influxdb/v1.7/about_the_project/releasenotes-changelog/#v1-2-2-2017-03-14

    Change-Id: I6eb8c1216e3a9295b7d8cb7fbcbb8778ae7caf7e
    Closes-Bug: #1862358

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/710870

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/train)

Reviewed: https://review.opendev.org/710870
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=349febd88af09ac217f6025cc946508bd69652bc
Submitter: Zuul
Branch: stable/train

commit 349febd88af09ac217f6025cc946508bd69652bc
Author: Pierre Riteau <email address hidden>
Date: Fri Feb 7 16:41:29 2020 +0100

    Use InfluxDB default [http]/max-row-limit setting

    Since version 1.2.2, InfluxDB uses 0 (unlimited) as default value for
    [http]/max-row-limit [1].

    Using the default value resolves an issue with the CloudKitty v1 API
    returning only 10000 dataframes.

    [1] https://docs.influxdata.com/influxdb/v1.7/about_the_project/releasenotes-changelog/#v1-2-2-2017-03-14

    Change-Id: I6eb8c1216e3a9295b7d8cb7fbcbb8778ae7caf7e
    Closes-Bug: #1862358
    (cherry picked from commit fc3492bcb18e74cb76753da46fd4ad0bb098b6bd)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/710988

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/stein)

Reviewed: https://review.opendev.org/710988
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=b47bd864ed0e5ffd190abd0180cad37f7cfece0d
Submitter: Zuul
Branch: stable/stein

commit b47bd864ed0e5ffd190abd0180cad37f7cfece0d
Author: Pierre Riteau <email address hidden>
Date: Fri Feb 7 16:41:29 2020 +0100

    Use InfluxDB default [http]/max-row-limit setting

    Since version 1.2.2, InfluxDB uses 0 (unlimited) as default value for
    [http]/max-row-limit [1].

    Using the default value resolves an issue with the CloudKitty v1 API
    returning only 10000 dataframes.

    [1] https://docs.influxdata.com/influxdb/v1.7/about_the_project/releasenotes-changelog/#v1-2-2-2017-03-14

    Change-Id: I6eb8c1216e3a9295b7d8cb7fbcbb8778ae7caf7e
    Closes-Bug: #1862358
    (cherry picked from commit fc3492bcb18e74cb76753da46fd4ad0bb098b6bd)
    (cherry picked from commit 349febd88af09ac217f6025cc946508bd69652bc)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/711090

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/rocky)

Reviewed: https://review.opendev.org/711090
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=15806d45d85f930575250f7a5f0f13d6e4b32fdb
Submitter: Zuul
Branch: stable/rocky

commit 15806d45d85f930575250f7a5f0f13d6e4b32fdb
Author: Pierre Riteau <email address hidden>
Date: Fri Feb 7 16:41:29 2020 +0100

    Use InfluxDB default [http]/max-row-limit setting

    Since version 1.2.2, InfluxDB uses 0 (unlimited) as default value for
    [http]/max-row-limit [1].

    Using the default value resolves an issue with the CloudKitty v1 API
    returning only 10000 dataframes.

    [1] https://docs.influxdata.com/influxdb/v1.7/about_the_project/releasenotes-changelog/#v1-2-2-2017-03-14

    Change-Id: I6eb8c1216e3a9295b7d8cb7fbcbb8778ae7caf7e
    Closes-Bug: #1862358
    (cherry picked from commit fc3492bcb18e74cb76753da46fd4ad0bb098b6bd)
    (cherry picked from commit 349febd88af09ac217f6025cc946508bd69652bc)
    (cherry picked from commit b47bd864ed0e5ffd190abd0180cad37f7cfece0d)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 7.2.1

This issue was fixed in the openstack/kolla-ansible 7.2.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.