Custom host field in Nova Compute Ironic

Bug #2056571 reported by Doug Szumski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla-ansible
Status tracked in Dalmatian
Antelope
Fix Committed
Medium
Unassigned
Bobcat
Fix Committed
Medium
Unassigned
Caracal
Fix Committed
Medium
Unassigned
Dalmatian
Fix Released
Medium
Doug Szumski

Bug Description

Customising the host field under the [DEFAULT} section in nova.conf for Nova Compute Ironic breaks the "Waiting for nova-compute services to register themselves" task in the nova-cell role when Ironic is enabled.

For example, provide the following config file:

```
[DEFAULT]
host = ironic
```

Put it here:

/etc/kolla/config/nova/nova-compute-ironic.conf

Make sure Ironic is enabled.

Run:

kayobe overcloud service reconfigure -kt nova

This task never succeeds, even though the Nova Compute Ironic service starts fine.

```
TASK [nova-cell : Waiting for nova-compute services to register themselves] ***********************************************************************************************
FAILED - RETRYING: [doug-aio]: Waiting for nova-compute services to register themselves (20 retries left).
FAILED - RETRYING: [doug-aio]: Waiting for nova-compute services to register themselves (19 retries left).
```

See this spec for why you would want to customise the host name:

https://specs.openstack.org/openstack/nova-specs/specs/2024.1/approved/ironic-shards.html#migrate-from-peer-list-to-single-nova-compute

Note that even for small deployments, not using shards, it is still useful to have a custom host name (to make easier to fail over the Nova Compute Ironic service).

The bug exists because the "Waiting for" task assumes the host field will always be set to <hostname>-ironic.

Doug Szumski (dszumski)
description: updated
Changed in kolla-ansible:
assignee: nobody → Doug Szumski (dszumski)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (master)
Changed in kolla-ansible:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/912483
Committed: https://opendev.org/openstack/kolla-ansible/commit/ac7c1e96e3709785395db275feb83419c13e1c13
Submitter: "Zuul (22348)"
Branch: master

commit ac7c1e96e3709785395db275feb83419c13e1c13
Author: Doug Szumski <email address hidden>
Date: Mon Mar 11 16:48:48 2024 +0000

    Support custom Nova Compute Ironic host names

    This fixes an issue where it is not possible to customise the `host`
    config option in the Nova Compute Ironic config file without breaking
    detection of the service.

    This is a backwards compatible fix, which allows a user to set the
    `host` config option using Ansible host or group vars.

    Other reasons for not using the default host setting of
    `{{ ansible_hostname }}-ironic` are covered in [1].

    [1] https://specs.openstack.org/openstack/nova-specs/specs/2024.1/approved/ironic-shards.html#migrate-from-peer-list-to-shard-key.

    Closes-Bug: #2056571
    Change-Id: I9b562f6a5722f21b7dbec2a4d53a46a57c829155

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/2024.1)

Fix proposed to branch: stable/2024.1
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/925164

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/2023.2)

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/925165

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/925166

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/925166
Committed: https://opendev.org/openstack/kolla-ansible/commit/c2693987a7775060428ddb78b321849fad598bea
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit c2693987a7775060428ddb78b321849fad598bea
Author: Doug Szumski <email address hidden>
Date: Mon Mar 11 16:48:48 2024 +0000

    Support custom Nova Compute Ironic host names

    This fixes an issue where it is not possible to customise the `host`
    config option in the Nova Compute Ironic config file without breaking
    detection of the service.

    This is a backwards compatible fix, which allows a user to set the
    `host` config option using Ansible host or group vars.

    Other reasons for not using the default host setting of
    `{{ ansible_hostname }}-ironic` are covered in [1].

    [1] https://specs.openstack.org/openstack/nova-specs/specs/2024.1/approved/ironic-shards.html#migrate-from-peer-list-to-shard-key.

    Closes-Bug: #2056571
    Change-Id: I9b562f6a5722f21b7dbec2a4d53a46a57c829155
    (cherry picked from commit ac7c1e96e3709785395db275feb83419c13e1c13)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/2024.1)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/925164
Committed: https://opendev.org/openstack/kolla-ansible/commit/0c52bb15b96fb7d64acaaf9717b7e843c5e73839
Submitter: "Zuul (22348)"
Branch: stable/2024.1

commit 0c52bb15b96fb7d64acaaf9717b7e843c5e73839
Author: Doug Szumski <email address hidden>
Date: Mon Mar 11 16:48:48 2024 +0000

    Support custom Nova Compute Ironic host names

    This fixes an issue where it is not possible to customise the `host`
    config option in the Nova Compute Ironic config file without breaking
    detection of the service.

    This is a backwards compatible fix, which allows a user to set the
    `host` config option using Ansible host or group vars.

    Other reasons for not using the default host setting of
    `{{ ansible_hostname }}-ironic` are covered in [1].

    [1] https://specs.openstack.org/openstack/nova-specs/specs/2024.1/approved/ironic-shards.html#migrate-from-peer-list-to-shard-key.

    Closes-Bug: #2056571
    Change-Id: I9b562f6a5722f21b7dbec2a4d53a46a57c829155
    (cherry picked from commit ac7c1e96e3709785395db275feb83419c13e1c13)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/2023.2)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/925165
Committed: https://opendev.org/openstack/kolla-ansible/commit/79532d5986c4a95bcaff10a3a3d6a1b3c78ce13a
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 79532d5986c4a95bcaff10a3a3d6a1b3c78ce13a
Author: Doug Szumski <email address hidden>
Date: Mon Mar 11 16:48:48 2024 +0000

    Support custom Nova Compute Ironic host names

    This fixes an issue where it is not possible to customise the `host`
    config option in the Nova Compute Ironic config file without breaking
    detection of the service.

    This is a backwards compatible fix, which allows a user to set the
    `host` config option using Ansible host or group vars.

    Other reasons for not using the default host setting of
    `{{ ansible_hostname }}-ironic` are covered in [1].

    [1] https://specs.openstack.org/openstack/nova-specs/specs/2024.1/approved/ironic-shards.html#migrate-from-peer-list-to-shard-key.

    Closes-Bug: #2056571
    Change-Id: I9b562f6a5722f21b7dbec2a4d53a46a57c829155
    (cherry picked from commit ac7c1e96e3709785395db275feb83419c13e1c13)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.