kolla-ansible

Deploy failed with absent handler for swift role when kolla_copy_ca_into_containers is true

  1. Series victoria
  2. Bug #1931097
Bug #1931097 reported by Maksim Malchuk
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
Medium
Maksim Malchuk
Ussuri
Fix Committed
Medium
Maksim Malchuk
Victoria
Fix Committed
Medium
Maksim Malchuk
Wallaby
Fix Committed
Medium
Maksim Malchuk
Xena
Fix Released
Medium
Maksim Malchuk

Bug Description

When deploying Swift with kolla_copy_ca_into_containers set to true, the deploy fails with an error:

ERROR! The requested handler 'Restart swift-api container' was not found in either the main handlers list nor in the listening handlers list

This is because the 'swift' role now import the new role 'service-cert-copy' [1] and try to restart [2] the container via absent handler.

1. https://review.opendev.org/c/openstack/kolla-ansible/+/719104/4/ansible/roles/swift/tasks/copy-certs.yml

2. https://review.opendev.org/c/openstack/kolla-ansible/+/713986/22/ansible/roles/service-cert-copy/tasks/main.yml

See original description
OpenStack Infra (hudson-openstack)
Changed in kolla-ansible:
status: New → In Progress
Maksim Malchuk (mmalchuk)
Changed in kolla-ansible:
assignee: nobody → Maksim Malchuk (mmalchuk)
Mark Goddard (mgoddard)
summary: - Deploy failed with absent handler for swift role
+ Deploy failed with absent handler for swift role when
+ kolla_copy_ca_into_containers is true
Changed in kolla-ansible:
importance: Undecided → Medium
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (master)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/795030
Committed: https://opendev.org/openstack/kolla-ansible/commit/5c19f9a5e0fc02ccba52f327c3ea5cedb632788d
Submitter: "Zuul (22348)"
Branch: master

commit 5c19f9a5e0fc02ccba52f327c3ea5cedb632788d
Author: Maksim Malchuk <email address hidden>
Date: Mon Jun 7 10:43:52 2021 +0300

    Add forgotten 'Restart container' handler for swift

    Since I0474324b60a5f792ef5210ab336639edf7a8cd9e swift role uses the new
    service-cert-copy role introduced in the
    I6351147ddaff8b2ae629179a9bc3bae2ebac9519 but the swift role itself
    doesn't contain the handler used in the service-cert-copy. Right now,
    restarting the swift container isn't necessary, but the handler should
    exist. Also we should fix the name of the service used.

    Closes-Bug: #1931097
    Change-Id: I2d0615ce6914e1f875a2647c8a95b86dd17eeb22
    Signed-off-by: Maksim Malchuk <email address hidden>

Changed in kolla-ansible:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/795265

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/795266

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla-ansible (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/kolla-ansible/+/795267

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/795265
Committed: https://opendev.org/openstack/kolla-ansible/commit/98c29107afd5f473d3a3e1051d907b2762a9ec64
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 98c29107afd5f473d3a3e1051d907b2762a9ec64
Author: Maksim Malchuk <email address hidden>
Date: Mon Jun 7 10:43:52 2021 +0300

    Add forgotten 'Restart container' handler for swift

    Since I0474324b60a5f792ef5210ab336639edf7a8cd9e swift role uses the new
    service-cert-copy role introduced in the
    I6351147ddaff8b2ae629179a9bc3bae2ebac9519 but the swift role itself
    doesn't contain the handler used in the service-cert-copy. Right now,
    restarting the swift container isn't necessary, but the handler should
    exist. Also we should fix the name of the service used.

    Closes-Bug: #1931097
    Change-Id: I2d0615ce6914e1f875a2647c8a95b86dd17eeb22
    Signed-off-by: Maksim Malchuk <email address hidden>
    (cherry picked from commit 5c19f9a5e0fc02ccba52f327c3ea5cedb632788d)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/795266
Committed: https://opendev.org/openstack/kolla-ansible/commit/595eec10bad142d330d448d000a2e7d97bae42d9
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 595eec10bad142d330d448d000a2e7d97bae42d9
Author: Maksim Malchuk <email address hidden>
Date: Mon Jun 7 10:43:52 2021 +0300

    Add forgotten 'Restart container' handler for swift

    Since I0474324b60a5f792ef5210ab336639edf7a8cd9e swift role uses the new
    service-cert-copy role introduced in the
    I6351147ddaff8b2ae629179a9bc3bae2ebac9519 but the swift role itself
    doesn't contain the handler used in the service-cert-copy. Right now,
    restarting the swift container isn't necessary, but the handler should
    exist. Also we should fix the name of the service used.

    Closes-Bug: #1931097
    Change-Id: I2d0615ce6914e1f875a2647c8a95b86dd17eeb22
    Signed-off-by: Maksim Malchuk <email address hidden>
    (cherry picked from commit 5c19f9a5e0fc02ccba52f327c3ea5cedb632788d)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/kolla-ansible/+/795267
Committed: https://opendev.org/openstack/kolla-ansible/commit/6110ae4d6896bb66fd132c292385ddb76e49e582
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 6110ae4d6896bb66fd132c292385ddb76e49e582
Author: Maksim Malchuk <email address hidden>
Date: Mon Jun 7 10:43:52 2021 +0300

    Add forgotten 'Restart container' handler for swift

    Since I0474324b60a5f792ef5210ab336639edf7a8cd9e swift role uses the new
    service-cert-copy role introduced in the
    I6351147ddaff8b2ae629179a9bc3bae2ebac9519 but the swift role itself
    doesn't contain the handler used in the service-cert-copy. Right now,
    restarting the swift container isn't necessary, but the handler should
    exist. Also we should fix the name of the service used.

    Closes-Bug: #1931097
    Change-Id: I2d0615ce6914e1f875a2647c8a95b86dd17eeb22
    Signed-off-by: Maksim Malchuk <email address hidden>
    (cherry picked from commit 5c19f9a5e0fc02ccba52f327c3ea5cedb632788d)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 12.0.0.0rc2

This issue was fixed in the openstack/kolla-ansible 12.0.0.0rc2 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 11.1.0

This issue was fixed in the openstack/kolla-ansible 11.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 10.3.0

This issue was fixed in the openstack/kolla-ansible 10.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 13.0.0.0rc1

This issue was fixed in the openstack/kolla-ansible 13.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.