Launchpad itself

TestRunMissingJobs.test_run_missing_ready_does_not_return_results disabled due to spurious failure

Bug #1027103 reported by Deryck Hodge
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
High
Unassigned

Bug Description

I am disabling this test due to spurious failures. It passes locally for me. In buildbot, we see a few runs of:

Traceback (most recent call last):
  File "/srv/buildbot/slaves/launchpad/lucid-devel/build/lib/lp/services/job/tests/test_celeryjob.py", line 87, in test_run_missing_ready_does_not_return_results
    1, len(list_queued(self.RunMissingReady.app, [job_queue_name])))
MismatchError: 1 != 0

Related branches

lp://qastaging/~abentley/launchpad/restore-queue-test
Richard Harding (community): Approve
Diff: 289 lines (+125/-24)
8 files modified
lib/lp/services/config/schema-lazr.conf (+7/-1)
lib/lp/services/job/celeryconfig.py (+5/-1)
lib/lp/services/job/celeryjob.py (+32/-14)
lib/lp/services/job/runner.py (+1/-1)
lib/lp/services/job/tests/celery_helpers.py (+12/-1)
lib/lp/services/job/tests/test_celery_configuration.py (+2/-1)
lib/lp/services/job/tests/test_celeryjob.py (+65/-4)
lib/lp/services/job/tests/test_runner.py (+1/-1)
Revision history for this message
William Grant (wgrant) wrote :

Was there a good reason not to revert the whole revision? AFAICT that's the only test, so we now have possibly bad code with no tests.

Revision history for this message
Deryck Hodge (deryck) wrote :

I don't know if there was a good reason, but there was *a* reason. :)

I don't consider Abel done on this and knew that he was having some isolation issues with that test. So I disabled the test to get buildbot going, filed this bug, and added a card to our Kanban board for him to come back to this first thing his Monday. Also, I knew this wouldn't deploy without QA, knew that the stuff was working locally for him independent of the test, and thought the QA would be valuable to know what state we're in with this change in a production environment, which could happen alongside fixing the test up if I didn't revert everything.

Revision history for this message
William Grant (wgrant) wrote :

The whole revision was reverted after discussion with Abel.

Changed in launchpad:
status: Triaged → Invalid
Aaron Bentley (abentley)
Changed in launchpad:
assignee: nobody → Aaron Bentley (abentley)
status: Invalid → In Progress
Aaron Bentley (abentley)
Changed in launchpad:
status: In Progress → Fix Committed
tags: added: qa-ok
Revision history for this message
William Grant (wgrant) wrote :

Failed on buildbot again. I've reverted it.

Changed in launchpad:
status: Fix Committed → Triaged
William Grant (wgrant)
Changed in launchpad:
assignee: Aaron Bentley (abentley) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.