Accepting multiple identical syncs from unapproved creates SPR with duplicate BPBs
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Triaged
|
Critical
|
Unassigned |
Bug Description
On 2016-03-22, the following packages were all synced from Debian unstable. Since Ubuntu xenial was frozen at that point, the syncs landed in the unapproved queue:
https:/
https:/
https:/
However, because they were queued, somebody else made the same sync request, which was also queued:
[2016-03-22 12:09:40,374: INFO/Worker-3] Running <PlainPackageCo
[2016-03-22 12:09:40,464: DEBUG/Worker-3] Job suspended itself
[2016-03-22 12:09:40,483: INFO/MainProcess] Task lp.services.
[2016-03-22 14:12:24,195: INFO/Worker-1] Running <PlainPackageCo
[2016-03-22 14:12:24,263: DEBUG/Worker-1] Job suspended itself
[2016-03-22 14:12:24,277: INFO/MainProcess] Task lp.services.
These were then accepted in a single "queue accept" command, resulting in a duplicate acceptance:
[2016-03-22 17:36:05,458: INFO/Worker-2] Running <PlainPackageCo
[2016-03-22 17:36:05,872: DEBUG/Worker-2] Created amd64 build of mate-tweak 3.5.8-1 in ubuntu xenial PROPOSED [9386813] in Primary Archive for Ubuntu (3260)
[2016-03-22 17:36:05,924: INFO/Worker-1] Running <PlainPackageCo
[2016-03-22 17:36:06,331: DEBUG/Worker-1] Created amd64 build of mate-tweak 3.5.8-1 in ubuntu xenial PROPOSED [9386814] in Primary Archive for Ubuntu (3260)
[2016-03-22 17:36:06,954: DEBUG/Worker-2] Building recipients list.
[2016-03-22 17:36:06,957: DEBUG/Worker-2] Adding recipient: 'Barry Warsaw <email address hidden>'
[2016-03-22 17:36:07,010: DEBUG/Worker-2] Sent a mail:
[2016-03-22 17:36:07,010: DEBUG/Worker-2] Subject: [ubuntu/
[2016-03-22 17:36:07,011: DEBUG/Worker-2] Sender: Ubuntu Installer <email address hidden>
[2016-03-22 17:36:07,011: DEBUG/Worker-2] Recipients: Barry Warsaw <email address hidden>
[2016-03-22 17:36:07,011: DEBUG/Worker-2] Bcc: Launchpad Archiver <email address hidden>
[...]
[2016-03-22 17:36:07,062: DEBUG/Worker-1] Building recipients list.
[2016-03-22 17:36:07,068: DEBUG/Worker-1] Adding recipient: 'Timo Jyrinki <email address hidden>'
[2016-03-22 17:36:07,144: DEBUG/Worker-1] Sent a mail:
[2016-03-22 17:36:07,145: DEBUG/Worker-1] Subject: [ubuntu/
[2016-03-22 17:36:07,145: DEBUG/Worker-1] Sender: Ubuntu Installer <email address hidden>
[2016-03-22 17:36:07,145: DEBUG/Worker-1] Recipients: Timo Jyrinki <email address hidden>
[2016-03-22 17:36:07,145: DEBUG/Worker-1] Bcc: Launchpad Archiver <email address hidden>
In all three cases, the result involved duplicated builds (even more curiously, in some of those cases both builds were even accepted at the upload stage), and we noticed when it was impossible to copy the results to the release pocket due to a NotOneError in BinaryPackageBu