Launchpad itself

Translator comments are truncated on export time

Bug #1786 reported by Carlos Perelló Marín
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Данило Шеган
Launchpad itself 3.1.11

Bug Description

Here, you can see a messageset with a translator comment that needs more than one line:

https://launchpad.net/distros/ubuntu/breezy/+sources/findutils/+pots/findutils/es/+translate?count=1&offset=16

If you export that .po file, that messageset becomes:

# No ha habido ninguna queja en coreutils, pongamos aquí también los
#: gnulib/lib/quotearg.c:240
msgid "`"
msgstr "«"

and that's broken...

Related branches

lp://qastaging/~danilo/launchpad/bug-1786
Henning Eggers (community): Approve (code)
Diff: 157 lines
3 files modified
lib/lp/translations/doc/potemplate.txt (+8/-0)
lib/lp/translations/utilities/gettext_po_exporter.py (+14/-4)
lib/lp/translations/utilities/tests/test_gettext_po_exporter.py (+42/-0)
Carlos Perelló Marín (carlos)
Changed in rosetta:
status: New → Accepted
Revision history for this message
Dafydd Harries (daf) wrote :

I've just reproduced this, so the bug is still there. Writing a test case would be a good first step in fixing this.

Revision history for this message
Данило Шеган (danilo) wrote :

Tested this one with a long three-line comment, and seems to have been fix some time ago, but at least with RF 5199.

Changed in rosetta:
assignee: nobody → danilo
milestone: none → 1.1.11
status: Confirmed → Fix Committed
Данило Шеган (danilo)
Changed in rosetta:
status: Fix Committed → Fix Released
Revision history for this message
Carlos Perelló Marín (carlos) wrote :

The problem seems to be that the imported comment includes the new line char, when it shouldn't.

We should check first that imports stop doing that and we remove all new lines when storing the comments and then, check that the export is correct.

For reference, Spanish translation for POTMsgSet.id == 663834 in our database is the one that has this problem.

Moved back to confirmed to do more debugging work.

Changed in rosetta:
milestone: 1.1.11 → none
status: Fix Released → Confirmed
Revision history for this message
Данило Шеган (danilo) wrote :

Let me add to this remark above: I tested this specific case, but I probably didn't test a POT, but rather a PO import. Will check further and then either confirm or close this bug.

Данило Шеган (danilo)
Changed in rosetta:
assignee: danilo → nobody
Данило Шеган (danilo)
Changed in rosetta:
importance: Medium → Low
status: Triaged → In Progress
assignee: nobody → Данило Шеган (danilo)
Revision history for this message
Ursula Junque (ursinha) wrote : A commit mentioned this bug

This bug was mentioned in stable r9852 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/9852>

Changed in rosetta:
status: In Progress → Fix Committed
tags: added: qa-needstesting
Ursula Junque (ursinha)
Changed in rosetta:
milestone: none → 3.1.11
Данило Шеган (danilo)
tags: added: qa-ok
removed: qa-needstesting
Данило Шеган (danilo)
Changed in rosetta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.