Launchpad itself

Patch checkbox caption is silly on bug attachment page

Bug #182282 reported by Matthew Paul Thomas
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Undecided
Abel Deuring

Bug Description

A bug attachment page, such as <https://bugs.edge.launchpad.net/ubuntu/+source/wmaker/+bug/174252/attachments/188403>, includes a checkbox for whether the attachment is a patch, with both a label and a caption:
    [ ] Patch
    Check this box if the attachment is a patch.

This is silly. It should have just a label:
    [ ] This attachment is a patch

It may save time to fix this bug at the same time as bug 182289.

See original description
Matthew Paul Thomas (mpt)
description: updated
Björn Tillenius (bjornt)
Changed in malone:
status: New → Fix Released
status: Fix Released → Confirmed
Björn Tillenius (bjornt)
Changed in malone:
milestone: none → 1.2.4
Björn Tillenius (bjornt)
Changed in malone:
assignee: nobody → adeuring
Abel Deuring (adeuring)
Changed in malone:
status: Confirmed → In Progress
Abel Deuring (adeuring)
Changed in malone:
status: In Progress → Fix Committed
Revision history for this message
Eleanor Berger (intellectronica) wrote :

RF 6051

Revision history for this message
Eleanor Berger (intellectronica) wrote :

This is OK now, but I think the layout is a bit awkward, because the spacing between the first field and the second field (the patch checkbox) is greater than the spacing between the second and third field, making them look related. Not sure if this should be fixed now.

Revision history for this message
Eleanor Berger (intellectronica) wrote :

b.t.w my apologies - i reviewed this branch and should have noticed it then sorry!

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

This is primarily because of the word "(Optional)". It makes the label cell taller, which makes the gap between the text field and the checkbox greater.

"(Optional)" looks wrong in its current position anyway, so I think the best fix is to move "(Optional)" to the right of all single-line text fields to which it applies in Launchpad. (For multi-line fields, it should stay where it is.)

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

I'm sorry, I thought this was about the main bug report page, which has the same checkbox.

I've cited the attachment page as an example for bug 132987.

Abel Deuring (adeuring)
Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.