product series code tab goes to product overview rather than series specific page
Bug #183433 reported by
Tim Penhey
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
William Grant | ||
Bug Description
As part of the new page shown on the code root site for products, I specified a navigation target for product series on the code rootsite to go to the code overview page for the product that the series is attached to.
In hindsight I think that the Code tab for a product series should only be enabled if the product series specifies an associated branch, and if it does, the code tab should issue a redirect to the actual branch url.
Related branches
lp://qastaging/~wgrant/launchpad/series-breadcrumbs-later
- William Grant (community): Approve (code)
-
Diff: 1004 lines (+171/-168)37 files modifiedlib/canonical/launchpad/icing/css/layout.css (+8/-3)
lib/lp/app/browser/launchpad.py (+21/-12)
lib/lp/app/browser/tales.py (+10/-7)
lib/lp/app/templates/base-layout.pt (+2/-2)
lib/lp/blueprints/stories/standalone/xx-overview.txt (+4/-8)
lib/lp/bugs/stories/bugs/xx-bugs.txt (+1/-1)
lib/lp/bugs/stories/bugs/xx-distrorelease-bugs-page.txt (+1/-1)
lib/lp/bugs/stories/patches-view/patches-view.txt (+1/-1)
lib/lp/code/stories/branches/xx-distroseries-branches.txt (+0/-7)
lib/lp/registry/browser/distroseries.py (+1/-6)
lib/lp/registry/browser/productseries.py (+0/-2)
lib/lp/registry/browser/sourcepackage.py (+7/-8)
lib/lp/registry/stories/distroseries/xx-distroseries-index.txt (+2/-2)
lib/lp/registry/stories/productseries/xx-productseries-add-and-edit.txt (+1/-1)
lib/lp/services/webapp/breadcrumb.py (+4/-4)
lib/lp/services/webapp/doc/menus.txt (+1/-0)
lib/lp/services/webapp/tests/test_breadcrumbs.py (+4/-3)
lib/lp/soyuz/stories/packaging/package-pages-navigation.txt (+31/-34)
lib/lp/soyuz/stories/soyuz/xx-builds-pages.txt (+1/-1)
lib/lp/soyuz/stories/soyuz/xx-distroseries-sources.txt (+1/-1)
lib/lp/soyuz/stories/soyuz/xx-person-packages.txt (+1/-1)
lib/lp/soyuz/stories/soyuz/xx-sourcepackage-changelog.txt (+6/-6)
lib/lp/translations/browser/tests/test_breadcrumbs.py (+12/-6)
lib/lp/translations/stories/importqueue/xx-entry-details.txt (+1/-1)
lib/lp/translations/stories/navigation-links/pofile.txt (+12/-12)
lib/lp/translations/stories/navigation-links/pomsgset.txt (+10/-10)
lib/lp/translations/stories/navigation-links/potemplate.txt (+12/-12)
lib/lp/translations/stories/productseries/xx-productseries-translation-export.txt (+1/-1)
lib/lp/translations/stories/productseries/xx-productseries-translations.txt (+1/-1)
lib/lp/translations/stories/standalone/xx-licensing.txt (+2/-2)
lib/lp/translations/stories/standalone/xx-pofile-export.txt (+2/-2)
lib/lp/translations/stories/standalone/xx-pofile-translate-message-filtering.txt (+4/-4)
lib/lp/translations/stories/standalone/xx-potemplate-index.txt (+2/-2)
lib/lp/translations/stories/standalone/xx-product-export.txt (+1/-1)
lib/lp/translations/stories/standalone/xx-rosetta-sourcepackage-list.txt (+1/-1)
lib/lp/translations/stories/standalone/xx-serieslanguage-index.txt (+1/-1)
lib/lp/translations/stories/standalone/xx-sourcepackage-export.txt (+1/-1)
Revision history for this message
| Jonathan Lange (jml) wrote | #1 |
| Changed in launchpad-bazaar: | |
| assignee: | nobody → thumper |
| importance: | Undecided → Low |
| status: | New → Triaged |
| Changed in launchpad-bazaar: | |
| assignee: | thumper → nobody |
| visibility: | private → public |
| summary: |
- Incorrect navigation for product series on the code rootsite + product series code tab goes to product overview rather than series + specific page |
| Changed in launchpad: | |
| assignee: | nobody → William Grant (wgrant) |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Hey Tim,
I've taken a guess at priority, but it looks like you know what you mean here.
jml