removeCopyNotification errors are all reported as ServerErrors
Bug #1993523 reported by
Andy Whitcroft
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
In Progress
|
Low
|
Andy Whitcroft | ||
Bug Description
removeCopyNotif
Related branches
~apw/launchpad:archive-removeCopyNotification-fixes
- Colin Watson (community): Needs Fixing
-
Diff: 34 lines (+3/-2)2 files modifiedlib/lp/soyuz/model/archive.py (+2/-1)
lib/lp/soyuz/model/packagecopyjob.py (+1/-1)
Revision history for this message
| Andy Whitcroft (apw) wrote | #1 |
| tags: | added: api lp-soyuz |
| Changed in launchpad: | |
| status: | New → In Progress |
| importance: | Undecided → Low |
| assignee: | nobody → Andy Whitcroft (apw) |
To post a comment you must log in.
Proposing the attached branch as fixes for this. This returns NotFound for job_ids which do not exist and Gone for job_ids we have already acknowledged.
Note for reviewers: I have very scant understanding of which errors are correctly mapped to client return codes and which are valid for same so do check I am throwing sane exceptions there.