Launchpad itself

Redundant "Upstream links" pages for each source package in each distribution series

Bug #204121 reported by Matthew Paul Thomas
4
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Unassigned
Launchpad itself 3.1.12

Bug Description

The page for a distribution source package displays its upstream links, and lets you update them.
<https://launchpad.net/ubuntu/+source/warzone2100>

But every distribution series, regardless of whether the package was published in that series, has its own "Upstream links" page for that package. These pages are near-identical to each other, all of them linking to *all* the distribution series, not just the current context series. And all of them are missing the edit/delete functions found on the distribution source package page.
<https://launchpad.net/ubuntu/warty/+source/warzone2100/+packaging>
<https://launchpad.net/ubuntu/hoary/+source/warzone2100/+packaging>
<https://launchpad.net/ubuntu/breezy/+source/warzone2100/+packaging>
<https://launchpad.net/ubuntu/dapper/+source/warzone2100/+packaging>
<https://launchpad.net/ubuntu/edgy/+source/warzone2100/+packaging>
<https://launchpad.net/ubuntu/feisty/+source/warzone2100/+packaging>
<https://launchpad.net/ubuntu/gutsy/+source/warzone2100/+packaging>
<https://launchpad.net/ubuntu/hardy/+source/warzone2100/+packaging>
Bongalicious!

I suggest abolishing the distribution series source package upstream links page. Instead, make the upstream link directly editable from the distribution series source package page, if (bug 204119) the package was published in that series at all; and link to the Upstream links fragment of the distribution source package page with text something like "(and _3 links in other Ubuntu series_)" to let people update links in other series if they want to.

[Originally discovered by Dennis Schridde in bug 4556.]

See original description

Related branches

lp://qastaging/~sinzui/launchpad/remove-sp-packaging-bug-272343
Paul Hummer (community): Approve
Diff: 605 lines (+134/-280)
12 files modified
lib/canonical/launchpad/pagetests/basics/notfound-traversals.txt (+0/-1)
lib/lp/answers/templates/question-portlet-details.pt (+4/-4)
lib/lp/registry/browser/configure.zcml (+0/-7)
lib/lp/registry/browser/sourcepackage.py (+1/-14)
lib/lp/registry/interfaces/person.py (+6/-6)
lib/lp/registry/stories/packaging/xx-sourcepackage-packaging.txt (+50/-127)
lib/lp/registry/templates/distroseries-index.pt (+1/-3)
lib/lp/registry/templates/distroseries-packaging.pt (+36/-31)
lib/lp/registry/templates/sourcepackage-index.pt (+27/-21)
lib/lp/registry/templates/sourcepackage-packaging.pt (+0/-62)
lib/lp/soyuz/stories/soyuz/xx-distroseries-index.txt (+2/-2)
lib/lp/soyuz/templates/distroseries-portlet-latestuploads.pt (+7/-2)
Matthew Paul Thomas (mpt)
description: updated
Matthew Paul Thomas (mpt)
description: updated
Francis J. Lacoste (flacoste)
Changed in launchpad-foundations:
importance: Undecided → Medium
status: New → Triaged
Curtis Hovey (sinzui)
affects: launchpad-foundations → launchpad-registry
Changed in launchpad-registry:
importance: Medium → Low
Curtis Hovey (sinzui)
summary: - Redundant (and Delete-less) "Upstream links" pages for a source package
- in every distribution series
+ Redundant "Upstream links" pages for each source package in each
+ distribution series
Curtis Hovey (sinzui)
Changed in launchpad-registry:
milestone: none → 3.1.12
Curtis Hovey (sinzui)
Changed in launchpad-registry:
importance: Low → High
Revision history for this message
Curtis Hovey (sinzui) wrote :

The Update SP "Show upstream links" link in the Upstream associations to go the the project's +packages page.
Update the distroseries +packaging page to link to the project's +packages page

Remove
./lib/canonical/launchpad/pagetests/basics/notfound-traversals.txt
     194: >>> check("/ubuntu/hoary/+source/evolution/+packaging")

./lib/lp/registry/templates/distroseries-packaging.pt
      28: tal:attributes="href string:${sp/fmt:url}/+packaging">evolution</a>
      49: string:${packaging/sourcepackage/fmt:url}/+packaging"

./lib/lp/registry/stories/packaging/xx-sourcepackage-packaging.txt
       4: package's +packaging page:
       7: ... "http://launchpad.dev/ubuntu/warty/+source/mozilla/+packaging")
      40: ... "http://launchpad.dev/ubuntu/grumpy/+source/mozilla/+packaging")
      57: ... "http://launchpad.dev/ubuntu/warty/+source/mozilla/+packaging")
      81: ... "http://launchpad.dev/ubuntu/warty/+source/mozilla/+packaging")
     109: ... "http://launchpad.dev/ubuntu/grumpy/+source/mozilla/+packaging")

./lib/lp/registry/browser/configure.zcml
    2010: name="+packaging"

./lib/lp/registry/browser/sourcepackage.py
     110: return Link('+packaging', 'Show upstream links', icon='info')

Curtis Hovey (sinzui)
Changed in launchpad-registry:
assignee: nobody → Curtis Hovey (sinzui)
status: Triaged → In Progress
Revision history for this message
Curtis Hovey (sinzui) wrote :

Fixed in launchpad devel r9970.

Changed in launchpad-registry:
status: In Progress → Fix Committed
Revision history for this message
Curtis Hovey (sinzui) wrote : Bug 204121 Fix released

Fixed released in launchpad-project 3.1.12.

Changed in launchpad-registry:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
Changed in launchpad:
assignee: Curtis Hovey (sinzui) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.