Launchpad itself

'queue override' command scales at O(n^2) with the number of packages on the commandline

Bug #241129 reported by Steve Langasek
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
William Grant
Launchpad itself 10.08

Bug Description

When passing more than one package name to 'queue override' on the commandline, it appears that the override is executed on *all* packages, one time for *each* package listed in the command.

For instance, in the simple case of overriding two binary packages, the output looks like:

$ q -s dapper-security -Q new override -c main binary acpi-modules-2.6.15-52-386-di acpi-modules-2.6.15-52-amd64-generic-di
Initialising connection to queue new
Running: "override binary acpi-modules-2.6.15-52-386-di acpi-modules-2.6.15-52-amd64-generic-di"
Overriding ubuntu/dapper-security (NEW) 2/3
---------------------------------------------------------------------------
Overriding acpi-modules-2.6.15-52-amd64-generic-di_2.6.15-52.67 (main/debian-installer/EXTRA)
         | * linux-source-2.6.15/2.6.15-52.67 Component: main Section: devel
         | N acpi-modules-2.6.15-52-amd64-generic-di/2.6.15-52.67/amd64 Component: main Section: debian-installer Priority: EXTRA
Overriding acpi-modules-2.6.15-52-386-di_2.6.15-52.67 (main/debian-installer/EXTRA)
         | * linux-source-2.6.15/2.6.15-52.67 Component: main Section: devel
         | N acpi-modules-2.6.15-52-386-di/2.6.15-52.67/i386 Component: main Section: debian-installer Priority: EXTRA
Overriding acpi-modules-2.6.15-52-amd64-generic-di_2.6.15-52.67 (main/debian-installer/EXTRA)
         | * linux-source-2.6.15/2.6.15-52.67 Component: main Section: devel
         | N acpi-modules-2.6.15-52-amd64-generic-di/2.6.15-52.67/amd64 Component: main Section: debian-installer Priority: EXTRA
Overriding acpi-modules-2.6.15-52-386-di_2.6.15-52.67 (main/debian-installer/EXTRA)
         | * linux-source-2.6.15/2.6.15-52.67 Component: main Section: devel
         | N acpi-modules-2.6.15-52-386-di/2.6.15-52.67/i386 Component: main Section: debian-installer Priority: EXTRA
$

For packages such as the kernel which create literally hundreds of binary packages that need overrides when there's an ABI change, it of course makes it very inefficient to batch these up on a single commandline when this means a hundredfold speed penalty, whereas it would otherwise be quite nice to not have to spawn a separate subprocess (and db connection) for each package override...

Related branches

lp://qastaging/~wgrant/launchpad/bug-241129-queue-binary-scaling
Māris Fogels (community): Approve (code)
Diff: 82 lines (+16/-3)
2 files modified
lib/lp/soyuz/scripts/queue.py (+7/-2)
lib/lp/soyuz/scripts/tests/test_queue.py (+9/-1)
Revision history for this message
Julian Edwards (julian-edwards) wrote :

Steve, can you try the override web interface instead at
https://launchpad.net/ubuntu/dapper/+queue

It *may* be quicker until we fix this bug.

Thanks.

Revision history for this message
Steve Langasek (vorlon) wrote : Re: [Bug 241129] Re: 'queue override' command scales at O(n^2) with the number of packages on the commandline

On Thu, Jun 19, 2008 at 09:54:07AM -0000, Julian Edwards wrote:
> Steve, can you try the override web interface instead at
> https://launchpad.net/ubuntu/dapper/+queue

I'm afraid I don't see in here (actually
https://launchpad.net/ubuntu/intrepid/+queue, since the dapper queue is now
empty :-) where I can set per-binary overrides. That's really the
interesting use case anyway, since kernel ABI changes are the most
complicated overrides we do and we specifically need to override different
binaries from the same source package to different components.

--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
<email address hidden> <email address hidden>

Revision history for this message
Julian Edwards (julian-edwards) wrote :

Steve

You can override on that page if you're in the ubuntu-archive team, which I see you are.

Changed in soyuz:
status: New → Triaged
importance: Undecided → Medium
tags: added: soyuz-ftpmaster-tools
Revision history for this message
Steve Langasek (vorlon) wrote :

That page permits setting overrides on a *per-upload* basis. It doesn't let you set overrides on a *per-binary* basis, which is sometimes needed.

Revision history for this message
Julian Edwards (julian-edwards) wrote :

Ah gotcha, didn't pick up on that nuance :)

William Grant (wgrant)
Changed in soyuz:
assignee: nobody → William Grant (wgrant)
status: Triaged → In Progress
Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit

Fixed in stable r11296 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11296>.

tags: added: qa-needstesting
Ursula Junque (ursinha)
Changed in soyuz:
status: In Progress → Fix Committed
milestone: none → 10.08
William Grant (wgrant)
Changed in soyuz:
status: Fix Committed → Fix Released
Revision history for this message
Colin Watson (cjwatson) wrote :

Confirmed, and I've adapted our kernel-overrides script accordingly. Thanks!

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.