"Review proposal" allows reviewer to edit the original proposal instead of adding review comments.
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Medium
|
Tim Penhey |
Bug Description
The "Review proposal" link, in the left navigation bar of the "Proposal to merge branch" page
(below), leads to an unexpected action and result.
https:/
In the workflow we're used to, providing a review is actually adding a comment to the branch,
and voting +1/-1 etc. Instead of adding a comment, the mentioned link will actually open the
*whiteboard* of the proposal, including the original text the proposing user entered to request
the proposal.
The original poster should have a text field (description, whiteboard, whatever) for him to defend
the merging of the proposed branch, and this should not be the same place the review is
performed. It's pretty much the same as e.g. the workflow of a bug. When you want to mark a
bug as fixed, invalid, etc, you don't change the description the original poster provided. Instead,
you add a comment to it.
Changed in launchpad: | |
assignee: | nobody → thumper |
Changed in launchpad-bazaar: | |
status: | New → Confirmed |
Changed in launchpad-bazaar: | |
status: | Fix Committed → Fix Released |
Fixed in RF 7195.
Reworked the workflow so this doesn't happen any more.