"Review proposal" allows reviewer to edit the original proposal instead of adding review comments.

Bug #242637 reported by Gustavo Niemeyer
2
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Tim Penhey

Bug Description

The "Review proposal" link, in the left navigation bar of the "Proposal to merge branch" page
(below), leads to an unexpected action and result.

  https://code.launchpad.net/~jamesh/storm/sqlobject-contains/+merge/426

In the workflow we're used to, providing a review is actually adding a comment to the branch,
and voting +1/-1 etc. Instead of adding a comment, the mentioned link will actually open the
*whiteboard* of the proposal, including the original text the proposing user entered to request
the proposal.

The original poster should have a text field (description, whiteboard, whatever) for him to defend
the merging of the proposed branch, and this should not be the same place the review is
performed. It's pretty much the same as e.g. the workflow of a bug. When you want to mark a
bug as fixed, invalid, etc, you don't change the description the original poster provided. Instead,
you add a comment to it.

Changed in launchpad:
assignee: nobody → thumper
Changed in launchpad-bazaar:
status: New → Confirmed
Revision history for this message
Tim Penhey (thumper) wrote :

Fixed in RF 7195.

Reworked the workflow so this doesn't happen any more.

Changed in launchpad-bazaar:
importance: Undecided → Medium
milestone: none → 2.1.11
status: Confirmed → Fix Committed
Tim Penhey (thumper)
Changed in launchpad-bazaar:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.