Launchpad itself

Make the +filebug duplicate list load asynchronously

Bug #358510 reported by Graham Binns
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Graham Binns
Launchpad itself 3.1.12

Bug Description

At the moment the list of duplicates on the +filebug page is loaded with the rest of the page. For large projects or distros this can take a long time depending on the summary that's been entered. We should load the list asynchronously using Javascript.

Related branches

lp://qastaging/~gmb/launchpad/prince-of-ajax-dupefinding-bug-358510
Michael Nelson (community): Approve (code js)
Canonical Launchpad Engineering: Pending (code) requested
Diff: 477 lines (+247/-135)
3 files modified
lib/canonical/launchpad/javascript/bugs/filebug-dupefinder.js (+242/-133)
lib/canonical/launchpad/templates/launchpad-form.pt (+2/-1)
lib/lp/bugs/templates/bugtarget-filebug-submit-bug.pt (+3/-1)
lp://qastaging/~gmb/launchpad/ajax-dupefinder-has-risen-from-the-grave
Edwin Grubbs (community): Abstain (code)
Gavin Panella (community): Approve (code js)
Michael Nelson (community): Approve (ui)
Diff: 838 lines (+351/-135)
10 files modified
lib/canonical/launchpad/javascript/bugs/filebug-dupefinder.js (+71/-57)
lib/lp/bugs/browser/bugtarget.py (+58/-20)
lib/lp/bugs/browser/configure.zcml (+7/-0)
lib/lp/bugs/browser/tests/bugtarget-filebug-views.txt (+19/-0)
lib/lp/bugs/interfaces/bug.py (+9/-2)
lib/lp/bugs/templates/bugtarget-filebug-inline-form.pt (+11/-0)
lib/lp/bugs/templates/bugtarget-filebug-search.pt (+103/-33)
lib/lp/bugs/templates/bugtarget-filebug-show-similar.pt (+7/-2)
lib/lp/bugs/templates/bugtarget-filebug-submit-bug.pt (+2/-2)
lib/lp/bugs/templates/bugtarget-macros-filebug.pt (+64/-19)
Graham Binns (gmb)
Changed in malone:
importance: Undecided → High
milestone: none → 2.2.4
status: New → Triaged
Björn Tillenius (bjornt)
Changed in malone:
milestone: 2.2.4 → 2.2.5
Björn Tillenius (bjornt)
Changed in malone:
milestone: 2.2.5 → 2.2.6
Revision history for this message
Graham Binns (gmb) wrote :

This has actually been in progress for some time.

Changed in malone:
status: Triaged → In Progress
Graham Binns (gmb)
Changed in malone:
assignee: nobody → Graham Binns (gmb)
Graham Binns (gmb)
Changed in malone:
milestone: 2.2.6 → 2.2.7
Graham Binns (gmb)
Changed in malone:
milestone: 2.2.7 → 2.2.8
Deryck Hodge (deryck)
Changed in malone:
milestone: 2.2.8 → 3.1.10
Revision history for this message
Graham Binns (gmb) wrote :

Although this is mostly done it won't land for 3.1.10, so I'm moving it to the next milestone.

Changed in malone:
milestone: 3.1.10 → 3.1.11
Graham Binns (gmb)
Changed in malone:
milestone: 3.1.11 → 3.1.12
Revision history for this message
komputes (komputes) wrote :

Hi Graham,

It seems this bug has been pushed for future fixing since 2.2.4. Is there a chance we may actually test this out on edge any time soon?

Revision history for this message
Graham Binns (gmb) wrote : Re: [Bug 358510] Re: Make the +filebug duplicate list load asynchronously

2009/11/29 komputes <email address hidden>:
> Hi Graham,
>
> It seems this bug has been pushed for future fixing since 2.2.4. Is
> there a chance we may actually test this out on edge any time soon?
>

Yes. It's been pushed for various reasons, mostly because it's
actually a huge change that has to land pretty much all at once, and
actually getting it finished and - here's the hard bit - with a good
UI - means that it keeps getting pushed back (i.e. it works, but it's
not pretty, and I can't land that the Friday before release week).

This should, assuming that I don't do something stupid, land on edge
next week (w.b. 7th December).

Revision history for this message
Graham Binns (gmb) wrote :

I've linked my ajax-dupefinder-has-risen-from-the-grave branch, which is the cumulative branch for all this work, to the bug. Feel free to grab it and see why I didn't land it this cycle ;).

Revision history for this message
Diogo Matsubara (matsubara) wrote : Bug fixed by a commit

Fixed in devel r10017 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/devel/revision/10017>

Changed in malone:
status: In Progress → Fix Committed
Deryck Hodge (deryck)
Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.