Launchpad itself

inline editing for reviews please

Bug #373038 reported by Robert Collins
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Aaron Bentley
Launchpad itself 3.1.11

Bug Description

Currently when you do a review, you have to have opened the
merge-proposal page separately to be able to examine it while reviewing.

It would be great to do what the bug pages do and have doing a review be
inline on the merge proposal page, so that you can refer to existing
discussion and the merge content itself in your review.

Related to that would be including the diff by default with herringbone
markers, like a mail-reply.

 affects launchpad-code

Revision history for this message
Martin Albisetti (beuno) wrote :

This should be pretty easy in a week or so, when the multi-line editing widget and the status picker land on the bug page. Maybe for late 2.2.5? should be doable in 2.2.6 for sure :)

Revision history for this message
Paul Hummer (rockstar) wrote :

Martin Albisetti and I have talked about doing this. It's not on the top of our priorities, but it's still up in the javascript stack.

Changed in launchpad-code:
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Robert Collins (lifeless) wrote : Re: [Bug 373038] Re: inline editing for reviews please

On Fri, 2009-05-08 at 21:19 +0000, Paul Hummer wrote:
> Martin Albisetti and I have talked about doing this. It's not on the
> top of our priorities, but it's still up in the javascript stack.

Cool, and thanks.

I'm a little confused though - the bug pages don't use javascript/ajax
do they? its just a little form thats hidden when the bug page is show
and a > expander shows it.

-Rob

Aaron Bentley (abentley)
tags: added: code-review
Changed in launchpad-code:
status: Triaged → Fix Committed
Tim Penhey (thumper)
Changed in launchpad-code:
assignee: nobody → Aaron Bentley (abentley)
milestone: none → 3.1.11
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.