attachment removal and public transition in same e-mail

A simple fix for this issue would be to not generate notifications for attachment removals on private bugs. That's not necessarily The Right Thing but it solves the problem until we can produce a better, security-aware notification system.

The librarian URL for the deleted attachment also appears in the
activity log, so we must ignore all attachment changes in private
bugs. Unfortunately, this also reduces the usefulness of private bugs.

Perhaps a different solution here is to make sure the librarian either
deletes or denies access for deleted files? A new "purge" mechanism
could be added to the librarian (if one doesn't already exist) for
this use case.

Bug 181365 is likely a duplicate of this one or vice versa.

I'll add an apport task to wait at least 5 minutes before making these bugs public, as a workaround.

But in general, I have the feeling that Launchpad just became waaaaaay to chatty with bug mail. Nowadays we get tons of useless mails about "attachment removed", "branch linked", "bug #234 marked as duplicate of this", "translation imported", etc., none of which is really relevant. From my POV, only state changes, new attachments, and comments are interesting; if comment mails are _augmented_ with additional data, such as "branch linked" or "attachment removed", that's fine, but having these as single mails, they are pretty much useless anyway (and in practice, the useful ones are accompanied by comments). So as a longer-term goal, I wish that we could review this.

With regards to Launchpad being too chatty I tend to agree. However, with regards to linking branches - one is not prompted to add a comment when linking a branch so I think it is easy for people to over look adding one. Additionally, when this is combined with the inability to search for bugs with branches I think we run into a situation where it becomes quite easy to miss these low hanging fruit. So ideally one should be prompted to also add a comment when adding a branch if the notification were to be removed.

Hello,

Brian Murray [2009-07-15 19:10 -0000]:
> With regards to Launchpad being too chatty I tend to agree. However,
> with regards to linking branches - one is not prompted to add a comment
> when linking a branch

Right, since it doesn't even happen in the web UI. If you use --fixes
lp:xxxxx (or debcommit), then the branch is automatically linked to
the branch, without any manual activity. However, you are still urged
to set the bug to "fix committed" once the branch is actually ready,
etc.

Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)