Truncated links in Launchpad mailing lists automatic messages

The branch I've linked doesn't fix the bug, but it demonstrates the problem. It turns out that textwrap (the Python module) will wrap lines at hyphens, even if those hyphens occur within URLs.

To run the unit test:
    ./bin/test -cvv lp.services.mail.tests.test_mailwrapper

If you like waiting for doctests:
    ./bin/test -1cvvt textformatting

It might be that the cheapest fix for this is to change the URL from +mailinglist-moderate to something without hyphens.

For reference:
  * template in lib/canonical/launchpad/emailtemplates/new-held-message.txt
  * mail handler in canonical.launchpad.mailnotification.notify_message_held
  * If you want to change the template text, you will have to edit:
    * lib/lp/registry/doc/message-holds-xmlrpc.txt
    * lib/lp/registry/doc/message-holds.txt
    * lib/lp/services/mailman/doc/postings.txt
  * If you want to change the URL, you'll have to edit:
    * lib/lp/registry/browser/configure.zcml
    * lib/lp/registry/browser/person.py
    * lib/lp/registry/stories/mailinglists/moderation.txt
    * and all the above.

Hope this helps,
jml

Stupid ideas:

1. Change new-held-message.txt to stop at the "visit:" line, wrap that after substitution and then use string concatenation to add the %(review_url)s and closing.

2. Set force_wrap=False in notify_message_held() and see if that works. You may need to unfill the only paragraph in new-held-message.txt that you really care about wrapping.

better idea:
    textwrap.wrap(break_long_words=False)

best idea:
    Updgrade to Pythong 2.6
    textwrap.wrap(break_on_hyphens=False)

Idea #2 doesn't work.

Stupid idea #3:

Add a `nowrap_func` argument to MailWrapper.format(). If non-None, call this on every line the wrapper wants to wrap. If it matches, skip the wrapping.

I have a branch implementing #3 and it works fairly well. I'll write a test and push the branch.

While this is fixed for mailing lists, I've received another e-mail today where I've noticed that the links are also truncated. I'm not sure if I should report a new bug for that, but in the meantime I'll just add the comment on this one for the record.

See the e-mail below and notice the truncated LP URL:

"
Hello David Planella,

Aron Xu (happyaron) has been added as a member of Launchpad Translations
Coordinators (launchpad-translations-coordinators) by David Planella
(dpm). Follow the link below for more details.

    https://edge.launchpad.net/~launchpad-translations-
coordinators/+member/happyaron
"