Launchpad itself

timeouts for branch listing for user with a *lot* of branches

Bug #397034 reported by James Westby
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Tim Penhey
Launchpad itself 3.1.10

Bug Description

https://code.edge.launchpad.net/~ubuntu-branches

is starting to timeout for me. This started occurring about 25,000 branches,
so it's unlikely to many users, but this overview is very useful for me.

Thanks,

James

Related branches

lp://qastaging/~thumper/launchpad/simplistic-official-links-speedup
Michael Hudson-Doyle: Approve
Diff: 242 lines
4 files modified
lib/lp/code/browser/branchlisting.py (+65/-23)
lib/lp/code/browser/tests/test_branchlisting.py (+23/-0)
lib/lp/code/interfaces/branch.py (+5/-5)
lib/lp/code/model/branch.py (+6/-2)
Revision history for this message
Tim Penhey (thumper) wrote :

Can I get you to check again, or to paste oops ids if you get them.

This works for me:

<!-- at least 345 queries issued in 3.61 seconds -->
<!-- Launchpad 2.2.6 (r8791) -->

Changed in launchpad-code:
status: New → Incomplete
Revision history for this message
Tim Penhey (thumper) wrote :

Actually I think this has to do with the inefficient way we generate lp: links for official package branches.

Changed in launchpad-code:
importance: Undecided → High
status: Incomplete → Triaged
Revision history for this message
James Westby (james-w) wrote :

e.g. OOPS-1286ED84

Thanks,

James

Ursula Junque (ursinha)
tags: added: timeout
Revision history for this message
Tim Penhey (thumper) wrote :

I'm looking at this now.

Changed in launchpad-code:
assignee: nobody → Tim Penhey (thumper)
milestone: none → 2.2.7
status: Triaged → In Progress
Revision history for this message
Tim Penhey (thumper) wrote :

This has been partially fixed, but not to my complete satisfaction yet. So deferring to 2.2.8 to finish the fix.

Changed in launchpad-code:
milestone: 2.2.7 → 2.2.8
Revision history for this message
Eledran (eledran-deactivatedaccount) wrote :

It does not only affect projects, it also strikes at individual users pages, such as lp:~mwhudson at edge and staging enviroment.

IDs:

Edge - OOPS-1307EA21

Staging - OOPS-1307S390

Revision history for this message
Tim Penhey (thumper) wrote :

Actually those ones are bug 396593 and should be ok when edge updates.

Revision history for this message
Tim Penhey (thumper) wrote :

Fixing this got trumped by the 3.0 UI work. Should be able to look at it for post 3.0.

The query count on these pages is still very high, but it doesn't seem to be timing out every time right now.

Changed in launchpad-code:
milestone: 2.2.8 → 3.1.10
Tim Penhey (thumper)
Changed in launchpad-code:
status: In Progress → Fix Committed
Diogo Matsubara (matsubara)
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.