UnicodeDecodeErrors on MP page
Bug #414852 reported by
Данило Шеган
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Tim Penhey | ||
Bug Description
Since sending my last email response to https:/
I am attaching a full email that probably caused it. The only Unicode character that I've removed are em-dashes as part of the diff (in emailtemplates/
OOPS-1325EA163
Related branches
lp://qastaging/~thumper/launchpad/fix-inline-diff-encoding
- Michael Nelson (community): Approve (release-critical)
- Michael Hudson-Doyle: Approve
-
Diff: 175 lines5 files modifiedlib/lp/code/browser/codereviewcomment.py (+34/-2)
lib/lp/code/browser/tests/test_branchmergeproposal.py (+37/-0)
lib/lp/code/mail/codereviewcomment.py (+5/-3)
lib/lp/code/mail/tests/test_codereviewcomment.py (+3/-2)
lib/lp/code/templates/codereviewcomment-body.pt (+2/-2)
Revision history for this message
| Данило Шеган (danilo) wrote | #1 |
Revision history for this message
| Tim Penhey (thumper) wrote | #2 |
| Changed in launchpad-code: | |
| importance: | Undecided → High |
| milestone: | none → 3.0 |
| status: | New → Triaged |
| tags: | added: code-review |
| Changed in launchpad-code: | |
| milestone: | 3.0 → 3.1.10 |
| Changed in launchpad-code: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Tim Penhey (thumper) |
| tags: | added: current-rollout-blocker |
Revision history for this message
| Michael Nelson (michael.nelson) wrote | #3 |
| Changed in launchpad-code: | |
| status: | In Progress → Fix Committed |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
It looks like another place where we aren't handling the unicode.
I think it is in the getting the attachment to render.